Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels on boot cpu

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Vivek Goyal <vgoyal@...>
Cc: Neil Horman <nhorman@...>, Neil Horman <nhorman@...>, Ben Woodard <woodard@...>, Andi Kleen <andi@...>, <kexec@...>, <linux-kernel@...>, Andi Kleen <ak@...>, <hbabu@...>, Eric W. Biederman <ebiederm@...>
Date: Friday, December 7, 2007 - 10:53 am

On Fri, Dec 07, 2007 at 09:39:44AM -0500, Vivek Goyal wrote:
Ok, that might be the case then.

I don't think so.  IIRC once the other cpus are started they all disable the
timer interrupt, except for one cpu, opting instead to get the timer tick via
ipi, So while they all might see the interrupt packet on the ht bus, only one
cpu will process it.

I disagree.  Looking at what Yinghai said, the default setting for the broadcast
bit isn't actually to unicast the interrupt, its just to set the broadcast mask
to 0xF, or to 0xFF.  Its use is actually to allow cpus with an extended 8 bit
apic id see interrupts.  So its not so much to direct interrupts to cpu0, but
rather to the first 16 cpus rather than to all 255 available cpus.  From what
I've seen in my testing, systems that 'work' already have this bit set by bios,
and my quirk patch above does nothing to them.  Disabling this bit after
calibrate_dealy is going to introduce more uncertainty in systems that have been
proven to work.  We should leave well enough alone, and just enable the bit if
its off, and we see that we are using extended apic ids via bit 18 of the same
register, as Yinghai pointed out.  By enabling the quirk that way, all we are
really doing is bringing into alignment two bits that should arguably be
set/cleared in unison anyway.

Regards
Neil


-- 
/***************************************************
 *Neil Horman
 *Software Engineer
 *Red Hat, Inc.
 *nhorman@redhat.com
 *gpg keyid: 1024D / 0x92A74FA1
 *http://pgp.mit.edu
 ***************************************************/
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Tue Nov 27, 12:12 am)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Tue Nov 27, 9:28 am)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Tue Nov 27, 10:56 am)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Wed Nov 28, 1:36 pm)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Wed Nov 28, 3:42 pm)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Thu Nov 29, 10:54 pm)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Wed Nov 28, 7:27 pm)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Mon Dec 10, 9:08 pm)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Tue Dec 11, 12:48 am)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Tue Dec 11, 11:29 am)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Tue Dec 11, 2:46 pm)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Wed Dec 12, 3:43 pm)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Wed Dec 12, 5:32 pm)
Re: [PATCH] k8: Enable legacy irqs with extended cpu ids, Eric W. Biederman, (Wed Dec 12, 4:43 am)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Mon Dec 10, 9:17 pm)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Neil Horman, (Fri Dec 7, 10:53 am)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Tue Nov 27, 11:30 am)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Tue Nov 27, 6:38 pm)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Tue Nov 27, 8:15 pm)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Tue Nov 27, 8:43 pm)
Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels..., Eric W. Biederman, (Tue Nov 27, 7:19 am)