Re: 2.6.24-rc4-mm1

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Dave Young
Date: Thursday, December 6, 2007 - 7:12 pm

Hi,

2.6.24-rc4-mm1 build failed at drivers/net/wireless/ath5k/base.c for some inline functions like this:
drivers/net/wireless/ath5k/base.c:292: sorry, unimplemented: inlining failed in call to 'ath5k_extend_tsf': function body not available

fix it with adjust the order of inline function body.

Signed-off-by: Dave Young <hidave.darkstar@gmail.com> 

---
drivers/net/wireless/ath5k/base.c |   67 ++++++++++++++++----------------------
1 file changed, 29 insertions(+), 38 deletions(-)

diff -upr linux/drivers/net/wireless/ath5k/base.c linux.new/drivers/net/wireless/ath5k/base.c
--- linux/drivers/net/wireless/ath5k/base.c	2007-12-07 10:01:42.000000000 +0800
+++ linux.new/drivers/net/wireless/ath5k/base.c	2007-12-07 10:01:49.000000000 +0800
@@ -250,8 +250,19 @@ static int 	ath5k_rxbuf_setup(struct ath
 static int 	ath5k_txbuf_setup(struct ath5k_softc *sc,
 				struct ath5k_buf *bf,
 				struct ieee80211_tx_control *ctl);
+
 static inline void ath5k_txbuf_free(struct ath5k_softc *sc,
-				struct ath5k_buf *bf);
+				struct ath5k_buf *bf)
+{
+	BUG_ON(!bf);
+	if (!bf->skb)
+		return;
+	pci_unmap_single(sc->pdev, bf->skbaddr, bf->skb->len,
+			PCI_DMA_TODEVICE);
+	dev_kfree_skb(bf->skb);
+	bf->skb = NULL;
+}
+
 /* Queues setup */
 static struct 	ath5k_txq *ath5k_txq_setup(struct ath5k_softc *sc,
 				int qtype, int subtype);
@@ -278,14 +289,29 @@ static int 	ath5k_beacon_setup(struct at
 				struct ieee80211_tx_control *ctl);
 static void 	ath5k_beacon_send(struct ath5k_softc *sc);
 static void 	ath5k_beacon_config(struct ath5k_softc *sc);
-static inline u64 ath5k_extend_tsf(struct ath5k_hw *ah, u32 rstamp);
+
+static inline u64 ath5k_extend_tsf(struct ath5k_hw *ah, u32 rstamp)
+{
+	u64 tsf = ath5k_hw_get_tsf64(ah);
+
+	if ((tsf & 0x7fff) < rstamp)
+		tsf -= 0x8000;
+
+	return (tsf & ~0x7fff) | rstamp;
+}
+
 /* Interrupt handling */
 static int 	ath5k_init(struct ath5k_softc *sc);
 static int 	ath5k_stop_locked(struct ath5k_softc *sc);
 static int 	ath5k_stop_hw(struct ath5k_softc *sc);
 static irqreturn_t ath5k_intr(int irq, void *dev_id);
 static void 	ath5k_tasklet_reset(unsigned long data);
-static inline void ath5k_update_txpow(struct ath5k_softc *sc);
+
+static inline void ath5k_update_txpow(struct ath5k_softc *sc)
+{
+	ath5k_hw_set_txpower_limit(sc->ah, 0);
+}
+
 static void 	ath5k_calibrate(unsigned long data);
 /* LED functions */
 static void 	ath5k_led_off(unsigned long data);
@@ -1341,21 +1367,6 @@ err_unmap:
 	return ret;
 }
 
-static inline void
-ath5k_txbuf_free(struct ath5k_softc *sc, struct ath5k_buf *bf)
-{
-	BUG_ON(!bf);
-	if (!bf->skb)
-		return;
-	pci_unmap_single(sc->pdev, bf->skbaddr, bf->skb->len,
-			PCI_DMA_TODEVICE);
-	dev_kfree_skb(bf->skb);
-	bf->skb = NULL;
-}
-
-
-
-
 /**************\
 * Queues setup *
 \**************/
@@ -2046,20 +2057,6 @@ ath5k_beacon_config(struct ath5k_softc *
 #undef TSF_TO_TU
 }
 
-static inline
-u64 ath5k_extend_tsf(struct ath5k_hw *ah, u32 rstamp)
-{
-	u64 tsf = ath5k_hw_get_tsf64(ah);
-
-	if ((tsf & 0x7fff) < rstamp)
-		tsf -= 0x8000;
-
-	return (tsf & ~0x7fff) | rstamp;
-}
-
-
-
-
 /********************\
 * Interrupt handling *
 \********************/
@@ -2295,12 +2292,6 @@ ath5k_tasklet_reset(unsigned long data)
 	ath5k_reset(sc->hw);
 }
 
-static inline void
-ath5k_update_txpow(struct ath5k_softc *sc)
-{
-	ath5k_hw_set_txpower_limit(sc->ah, 0);
-}
-
 /*
  * Periodically recalibrate the PHY to account
  * for temperature/environment changes.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.24-rc4-mm1, Andrew Morton, (Tue Dec 4, 10:17 pm)
2.6.24-rc4-mm1: kobj changes fallout on powerpc, Olof Johansson, (Wed Dec 5, 2:15 am)
Re: 2.6.24-rc4-mm1: kobj changes fallout on powerpc, Kamalesh Babulal, (Wed Dec 5, 6:11 am)
Re: 2.6.24-rc4-mm1 Kernel build fails on S390x, Kamalesh Babulal, (Wed Dec 5, 8:15 pm)
Re: 2.6.24-rc4-mm1, Reuben Farrelly, (Wed Dec 5, 11:59 pm)
Re: 2.6.24-rc4-mm1, David Miller, (Thu Dec 6, 12:09 am)
Re: 2.6.24-rc4-mm1 Kernel build fails on S390x, Andrew Morton, (Thu Dec 6, 12:19 am)
Re: 2.6.24-rc4-mm1, Andrew Morton, (Thu Dec 6, 12:35 am)
Re: 2.6.24-rc4-mm1, Valdis.Kletnieks, (Thu Dec 6, 4:49 am)
Re: 2.6.24-rc4-mm1, Andrew Morton, (Thu Dec 6, 5:04 am)
Re: 2.6.24-rc4-mm1, Valdis.Kletnieks, (Thu Dec 6, 12:18 pm)
Re: 2.6.24-rc4-mm1, Valdis.Kletnieks, (Thu Dec 6, 1:04 pm)
Re: [dm-devel] Re: 2.6.24-rc4-mm1, Kay Sievers, (Thu Dec 6, 3:04 pm)
Re: [dm-devel] Re: 2.6.24-rc4-mm1, Alasdair G Kergon, (Thu Dec 6, 3:12 pm)
Re: 2.6.24-rc4-mm1: VDSOSYM build error, Laurent Riffard, (Thu Dec 6, 3:28 pm)
Re: 2.6.24-rc4-mm1: VDSOSYM build error, Andrew Morton, (Thu Dec 6, 3:37 pm)
Re: [dm-devel] Re: 2.6.24-rc4-mm1, Valdis.Kletnieks, (Thu Dec 6, 4:12 pm)
Re: [dm-devel] Re: 2.6.24-rc4-mm1, Kay Sievers, (Thu Dec 6, 4:24 pm)
Re: 2.6.24-rc4-mm1: VDSOSYM build error, Miles Lane, (Thu Dec 6, 4:28 pm)
Re: 2.6.24-rc4-mm1: VDSOSYM build error, Andrew Morton, (Thu Dec 6, 4:34 pm)
Re: 2.6.24-rc4-mm1: VDSOSYM build error, Miles Lane, (Thu Dec 6, 4:47 pm)
[PATCH x86/mm] x86 vDSO: canonicalize sysenter .eh_frame, Roland McGrath, (Thu Dec 6, 6:14 pm)
Re: 2.6.24-rc4-mm1, Dave Young, (Thu Dec 6, 7:12 pm)
Re: 2.6.24-rc4-mm1: VDSOSYM build error, Ingo Molnar, (Fri Dec 7, 3:36 am)
Re: 2.6.24-rc4-mm1, Ilpo Järvinen, (Fri Dec 7, 6:16 am)
[PATCH] md: balance braces in raid5 debug code, Mariusz Kozlowski, (Fri Dec 7, 11:20 am)
Re: [dm-devel] Re: 2.6.24-rc4-mm1, Valdis.Kletnieks, (Fri Dec 7, 11:20 am)
Re: [dm-devel] Re: 2.6.24-rc4-mm1, Kay Sievers, (Fri Dec 7, 11:44 am)
Re: [dm-devel] Re: 2.6.24-rc4-mm1, Valdis.Kletnieks, (Fri Dec 7, 1:28 pm)
Re: [dm-devel] Re: 2.6.24-rc4-mm1, Kay Sievers, (Fri Dec 7, 1:49 pm)
Re: 2.6.24-rc4-mm1, Luis R. Rodriguez, (Fri Dec 7, 3:22 pm)
Re: 2.6.24-rc4-mm1: some issues on sparc64, Mariusz Kozlowski, (Sat Dec 8, 11:20 am)
Re: 2.6.24-rc4-mm1: some issues on sparc64, Andrew Morton, (Sat Dec 8, 11:22 am)
Re: 2.6.24-rc4-mm1: some issues on sparc64, David Miller, (Sun Dec 9, 1:45 am)
Re: 2.6.24-rc4-mm1: some issues on sparc64, Andrew Morton, (Sun Dec 9, 2:03 am)
Re: 2.6.24-rc4-mm1, Nick Kossifidis, (Sun Dec 9, 10:55 am)
Re: 2.6.24-rc4-mm1, Dave Young, (Sun Dec 9, 6:07 pm)
Re: broken suspend (sched related) [Was: 2.6.24-rc4-mm1], Gautham R Shenoy, (Mon Dec 10, 1:19 am)
Re: broken suspend (sched related) [Was: 2.6.24-rc4-mm1], Gautham R Shenoy, (Mon Dec 10, 3:15 am)
Re: broken suspend (sched related) [Was: 2.6.24-rc4-mm1], Gautham R Shenoy, (Mon Dec 10, 4:08 am)
Re: broken suspend (sched related) [Was: 2.6.24-rc4-mm1], Gautham R Shenoy, (Mon Dec 10, 4:49 am)
Re: 2.6.24-rc4-mm1, Reuben Farrelly, (Mon Dec 10, 7:48 am)
Re: 2.6.24-rc4-mm1, Ilpo Järvinen, (Mon Dec 10, 1:05 pm)
Re: 2.6.24-rc4-mm1, Andrew Morton, (Mon Dec 10, 2:11 pm)
Re: 2.6.24-rc4-mm1, Reuben Farrelly, (Tue Dec 11, 7:12 am)
Re: 2.6.24-rc4-mm1, Martin Bligh, (Tue Dec 11, 9:20 am)
Re: 2.6.24-rc4-mm1, Randy Dunlap, (Tue Dec 11, 9:59 am)
Re: 2.6.24-rc4-mm1, Martin Bligh, (Tue Dec 11, 10:50 am)
Re: 2.6.24-rc4-mm1, Rik van Riel, (Tue Dec 11, 9:16 pm)
Re: 2.6.24-rc4-mm1, Cedric Le Goater, (Wed Dec 12, 10:57 am)
Re: 2.6.24-rc4-mm1, Cedric Le Goater, (Wed Dec 12, 12:21 pm)
Re: 2.6.24-rc4-mm1 - BUG in tcp_fragment, Cedric Le Goater, (Thu Dec 13, 10:45 am)
Re: 2.6.24-rc4-mm1 - BUG in tcp_fragment, Ilpo Järvinen, (Thu Dec 13, 4:00 pm)