Home » Mailing list archives » linux-kernel » 2007 » December » 5

drivers/net/iseries_veth.c dubious sysfs usage

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Greg KH <greg@...>
To: Kyle A. Lucke <klucke@...>, David Gibson <dwg@...>
Cc: <linux-kernel@...>, <paulus@...>, <linuxppc-dev@...>
Subject: drivers/net/iseries_veth.c dubious sysfs usage
Date: Wednesday, December 5, 2007 - 5:30 am

In doing a massive kobject cleanup of the kernel tree, I ran across the
iseries_veth.c driver.

It looks like the driver is creating a number of subdirectories under
the driver sysfs directory.  This is odd and probably wrong.  You want
these virtual connections to show up in the main sysfs device tree, not
under the driver directory.

I'll be glad to totally guess and try to move it around in the sysfs
tree, but odds are I'll get it all wrong as I can't really test this
out :)

Any hints on what this driver is trying to do in this sysfs directories?

thanks,

greg k-h
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
drivers/net/iseries_veth.c dubious sysfs usage, Greg KH, (Wed Dec 5, 5:30 am)
Re: drivers/net/iseries_veth.c dubious sysfs usage, Michael Ellerman, (Wed Dec 5, 7:10 am)
Re: drivers/net/iseries_veth.c dubious sysfs usage, Greg KH, (Wed Dec 5, 5:41 pm)
Re: drivers/net/iseries_veth.c dubious sysfs usage, Michael Ellerman, (Wed Dec 5, 11:48 pm)
Re: drivers/net/iseries_veth.c dubious sysfs usage, Greg KH, (Thu Dec 13, 3:08 am)
Re: drivers/net/iseries_veth.c dubious sysfs usage, Stephen Rothwell, (Sun Dec 23, 10:52 pm)
Re: drivers/net/iseries_veth.c dubious sysfs usage, Greg KH, (Mon Dec 24, 1:01 am)
[PATCH] Introduce driver_create/remove_dir, Stephen Rothwell, (Tue Dec 11, 7:56 pm)
Re: [PATCH] Introduce driver_create/remove_dir, Greg KH, (Thu Dec 13, 3:10 am)
Re: [PATCH] Introduce driver_create/remove_dir, Randy Dunlap, (Tue Dec 11, 8:40 pm)
Re: [PATCH] Introduce driver_create/remove_dir, Stephen Rothwell, (Tue Dec 11, 10:36 pm)