Home » Mailing list archives » linux-kernel » 2007 » December » 4

[PATCH 12/23] Subject: SCHED - Allow current_cpu to be included in search

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Gregory Haskins <ghaskins@...>
To: <mingo@...>
Cc: <rostedt@...>, <ghaskins@...>, <linux-rt-users@...>, <linux-kernel@...>
Subject: [PATCH 12/23] Subject: SCHED - Allow current_cpu to be included in search
Date: Tuesday, December 4, 2007 - 4:45 pm

It doesn't hurt if we allow the current CPU to be included in the
search.  We will just simply skip it later if the current CPU turns out
to be the lowest.

We will use this later in the series

Signed-off-by: Gregory Haskins <ghaskins@novell.com>
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---

 kernel/sched_rt.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
index 7e26c2c..7e444f4 100644
--- a/kernel/sched_rt.c
+++ b/kernel/sched_rt.c
@@ -275,9 +275,6 @@ static int find_lowest_rq(struct task_struct *task)
 	for_each_cpu_mask(cpu, *cpu_mask) {
 		struct rq *rq = cpu_rq(cpu);
 
-		if (cpu == rq->cpu)
-			continue;
-
 		/* We look for lowest RT prio or non-rt CPU */
 		if (rq->rt.highest_prio >= MAX_RT_PRIO) {
 			lowest_rq = rq;
@@ -305,7 +302,7 @@ static struct rq *find_lock_lowest_rq(struct task_struct *task,
 	for (tries = 0; tries < RT_MAX_TRIES; tries++) {
 		cpu = find_lowest_rq(task);
 
-		if (cpu == -1)
+		if ((cpu == -1) || (cpu == rq->cpu))
 			break;
 
 		lowest_rq = cpu_rq(cpu);

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/23] RT balance v7, Gregory Haskins, (Tue Dec 4, 4:44 pm)
Re: [PATCH 00/23] RT balance v7, Ingo Molnar, (Tue Dec 4, 5:27 pm)
[PATCH 0/3] RT balance v7a, Gregory Haskins, (Tue Dec 4, 10:55 pm)
[PATCH 3/3] Subject: SCHED - Use a 2-d bitmap for searching ..., Gregory Haskins, (Tue Dec 4, 10:55 pm)
Re: [PATCH 3/3] Subject: SCHED - Use a 2-d bitmap for search..., Ingo Molnar, (Wed Dec 5, 5:34 am)
Re: [PATCH 3/3] Subject: SCHED - Use a 2-d bitmap for search..., Gregory Haskins, (Wed Dec 5, 6:19 am)
Re: [PATCH 3/3] Subject: SCHED - Use a 2-d bitmap for search..., Ingo Molnar, (Wed Dec 5, 7:44 am)
Re: [PATCH 3/3] Subject: SCHED - Use a 2-d bitmap for search..., Gregory Haskins, (Wed Dec 5, 9:41 am)
[PATCH 2/3] Subject: SCHED - Only balance our RT tasks withi..., Gregory Haskins, (Tue Dec 4, 10:55 pm)
[PATCH 1/3] Subject: SCHED - Add sched-domain roots, Gregory Haskins, (Tue Dec 4, 10:55 pm)
Re: [PATCH 00/23] RT balance v7, Gregory Haskins, (Tue Dec 4, 5:35 pm)
[PATCH 23/23] Subject: SCHED - Use a 2-d bitmap for searchin..., Gregory Haskins, (Tue Dec 4, 4:46 pm)
[PATCH 22/23] Subject: SCHED - Only balance our RT tasks wit..., Gregory Haskins, (Tue Dec 4, 4:46 pm)
[PATCH 21/23] Subject: SCHED - Add sched-domain roots, Gregory Haskins, (Tue Dec 4, 4:46 pm)
[PATCH 20/23] Subject: SCHED - balance RT tasks no new wake up, Gregory Haskins, (Tue Dec 4, 4:46 pm)
[PATCH 16/23] Subject: SCHED - Avoid overload, Gregory Haskins, (Tue Dec 4, 4:45 pm)
[PATCH 14/23] Subject: SCHED - Optimize our cpu selection ba..., Gregory Haskins, (Tue Dec 4, 4:45 pm)
[PATCH 19/23] Subject: SCHED - Optimize out cpu_clears, Gregory Haskins, (Tue Dec 4, 4:46 pm)
[PATCH 18/23] Subject: SCHED - Optimize cpu search with hamm..., Gregory Haskins, (Tue Dec 4, 4:45 pm)
[PATCH 15/23] Subject: SCHED - Optimize rebalancing, Gregory Haskins, (Tue Dec 4, 4:45 pm)
[PATCH 17/23] Subject: SCHED - restore the migratable condit..., Gregory Haskins, (Tue Dec 4, 4:45 pm)
[PATCH 13/23] Subject: SCHED - Pre-route RT tasks on wakeup, Gregory Haskins, (Tue Dec 4, 4:45 pm)
[PATCH 10/23] Subject: SCHED - Remove some CFS specific code..., Gregory Haskins, (Tue Dec 4, 4:45 pm)
[PATCH 12/23] Subject: SCHED - Allow current_cpu to be inclu..., Gregory Haskins, (Tue Dec 4, 4:45 pm)
[PATCH 11/23] Subject: SCHED - Break out the search function, Gregory Haskins, (Tue Dec 4, 4:45 pm)
[PATCH 09/23] Subject: SCHED - Consistency cleanup for this_..., Gregory Haskins, (Tue Dec 4, 4:45 pm)
[PATCH 08/23] Subject: SCHED - Cache cpus_allowed weight for..., Gregory Haskins, (Tue Dec 4, 4:45 pm)
[PATCH 03/23] Subject: SCHED - push RT tasks, Gregory Haskins, (Tue Dec 4, 4:44 pm)
[PATCH 06/23] Subject: SCHED - wake up balance RT, Gregory Haskins, (Tue Dec 4, 4:44 pm)
[PATCH 07/23] Subject: SCHED - disable CFS RT load balancing., Gregory Haskins, (Tue Dec 4, 4:45 pm)
[PATCH 05/23] Subject: SCHED - pull RT tasks, Gregory Haskins, (Tue Dec 4, 4:44 pm)
[PATCH 04/23] Subject: SCHED - RT overloaded runqueues accou..., Gregory Haskins, (Tue Dec 4, 4:44 pm)
[PATCH 02/23] Subject: SCHED - track highest prio queued on ..., Gregory Haskins, (Tue Dec 4, 4:44 pm)
[PATCH 01/23] Subject: SCHED - Add rt_nr_running accounting, Gregory Haskins, (Tue Dec 4, 4:44 pm)