[PATCH 02/23] Subject: SCHED - track highest prio queued on runqueue

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <mingo@...>
Cc: <rostedt@...>, <ghaskins@...>, <linux-rt-users@...>, <linux-kernel@...>
Date: Tuesday, December 4, 2007 - 4:44 pm

From: Steven Rostedt <srostedt@redhat.com>

This patch adds accounting to each runqueue to keep track of the
highest prio task queued on the run queue. We only care about
RT tasks, so if the run queue does not contain any active RT tasks
its priority will be considered MAX_RT_PRIO.

This information will be used for later patches.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---

 kernel/sched.c    |    3 +++
 kernel/sched_rt.c |   18 ++++++++++++++++++
 2 files changed, 21 insertions(+), 0 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 4751c2f..90c04fd 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -267,6 +267,8 @@ struct rt_rq {
 	int rt_load_balance_idx;
 	struct list_head *rt_load_balance_head, *rt_load_balance_curr;
 	unsigned long rt_nr_running;
+	/* highest queued rt task prio */
+	int highest_prio;
 };
 
 /*
@@ -6783,6 +6785,7 @@ void __init sched_init(void)
 		rq->cpu = i;
 		rq->migration_thread = NULL;
 		INIT_LIST_HEAD(&rq->migration_queue);
+		rq->rt.highest_prio = MAX_RT_PRIO;
 #endif
 		atomic_set(&rq->nr_iowait, 0);
 
diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
index a6271f4..4d5b9b2 100644
--- a/kernel/sched_rt.c
+++ b/kernel/sched_rt.c
@@ -30,6 +30,10 @@ static inline void inc_rt_tasks(struct task_struct *p, struct rq *rq)
 {
 	WARN_ON(!rt_task(p));
 	rq->rt.rt_nr_running++;
+#ifdef CONFIG_SMP
+	if (p->prio < rq->rt.highest_prio)
+		rq->rt.highest_prio = p->prio;
+#endif /* CONFIG_SMP */
 }
 
 static inline void dec_rt_tasks(struct task_struct *p, struct rq *rq)
@@ -37,6 +41,20 @@ static inline void dec_rt_tasks(struct task_struct *p, struct rq *rq)
 	WARN_ON(!rt_task(p));
 	WARN_ON(!rq->rt.rt_nr_running);
 	rq->rt.rt_nr_running--;
+#ifdef CONFIG_SMP
+	if (rq->rt.rt_nr_running) {
+		struct rt_prio_array *array;
+
+		WARN_ON(p->prio < rq->rt.highest_prio);
+		if (p->prio == rq->rt.highest_prio) {
+			/* recalculate */
+			array = &rq->rt.active;
+			rq->rt.highest_prio =
+				sched_find_first_bit(array->bitmap);
+		} /* otherwise leave rq->highest prio alone */
+	} else
+		rq->rt.highest_prio = MAX_RT_PRIO;
+#endif /* CONFIG_SMP */
 }
 
 static void enqueue_task_rt(struct rq *rq, struct task_struct *p, int wakeup)

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00/23] RT balance v7, Gregory Haskins, (Tue Dec 4, 4:44 pm)
Re: [PATCH 00/23] RT balance v7, Ingo Molnar, (Tue Dec 4, 5:27 pm)
[PATCH 0/3] RT balance v7a, Gregory Haskins, (Tue Dec 4, 10:55 pm)
[PATCH 1/3] Subject: SCHED - Add sched-domain roots, Gregory Haskins, (Tue Dec 4, 10:55 pm)
Re: [PATCH 00/23] RT balance v7, Gregory Haskins, (Tue Dec 4, 5:35 pm)
[PATCH 21/23] Subject: SCHED - Add sched-domain roots, Gregory Haskins, (Tue Dec 4, 4:46 pm)
[PATCH 16/23] Subject: SCHED - Avoid overload, Gregory Haskins, (Tue Dec 4, 4:45 pm)
[PATCH 19/23] Subject: SCHED - Optimize out cpu_clears, Gregory Haskins, (Tue Dec 4, 4:46 pm)
[PATCH 15/23] Subject: SCHED - Optimize rebalancing, Gregory Haskins, (Tue Dec 4, 4:45 pm)
[PATCH 03/23] Subject: SCHED - push RT tasks, Gregory Haskins, (Tue Dec 4, 4:44 pm)
[PATCH 06/23] Subject: SCHED - wake up balance RT, Gregory Haskins, (Tue Dec 4, 4:44 pm)
[PATCH 05/23] Subject: SCHED - pull RT tasks, Gregory Haskins, (Tue Dec 4, 4:44 pm)
[PATCH 02/23] Subject: SCHED - track highest prio queued on ..., Gregory Haskins, (Tue Dec 4, 4:44 pm)