Re: [local DoS] Re: Linux 2.6.24-rc4

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Linus Torvalds <torvalds@...>, Linux Kernel Mailing List <linux-kernel@...>, <herton@...>, <dvgevers@...>
Date: Tuesday, December 4, 2007 - 12:04 pm

Em Tue, 4 Dec 2007 17:00:05 +0100
Ingo Molnar <mingo@elte.hu> escreveu:

| 
| * Linus Torvalds <torvalds@linux-foundation.org> wrote:
| 
| > 
| > 
| > On Tue, 4 Dec 2007, Luiz Fernando N. Capitulino wrote:
| > >
| > > 	sched_rr_get_interval(1, NULL);
| > 
| > Looks like we have a zero "cfs_rq->load.weight".
| > 
| > Ingo? Both sched_slice() and __sched_slice() do a divide by the 
| > runqueue weight, and at least dequeue_task_fair() explicitly checks 
| > for that being zero, so clearly zero is a possible value. Hmm?
| 
| yeah, i can reproduce this crash too.
| 
| The problem is on SMP: if sched_rr_get_interval() gets a task from an 
| otherwise idle runqueue, then rq->load.weight is 0. Normally 
| sched_slice() is only used on a busy runqueue. So the correct fixup site 
| is not in sched_slice() but in sys_sched_rr_get_interval() - i'm working 
| on the right fix, i hope to be able to send a pull request in a few 
| minutes.

 Ingo, I can reproduce this w/o SMP support as well.

 (Also, the backtrace I sent was reproduced on a UP machine with a
SMP kernel).

-- 
Luiz Fernando N. Capitulino
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Linux 2.6.24-rc4, Linus Torvalds, (Tue Dec 4, 1:08 am)
Re: Linux 2.6.24-rc4, Diego Calleja, (Tue Dec 4, 8:23 pm)
[local DoS] Re: Linux 2.6.24-rc4, Luiz Fernando N. Capitulino..., (Tue Dec 4, 10:07 am)
Re: [local DoS] Re: Linux 2.6.24-rc4, Linus Torvalds, (Tue Dec 4, 11:56 am)
Re: [local DoS] Re: Linux 2.6.24-rc4, Ingo Molnar, (Tue Dec 4, 12:00 pm)
[git pull] scheduler fixes, Ingo Molnar, (Tue Dec 4, 12:18 pm)
Re: [git pull] scheduler fixes, Greg KH, (Tue Dec 4, 2:28 pm)
Re: [git pull] scheduler fixes, Luiz Fernando N. Capitulino..., (Tue Dec 4, 2:41 pm)
Re: [git pull] scheduler fixes, Ingo Molnar, (Tue Dec 4, 5:04 pm)
Re: [git pull] scheduler fixes, Luiz Fernando N. Capitulino..., (Tue Dec 4, 12:40 pm)
Re: [local DoS] Re: Linux 2.6.24-rc4, Luiz Fernando N. Capitulino..., (Tue Dec 4, 12:04 pm)
Re: [local DoS] Re: Linux 2.6.24-rc4, Ingo Molnar, (Tue Dec 4, 12:08 pm)
Re: Linux 2.6.24-rc4, Nicolas Pitre, (Tue Dec 4, 9:22 am)
Re: Linux 2.6.24-rc4, Jeff Garzik, (Tue Dec 4, 12:04 pm)
[build failure] Re: Linux 2.6.24-rc4 on S390x, Kamalesh Babulal, (Tue Dec 4, 6:23 am)
Re: [build failure] Re: Linux 2.6.24-rc4 on S390x, Ingo Molnar, (Tue Dec 4, 6:32 am)
Re: [build failure] Re: Linux 2.6.24-rc4 on S390x, Martin Schwidefsky, (Tue Dec 4, 6:31 am)