linux-kernel mailing list

FromSubjectsort iconDate
Samuel Thibault
[PATCH][DOC] Console is utf-8 by default
The console is now by default in UTF-8 mode, so let's document this. BTW, document the needed "vt." prefix. Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org> --- Documentation/kernel-parameters.txt.orig 2007-12-26 00:01:44.000000000 +0100 +++ Documentation/kernel-parameters.txt 2007-12-23 22:56:31.000000000 +0100 @@ -527,30 +527,29 @@ Format: <area>[,<node>] See also Documentation/networking/decnet.txt. - vt.default_blu= [VT] + default_blu= [VT] For...
Dec 25, 7:11 pm 2007
H. Peter Anvin Dec 25, 7:45 pm 2007
Pavel Machek
[RFC] sleepy linux
This is RFC. It does not even work for me... it sleeps but it will not wake up, because SATA wakeup code is missing. Code attached for illustration. I wonder if this is the right approach? What is right interface to the drivers? Sleepy Linux ~~~~~~~~~~~~ Copyright 2007 Pavel Machek <pavel@suse.cz> GPLv2 Current Linux versions can enter suspend-to-RAM just fine, but only can do it on explicit request. But suspend-to-RAM is important, eating something like 10% of power needed ...
Dec 25, 7:07 pm 2007
Andrew Morton
Re: [PATCH] AMD Thermal Interrupt Support
Please never add extern declarations in C files - find a suitable header smp_call_function_single() already takes care of the eek, google coding "style" ;) afaict this function is called while the calling thread is running preemptibly. This smp_processor_id() call should have generated a runtime warning if it was tested with all debug options enabled? The logic in this function looks more complex than it needs to be. if (num_k8_northbridges == 0) goto out; for (nb_num = 0; nb_n...
Dec 25, 6:04 pm 2007
Andrew Morton
Re: [PATCH] pcmcia: Add support P2CCLK bit enabler for TI PC...
It would be much better if we cold do this without the config option: just detect the appropriate device and make it work. --
Dec 25, 6:04 pm 2007
Erez Zadok
checkpatch false ERROR: trailing statements should be on nex...
Using v2.6.24-rc6-125-g5356f66, code such as this: if (is_file) /* dirs can be unlinked but chdir'ed to */ err = -ESTALE; produces this false checkpatch error: foo.c:947: ERROR: trailing statements should be on next line I think comments such as the above should be allowed (plus a comment isn't a statement). It's often very useful to put them right on the affected line. Thanks, Erez. --
Dec 25, 5:50 pm 2007
Peter Stark
[PATCH] USB serial ftdi_sio - enabling multiple ELV devices,...
I work with a group of people on a free home automation tool called FHEM. Some of the users own more than one USB-serial device by ELV. The ftdi_sio driver has most of the ELV devices disabled by default and needs to be re-enabled every time you get a new kernel. Additionally a new device (EM 1010 PC - enegry monitor) is missing in the list. Currently our users have to follow the instructions we provide at http://www.koeniglich.de/fhem/linux.html ... However, to some users it is too complicated ...
Dec 25, 1:32 pm 2007
Cyrill Gorcunov
[x86] is checkpatch.pl broken
Hi list, by doing cleanup of arch/x86/boot/*.[ch] i found that checkpatch does ignore obvious things. For example, run it over edd.c showed only one warning: --- cyrill@cvg linux-2.6.git $ scripts/checkpatch.pl --file arch/x86/boot/edd.c WARNING: externs should be avoided in .c files #45: FILE: x86/boot/edd.c:45: + extern char _end[]; total: 0 errors, 1 warnings, 167 lines checked Your patch has style problems, please review. If any of these errors are false positives report them ...
Dec 25, 1:07 pm 2007
H. Peter Anvin
Re: [x86] is checkpatch.pl broken
BTW, it's more than a wee bit rude of you to Cc: a bunch of people but not the listed maintainer of the piece of code you're claiming to be cleaning up. -hpa --
Dec 25, 7:48 pm 2007
H. Peter Anvin
Re: [x86] is checkpatch.pl broken
I'm generally skeptical to the kind of "cleanups" that you seem to be referring to. More often then not they reduce legibility instead of the If checkpatch considered that line to be a problem, I would consider checkpatch to be utterly broken. That line is perfectly legible, and padding in a bunch of spaces would make it LESS so, especially since it would have to be split between lines. -hpa --
Dec 25, 7:47 pm 2007
Marcin Slusarz
[PATCH] ocfs2: convert byte order of constant instead of var...
convert byte order of constant instead of variable it will be done at compile time (vs run time) remove unused le32_and_cpu Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> CC: Mark Fasheh <mark.fasheh@oracle.com> CC: Kurt Hackel <kurt.hackel@oracle.com> --- fs/ocfs2/endian.h | 5 ----- fs/ocfs2/inode.c | 2 +- 2 files changed, 1 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/endian.h b/fs/ocfs2/endian.h index ff25762..1942e09 100644 --- a/fs/ocfs2/endi...
Dec 25, 10:52 am 2007
Marcin Slusarz
[PATCH] ext2/3/4: convert byte order of constant instead of ...
convert byte order of constant instead of variable it will be done at compile time (vs run time) ext3/4 bits are #if 0'ed, but someone might copy this code into other places Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> --- fs/ext2/super.c | 8 +++----- fs/ext3/super.c | 2 +- fs/ext4/super.c | 2 +- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 154e25f..3ccbe32 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super...
Dec 25, 10:51 am 2007
Marcin Slusarz
[PATCH] qla3xxx: convert byte order of constant instead of v...
convert byte order of constant instead of variable it will be done at compile time (vs run time) Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> --- drivers/net/qla3xxx.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index a579111..c9f8ba4 100644 --- a/drivers/net/qla3xxx.c +++ b/drivers/net/qla3xxx.c @@ -2497,8 +2497,7 @@ static int ql_send_map(struct ql3_adapter *qdev, if (seg_cnt == 1) { /*...
Dec 25, 10:48 am 2007
Pierre Ossman
Re: relation between mmc_request, mmc_data and mmc_command
On Sun, 23 Dec 2007 23:25:26 -0800 Yes on all accounts. I don't know the reason for this extreme redundancy. I= It is correct that it is used for multi block writes. But also other open e= nded transfers. If the stop command fails, then the card will be in an unknown state. The w= rite should have been completed though. Rgds Pierre
Dec 25, 9:35 am 2007
Akinobu Mita
[PATCH] xip: fix get_zeroed_page with __GFP_HIGHMEM
The use of get_zeroed_page() with __GFP_HIGHMEM is invalid. Use alloc_page() with __GFP_ZERO instead of invalid get_zeroed_page(). (This patch is only compile tested) Cc: Carsten Otte <cotte@de.ibm.com> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> --- mm/filemap_xip.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) Index: 2.6-git/mm/filemap_xip.c =================================================================== --- 2.6-git.orig/mm/filemap_xip.c +++...
Dec 25, 9:21 am 2007
Tetsuo Handa
TOMOYO Linux Security Goal
This document is intended to specify the security goal that TOMOYO Linux is trying to achieve, so that users can evaluate whether TOMOYO Linux will meet their needs, and kernel developers can evaluate whether TOMOYO Linux deserved to be in-tree. 1. About TOMOYO Linux Project Homepage: http://tomoyo.sourceforge.jp/index.html.en Project Wiki: http://elinux.org/TomoyoLinux TOMOYO Linux is a DIY tool for understanding and protecting your system. TOMOYO Linux policy definitions are absolutely reada...
Dec 25, 8:33 am 2007
Arjan van de Ven
[Patch v2] Make PCI extended config space (MMCONFIG) a drive...
From: Arjan van de Ven <arjan@linux.intel.com> Subject: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in On PCs, PCI extended configuration space (4Kb) is riddled with problems associated with the memory mapped access method (MMCONFIG). At the same time, there are very few machines that actually need or use this extended configuration space. At this point in time, the only sensible action is to make access to the extended configuration space an opt-in operation for t...
Dec 25, 7:26 am 2007
Dave Young
[BUG][PATCH -mm] bluetooth : rfcomm add get/put device in de...
Due to 2.6.24-rc6-mm1 kernel changes (maybe kobject or driver core), If I exec: rfcomm connect 0 1 kernel will oops after connect timeout. hand copy some oops text: EIP is at driver_sysfs_remove+0x1a/0x40 Call Trace: show_trace_log_lvl+0x1a/0x30 show_stack_log_lvl+0x9a/0xc0 show_registers+0xc7/0x270 die+0x129/0x240 do_page_fault+0x3a1/0x670 error_code+0x72/0x78 __device_release_driver+0x1e/0xa0 device_release_driver+0x30/0x50 bus_remove_device+0x63/0x90 device_del+0x55/0x190...
Dec 25, 6:03 am 2007
Dave Young
Re: [BUG][PATCH -mm] bluetooth : rfcomm add get/put device i...
Hi greg, BTW, Is it a possible bug of driver core or kobject ? Regards dave --
Dec 25, 6:07 am 2007
lewis_zyxel
2 ports could not bond to a aggregator in 802.3ad mode issue
I wish to be personally CC'ed the answers/comments posted to the list in response to my posting. I have 2 ports(eth0, eth1) in my device. I use kernel(2.6.23) bonding driver v3.1.3 (June 13, 2007) to bond 2 ports to one aggregator and use the following commands to setup the environment: insmod ./bonding.ko mode=4 miimon=100 ifconfig bond0 172.23.26.223 netmask 255.255.255.0 ifconfig eth0 down ifconfig eth1 down ifenslave bond0 eth0 eth1 After the setting, I cat the proc entry and got the fo...
Dec 25, 3:40 am 2007
Zhang, Yanmin
volanoMark 24% regression in 2.6.24-rc6: why a simple patch ...
With kernel 2.6.24-rc6, volanoMark has much regression. 1) On 8-core stoakley: 17%; 2) On 16-core tigerton: 24%. I bisected it down to patch fbdcf18df73758b2e187ab94678b30cd5f6ff9f9. It is to fix the bad cpu number in /proc/cpuinfo. As a matter of fact, this issue is already fixed by other 2 patches: 699d934d5f958d7944d195c03c334f28cc0b3669 and c0c52d28e05e8bdaa2126570c02ecb1a7358cecc. At the first glance, the patch looks good, at least no conflict with the other 2 patches. After double-chec...
Dec 25, 1:14 am 2007
Ingo Molnar
Re: volanoMark 24% regression in 2.6.24-rc6: why a simple pa...
Linus, please revert fbdcf18df73758, as requested by Yanmin. It was noticed before (by Yinghai Lu) that this commit was not needed, but it looked a harmless duplication and we incorrectly thought it's only a NOP and wanted to fix it in v2.6.25 - but as Yanmin has analyzed it now, it creates a sub-optimal sched-domains hierarchy (not setting up the domain belonging to the core) when CONFIG_X86_HT=y. Acked-by: Ingo Molnar <mingo@elte.hu> nice work Yanmin! Ingo --
Dec 25, 4:25 am 2007
Jeff Mitchell
HSM violation errors
I'm seeing errors in dmesg and the like. It appears to be somewhat similar to the issue reported here: http://kerneltrap.org/mailarchive/linux-kernel/2007/8/25/164711 except that my machine doesn't freeze, and everything seems normal -- hopefully nothing like silent corruption is going on. Also it's on brand new hardware...Intel ICH8 mobile chipset with AHCI. Output from dmesg, hdparm -I /dev/sda and hdparm --drq-hsm-error /dev/sda is below...please let me know if there's anything else that would ...
Dec 25, 12:53 am 2007
Denys Fedoryshchenko
nmi_watchdog killing tickless feature
Hi Please CC me on reply, i am not subscribed to list. I did small test, and notice that if nmi_watchdog is enabled mpstat 1 06:11:00 CPU %user %nice %sys %iowait %irq %soft %steal %idle intr/s 06:11:01 all 0.00 0.00 0.00 0.00 0.00 0.00 0.00 100.00 993.07 06:11:02 all 0.00 0.00 0.00 0.00 0.00 0.00 0.00 100.00 1007.00 06:11:03 all 0.00 0.00 0.00 0.00 0.00 0.00 0.00 100.00 1005.00 if ...
Dec 25, 12:36 am 2007
Carlos Corbacho
Re: x86: Increase PCIBIOS_MIN_IO to 0x1500 to fix nForce 4 s...
That is from the 3.0 spec though. And it looks like the definition changed from pre-3.0 to 3.0 and above. This is what the 1.0B spec says (and this is also repeated verbatim in 2.0, 2.0a, 2.0b, and 2.0c): "The _PTS control method is executed by the operating system at the beginning of the sleep process for S1, S2, S3, S4, and for orderly S5 shutdown. The sleeping state value (1, 2, 3, 4, or 5) is passed to the _PTS control method. Before the OS notifies native device drivers and prepares t...
Dec 24, 8:03 pm 2007
Rafael J. Wysocki
Re: x86: Increase PCIBIOS_MIN_IO to 0x1500 to fix nForce 4 s...
Well, citing from the ACPI 2.0 specification, section 9.1.6 Transitioning from the Working to the Sleeping State (which is what we're discussing here): 3. OSPM places all device drivers into their respective Dx state. If the device is enabled for wake, it enters the Dx state associated with the wake capability. If the device is not enabled to wake the system, it enters the D3 state. 4. OSPM executes the _PTS control method, passing an argument that indicates the desired sleeping state...
Dec 25, 9:26 am 2007
Carlos Corbacho
Re: x86: Increase PCIBIOS_MIN_IO to 0x1500 to fix nForce 4 s...
This is that same section from ACPI 1.0B: 3. The OS executes the Prepare To Sleep (_PTS) control method, passing an argument that indicates the desired sleeping state (1, 2, 3, or 4 representing S1, S2, S3, and S4). 4. The OS places all device drivers into their respective Dx state. If the device is enabled for wakeup, it enters the Dx state associated with the wakeup capability. If the device is not enabled to wakeup the system, it enters the D3 state. No, I'm not entirely wrong - read ...
Dec 25, 9:12 am 2007
Robert Hancock
Re: x86: Increase PCIBIOS_MIN_IO to 0x1500 to fix nForce 4 s...
Correct me if I'm wrong, but it appears ACPI 1.0 wants _PTS called before any devices are suspended, ACPI 2.0 is contradictory, and ACPI 3.0 says that you can't assume anything about device state. My guess is that unless Windows has different behavior depending on ACPI version, it probably has called _PTS before suspending devices all along. Therefore it would likely be safest to emulate that behavior, no? -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from hancockr...
Dec 25, 1:17 pm 2007
Rafael J. Wysocki
Re: x86: Increase PCIBIOS_MIN_IO to 0x1500 to fix nForce 4 s...
Well, I don't think so. In fact ACPI 3.0 repeats the 2.0 wording in section 9.1.6 (so the current requirement seems to be to put devices into low power states before calling _PTS) and I _guess_ there was a change in the default behavior of Windows that caused the specification to be modified (I'd bet that was between 2000 and XP or something like this). IMO, we should check which version of the specification we're supposed to follow, on the basis of FADT contents, for example, and follow this o...
Dec 25, 2:26 pm 2007
Rafael J. Wysocki
Re: x86: Increase PCIBIOS_MIN_IO to 0x1500 to fix nForce 4 s...
I think we should follow section 9.3.2 that is explicit and has been reiterated Yes, we are. OK, I think we can rearrange things to call _PTS early for ACPI 1.0x-compliant systems. Thanks, Rafael --
Dec 25, 10:11 am 2007
Carlos Corbacho
ACPI: _PTS ordering needs fixing for pre ACPI 3.0 systems (...
Adding Linux-ACPI to CC. The following is a hack to illustrate what I'm getting at (this is tested on x86-64) (it's a hack since it does all the ACPI prepare bits during set_target() for the pre ACPI 3.0 systems, rather than prepare() - whether this can be cleaned up to move out just the _PTS() call, I don't know). It abuses suspend_ops->set_target(), but was the easiest way to quickly demonstrate this (since the kerneldoc for set_target() says it will always be executed before we suspend t...
Dec 24, 10:41 pm 2007
Rafael J. Wysocki
Re: ACPI: _PTS ordering needs fixing for pre ACPI 3.0 syste...
Please, don't do that. The current code is following the ACPI 2.0 specification (and later) quite closely and while we can add a special case for the 1.0-copmpilant systems, acpi_gbl_FADT.header.revision is equal to 3 for ACPI 2.0-compilant systems Thanks, Rafael --
Dec 25, 9:36 am 2007
Rafael J. Wysocki
Re: ACPI: _PTS ordering needs fixing for pre ACPI 3.0 syste...
OK, sorry, the approach is generally reasonable, IMO, but it needs to be a bit more fine grained. I'll try to prepare some patches along these lines soon. Thanks, Rafael --
Dec 25, 10:07 am 2007
Carlos Corbacho
Re: ACPI: _PTS ordering needs fixing for pre ACPI 3.0 syste...
I know, hence this was marked as a hack and not signed off; it's just a Much appreciated - I'm much happier with someone who's more familiar with this code than I working on it. -Carlos (Now going back to unwrapping Christmas presents...) -- E-Mail: carlos@strangeworlds.co.uk Web: strangeworlds.co.uk GPG Key ID: 0x23EE722D --
Dec 25, 9:52 am 2007
Jeff Garzik
Re: 2.6.24-rc6 and earlier: "host bus error" after STR
host bus == PCI So, your PCI bus is crapping itself in a major way. One thing to try might be "libata.noacpi=1" Jeff --
Dec 25, 5:41 am 2007
Pavel Machek
Re: [PATCH 1/38] arch/alpha: Use time_before, time_before_eq...
Maybe you should create new macro so that you don't have to pass the && time_after_now(last_time + 5*HZ) or something? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Dec 25, 8:19 am 2007
Benjamin Herrenschmidt
Re: [RFC/PATCH 4/4] [POWERPC] pci: Disable IO/Mem on a devic...
This is exactly what's supposed to be happening, but the code is buggy and nobody noticed :-) (I'm mixing up IORESOURCE_* flags and No need for 2 calls, just disable whatever type the resource is, but Yes, that's what intended by the above code, if I didn't have mixed up the flags. Ben. --
Dec 25, 5:20 pm 2007
Benjamin Herrenschmidt
Re: [RFC/PATCH 4/4] [POWERPC] pci: Disable IO/Mem on a devic...
Note that this patch isn't in the series Greg queued up anyway. The powerpc specific bits will be going in via Paulus an I already asked him to drop that specific one until I send a fixed version. Cheers, Ben. --
Dec 25, 5:26 pm 2007
Benjamin Herrenschmidt Dec 25, 5:16 pm 2007
Rafael J. Wysocki
Re: [PATCH 0/3] PM: Do not destroy/create devices while susp...
Hm, well. The cleanest thing would be to allow the drivers to remove the device objects on CPU_UP_CANCELED_FROZEN, which means that we weren't able to bring the CPU up during a resume, but still that will deadlock with gregkh-driver-pm-acquire-device-locks-prior-to-suspending.patch. Greetings, Rafael --
Dec 25, 12:21 pm 2007
Rafael J. Wysocki
Re: [PATCH 0/3] PM: Do not destroy/create devices while susp...
Hmm. In principle, device objects may be destroyed on CPU_UP_CANCELED_FROZEN without acquiring the device locks, since in fact we know these objects won't be accessed concurrently at that time (the locks are already held by the PM core, but the PM core is not going to actually access the devices before the subsequent resume). Comments? Thanks, Rafael --
Dec 25, 3:21 pm 2007
Pavel Machek
Re: [PATCH 0/3] PM: Do not destroy/create devices while susp...
That should not happen... but it does in some error cases.... so handling it would be a bonus. Waking up with one cpu out of 8 is bad, but still way better than not waking up at all ;-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Dec 25, 8:33 am 2007
Pavel Machek Dec 25, 8:33 am 2007
Pavel Machek Dec 25, 8:34 am 2007
Pavel Machek Dec 25, 8:34 am 2007
Christoph Hellwig
Re: [PATCH 3/6] udf: convert UDF_SB_ALLOC_PARTMAPS macro to ...
I think __must_check is primarily for public APIs. But if it really helps you here I won't complain. But please don't introduce new overlong lines in entirely new functions. Also the code look rather odd, I'd rather write it as: static int udf_sb_alloc_partition_maps(struct super_block *sb, u32 count) { struct udf_sb_info *sbi = UDF_SB(sb); sbi->s_partmaps = kcalloc(count, sizeof(struct udf_part_map), GFP_KERNEL); if (!sbi->s_partmaps) { udf_error(sb, __FUNCTION__, ...
Dec 25, 7:59 am 2007
Marcin Slusarz
Re: [PATCH 3/6] udf: convert UDF_SB_ALLOC_PARTMAPS macro to ...
Ok, updated batch below: -- - convert UDF_SB_ALLOC_PARTMAPS macro to udf_sb_alloc_partition_maps function - convert kmalloc + memset to kcalloc - check if kcalloc failed (partially) Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> CC: Ben Fennema <bfennema@falcon.csc.calpoly.edu> CC: Jan Kara <jack@suse.cz> CC: Christoph Hellwig <hch@infradead.org> --- fs/udf/super.c | 25 +++++++++++++++++++++++-- fs/udf/udf_sb.h | 13 ------------- 2 files changed, 23 ...
Dec 25, 11:13 am 2007
Christoph Hellwig Dec 25, 12:41 pm 2007
Christoph Hellwig
Re: [PATCH 2/6] udf: remove some ugly macros
Looks generally good, but it would be nice if you could avoid introducing new overly long lines. Then again this really won't be noticed in udf anyway and it looks like you plan to clean it up later anyway. (in case it wasn;'t clear count this as an ack from me) --
Dec 25, 7:54 am 2007
Marcin Slusarz
Re: [PATCH 2/6] udf: remove some ugly macros
Thanks for review! Marcin --
Dec 25, 10:45 am 2007
previous daytodaynext day
December 24, 2007December 25, 2007December 26, 2007