Home » Mailing list archives » linux-kernel » 2007 » December » 25

checkpatch false ERROR: trailing statements should be on next line

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Erez Zadok <ezk@...>
To: <apw@...>, <linux-kernel@...>
Subject: checkpatch false ERROR: trailing statements should be on next line
Date: Tuesday, December 25, 2007 - 5:50 pm

Using v2.6.24-rc6-125-g5356f66, code such as this:

	if (is_file)	/* dirs can be unlinked but chdir'ed to */
		err = -ESTALE;

produces this false checkpatch error:

	foo.c:947: ERROR: trailing statements should be on next line

I think comments such as the above should be allowed (plus a comment isn't a
statement).  It's often very useful to put them right on the affected line.

Thanks,
Erez.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
checkpatch false ERROR: trailing statements should be on nex..., Erez Zadok, (Tue Dec 25, 5:50 pm)
Re: checkpatch false ERROR: trailing statements should be on..., Andy Whitcroft, (Wed Dec 26, 9:02 am)