Home » Mailing list archives » linux-kernel » 2007 » December » 25

Re: [PATCH 2/6] udf: remove some ugly macros

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Christoph Hellwig <hch@...>
To: <marcin.slusarz@...>
Cc: LKML <linux-kernel@...>, Ben Fennema <bfennema@...>, Jan Kara <jack@...>, Christoph Hellwig <hch@...>
Subject: Re: [PATCH 2/6] udf: remove some ugly macros
Date: Tuesday, December 25, 2007 - 7:54 am

Looks generally good, but it would be nice if you could avoid

introducing new overly long lines.  Then again this really won't be

noticed in udf anyway and it looks like you plan to clean it up later

anyway.


(in case it wasn;'t clear count this as an ack from me)


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/6] udf: improve code related to super_block, was: u..., , (Sun Dec 23, 8:10 pm)
[PATCH 6/6] udf: fix sparse warnings (shadowing &amp; mismat..., , (Sun Dec 23, 8:10 pm)
[PATCH 5/6] udf: convert some macros to functions, , (Sun Dec 23, 8:10 pm)
[PATCH 4/6] udf: check if udf_load_logicalvol failed, , (Sun Dec 23, 8:10 pm)
[PATCH 3/6] udf: convert UDF_SB_ALLOC_PARTMAPS macro to udf_..., , (Sun Dec 23, 8:10 pm)
Re: [PATCH 3/6] udf: convert UDF_SB_ALLOC_PARTMAPS macro to ..., Christoph Hellwig, (Tue Dec 25, 7:59 am)
Re: [PATCH 3/6] udf: convert UDF_SB_ALLOC_PARTMAPS macro to ..., Marcin Slusarz, (Tue Dec 25, 11:13 am)
Re: [PATCH 3/6] udf: convert UDF_SB_ALLOC_PARTMAPS macro to ..., Christoph Hellwig, (Tue Dec 25, 12:41 pm)
[PATCH 2/6] udf: remove some ugly macros, , (Sun Dec 23, 8:10 pm)
Re: [PATCH 2/6] udf: remove some ugly macros, Christoph Hellwig, (Tue Dec 25, 7:54 am)
Re: [PATCH 2/6] udf: remove some ugly macros, Marcin Slusarz, (Tue Dec 25, 10:45 am)
[PATCH 1/6] udf: fix coding style of super.c, , (Sun Dec 23, 8:10 pm)