Re: compat_sys_times() bogus until jiffies >= 0.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Friday, December 21, 2007 - 6:41 pm

From: Andi Kleen <andi@firstfloor.org>
Date: Sat, 22 Dec 2007 01:42:02 +0100


Both.  This is not a compat issue.


I'm suggesting that you set the condition codes based upon whether
there is an error or not.  That is the critical thing x86 doesn't do
that all the other platforms do.

x86 relies on interpretation of purely the integer returned from the
system call to userspace, and that means a certain chunk of the return
value space can never represent valid values.

If you use the condition codes to signal "the return value is an
error" you don't have these problems.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
compat_sys_times() bogus until jiffies &gt;= 0., David Brown, (Wed Nov 7, 3:47 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andrew Morton, (Wed Nov 7, 4:28 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andrew Morton, (Wed Nov 7, 5:18 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Wed Nov 7, 5:50 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andreas Schwab, (Wed Nov 7, 5:54 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andrew Morton, (Wed Nov 7, 6:13 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andrew Morton, (Wed Nov 7, 6:17 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Paul Mackerras, (Wed Nov 7, 6:53 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Wed Nov 7, 7:09 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andrew Morton, (Wed Nov 7, 8:07 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Wed Nov 7, 8:13 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Paul Mackerras, (Wed Nov 7, 9:59 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Paul Mackerras, (Wed Nov 7, 10:15 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andrew Morton, (Wed Nov 7, 10:20 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Paul Mackerras, (Wed Nov 7, 10:36 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Brown, (Wed Nov 7, 11:00 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andrew Morton, (Wed Nov 7, 11:12 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Wed Nov 7, 11:22 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Wed Nov 7, 11:24 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Wed Nov 7, 11:25 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andrew Morton, (Thu Nov 8, 12:09 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Thu Nov 8, 12:14 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Paul Mackerras, (Thu Nov 8, 1:53 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andreas Schwab, (Thu Nov 8, 3:20 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Chris Friesen, (Thu Nov 8, 7:42 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Denys Vlasenko, (Thu Nov 8, 12:25 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Denys Vlasenko, (Thu Nov 8, 12:27 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Ulrich Drepper, (Fri Nov 9, 11:20 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Michael Kerrisk, (Thu Dec 20, 4:36 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Thu Dec 20, 4:51 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andi Kleen, (Fri Dec 21, 5:42 pm)
Re: compat_sys_times() bogus until jiffies >= 0., David Miller, (Fri Dec 21, 6:41 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andi Kleen, (Fri Dec 21, 6:49 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andi Kleen, (Fri Dec 21, 6:53 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Fri Dec 21, 9:36 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andi Kleen, (Sat Dec 22, 5:47 am)