Re: Major regression on hackbench with SLUB (more numbers)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Linus Torvalds <torvalds@...>, Pekka Enberg <penberg@...>, Steven Rostedt <rostedt@...>, LKML <linux-kernel@...>, Andrew Morton <akpm@...>, Peter Zijlstra <a.p.zijlstra@...>, Christoph Hellwig <hch@...>, Rafael J. Wysocki <rjw@...>
Date: Friday, December 21, 2007 - 7:54 pm

On Sat, 22 Dec 2007, Ingo Molnar wrote:


Well lets use the version attached to this patch. It turns out that it is 
not important to increase the number of partial slabs. Just putting the 
slab onto the tail of the list does it.
 

He is already the co-maintainer of the slab allocators. See the 
MAINTAINERS file.



SLUB: Improve hackbench speed

Increase the mininum number of partial slabs to keep around and put
partial slabs to the end of the partial queue so that they can add
more objects.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

---
 mm/slub.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c	2007-12-21 14:30:11.096324462 -0800
+++ linux-2.6/mm/slub.c	2007-12-21 15:10:17.611022381 -0800
@@ -1611,12 +1611,12 @@ checks_ok:
 		goto slab_empty;
 
 	/*
-	 * Objects left in the slab. If it
-	 * was not on the partial list before
-	 * then add it.
+	 * Objects left in the slab. If it was not on the partial list before
+	 * then add it. Add it to the end since there is only a single object
+	 * which would make slab_alloc inefficient.
 	 */
 	if (unlikely(!prior))
-		add_partial(get_node(s, page_to_nid(page)), page);
+		add_partial_tail(get_node(s, page_to_nid(page)), page);
 
 out_unlock:
 	slab_unlock(page);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Major regression on hackbench with SLUB, Steven Rostedt, (Fri Dec 7, 1:50 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Thu Dec 13, 6:22 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 14, 12:24 am)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 6:22 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 6:37 pm)
Re: Major regression on hackbench with SLUB (more numbers), Steven Rostedt, (Fri Dec 21, 6:52 pm)
Re: Major regression on hackbench with SLUB (more numbers), Linus Torvalds, (Fri Dec 21, 6:51 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 7:54 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 12:18 pm)
Re: Major regression on hackbench with SLUB (more numbers), Linus Torvalds, (Fri Dec 21, 12:44 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 6:11 pm)
Re: Major regression on hackbench with SLUB (more numbers), Linus Torvalds, (Fri Dec 21, 6:49 pm)
Re: Major regression on hackbench with SLUB (more numbers), Peter Zijlstra, (Fri Dec 21, 6:16 pm)
Re: Major regression on hackbench with SLUB (more numbers), Peter Zijlstra, (Fri Dec 21, 6:17 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 6:27 pm)
Re: Major regression on hackbench with SLUB (more numbers), Linus Torvalds, (Sat Dec 22, 2:01 pm)
Re: Major regression on hackbench with SLUB (more numbers), Linus Torvalds, (Sat Dec 22, 5:00 pm)
Re: Major regression on hackbench with SLUB (more numbers), Steven Rostedt, (Sat Dec 22, 8:59 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Mon Dec 24, 3:21 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Wed Dec 26, 5:31 pm)
Re: Major regression on hackbench with SLUB (more numbers), Steven Rostedt, (Fri Dec 28, 10:52 am)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Thu Dec 27, 1:51 am)
SLUB sysfs support, Christoph Lameter, (Thu Dec 27, 4:28 pm)
Re: SLUB sysfs support, Al Viro, (Thu Dec 27, 6:59 pm)
Re: SLUB sysfs support, Christoph Lameter, (Thu Dec 27, 7:22 pm)
Re: SLUB sysfs support, Al Viro, (Thu Dec 27, 7:54 pm)
Re: SLUB sysfs support, Christoph Lameter, (Thu Dec 27, 7:53 pm)
Re: SLUB sysfs support, Al Viro, (Thu Dec 27, 7:58 pm)
Re: SLUB sysfs support, Christoph Lameter, (Thu Dec 27, 8:02 pm)
Re: SLUB sysfs support, Al Viro, (Thu Dec 27, 8:45 pm)
Re: SLUB sysfs support, Christoph Lameter, (Thu Dec 27, 10:19 pm)
Re: SLUB sysfs support, Al Viro, (Thu Dec 27, 11:26 pm)
Re: SLUB sysfs support, Christoph Lameter, (Wed Jan 2, 4:25 pm)
[patch] slub: provide /proc/slabinfo, Ingo Molnar, (Tue Jan 1, 12:23 pm)
Re: [patch] slub: provide /proc/slabinfo, Arjan van de Ven, (Fri Jan 4, 8:27 pm)
Re: [patch] slub: provide /proc/slabinfo, Linus Torvalds, (Fri Jan 4, 8:49 pm)
Re: Major regression on hackbench with SLUB (more numbers), Jason L Tibbitts III, (Sat Dec 22, 6:52 pm)
Re: Major regression on hackbench with SLUB (more numbers), Alessandro Suardi, (Sun Dec 23, 11:59 pm)
Re: Major regression on hackbench with SLUB (more numbers), Alexey Dobriyan, (Sat Dec 22, 9:01 am)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 7:51 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Mon Dec 24, 3:24 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 12:26 pm)
Re: Major regression on hackbench with SLUB (more numbers), Christoph Lameter, (Fri Dec 21, 5:56 pm)
Re: Major regression on hackbench with SLUB (more numbers), Steven Rostedt, (Fri Dec 14, 2:15 am)
Re: Major regression on hackbench with SLUB, Linus Torvalds, (Fri Dec 7, 1:59 pm)
Re: Major regression on hackbench with SLUB, Linus Torvalds, (Fri Dec 7, 2:36 pm)
Re: Major regression on hackbench with SLUB, Christoph Lameter, (Thu Dec 13, 6:11 pm)
Re: Major regression on hackbench with SLUB, Steven Rostedt, (Sat Dec 8, 8:28 pm)
Re: Major regression on hackbench with SLUB, Steven Rostedt, (Sat Dec 8, 6:16 pm)
Re: Major regression on hackbench with SLUB, Björn, (Mon Dec 10, 3:38 am)
Re: Major regression on hackbench with SLUB, Steven Rostedt, (Mon Dec 10, 10:00 am)
Re: Major regression on hackbench with SLUB, Steven Rostedt, (Fri Dec 7, 2:58 pm)
Re: Major regression on hackbench with SLUB, Ingo Molnar, (Fri Dec 7, 1:55 pm)