Re: [PATCH 0/4] add task handling notifier

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jan Beulich <jbeulich@...>
Cc: <linux-kernel@...>
Date: Thursday, December 20, 2007 - 6:25 pm

Hi Jan,

I like and support your idea!

On Thursday 20 December 2007, Jan Beulich wrote:

Yes, but why export variables? Wouldn't it be better to export 
an API? 

That simplifies the callers (they all pass "current" as task 
and "task_notifier_list" as arguments).

It also prevents exposing internal variables (notifier lists 
ARE internal variables) to modules.

What do you think?


Best Regards

Ingo Oeser
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/4] add task handling notifier, Jan Beulich, (Thu Dec 20, 9:11 am)
Re: [PATCH 0/4] add task handling notifier, Christoph Hellwig, (Sun Dec 23, 8:26 am)
Re: [PATCH 0/4] add task handling notifier, Matt Helsley, (Tue Jan 8, 10:24 pm)
Re: [PATCH 0/4] add task handling notifier, Matthew Helsley, (Tue Jan 8, 11:27 pm)
Re: [PATCH 0/4] add task handling notifier, Andrew Morton, (Tue Dec 25, 6:05 pm)
Re: [PATCH 0/4] add task handling notifier, Jan Beulich, (Tue Jan 8, 9:38 am)
Re: [PATCH 0/4] add task handling notifier, Andrew Morton, (Tue Jan 8, 6:14 pm)
Re: [PATCH 0/4] add task handling notifier, Jan Beulich, (Wed Jan 9, 5:52 am)
Re: [PATCH 0/4] add task handling notifier, Christoph Hellwig, (Wed Jan 9, 6:03 am)
Re: [PATCH 0/4] add task handling notifier, Matt Helsley, (Tue Jan 8, 10:47 pm)
Re: [PATCH 0/4] add task handling notifier, Andrew Morton, (Tue Jan 8, 11:22 pm)
Re: [PATCH 0/4] add task handling notifier, Paul Jackson, (Tue Jan 8, 8:03 pm)
Re: [PATCH 0/4] add task handling notifier, Andrew Morton, (Tue Jan 8, 8:31 pm)
Re: [PATCH 0/4] add task handling notifier, Ingo Oeser, (Thu Dec 20, 6:25 pm)
Re: [PATCH 0/4] add task handling notifier, Jan Beulich, (Fri Dec 21, 3:36 am)