Re: [RESEND] [PATCH] RTC: assure proper memory ordering with respect to RTC_DEV_BUSY flag (was Re: RTC: convert mutex to bitfield)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Alessandro Zummo

Subject: Re: [RESEND] [PATCH] RTC: assure proper memory ordering with respect to RTC_DEV_BUSY flag (was Re: RTC: convert mutex to bitfield)

Date: Sunday, December 2, 2007 - 3:13 pm

On Sun, 2 Dec 2007 23:00:04 +0100 (CET)
Jiri Kosina <jkosina@suse.cz> wrote:

quoted text> [ nobody seems to have picked this up, resending. This is a fix for 
>   commit 8853c202b4 in Linus' tree ]
> 
> From: Jiri Kosina <jkosina@suse.cz>
> 
> RTC: assure proper memory ordering with respect to RTC_DEV_BUSY flag
> 
> We must make sure that the RTC_DEV_BUSY flag has proper lock semantics, 
> i.e. that the RTC_DEV_BUSY stores clearing the flag don't get reordered 
> before the preceeding stores and loads and vice versa.
> 
> Spotted by Nick Piggin.
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>

 missed it, sorry.

 
 Acked-by: Alessandro Zummo <a.zummo@towertech.it>

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[RESEND] [PATCH] RTC: assure proper memory ordering with r ..., Jiri Kosina, (Sun Dec 2, 3:00 pm)

Re: [RESEND] [PATCH] RTC: assure proper memory ordering wi ..., Alessandro Zummo, (Sun Dec 2, 3:13 pm)


linux-kernel:
Christoph Lameter	[PATCH 1/2] Make page->private usable in compound pages V1
Luben Tuikov	Re: Integration of SCST in the mainstream Linux kernel
Alexey Dobriyan	Re: [2.6.22.2 review 09/84] Fix rfkill IRQ flags.
Michal Nazarewicz	Re: [PATCH] USB: Gadget: g_multi: added INF file for gadget with multiple configur...
Jesse Barnes	Re: PCI probing changes
git:
Jakub Narebski	Re: GSoC 2008 - Mentors Wanted!
Jan Harkes	Re: git-svn and huge data and modifying the git-svn-HEAD branch directly
Andy Parkins	git-fetch fails with error code 128
Marcus Griep	Re: [PATCH 1/3] Git.pm: Add faculties to allow temp files to be cached
Junio C Hamano	Re: [JGIT PATCH 2/2] Decrease the fetch pack client buffer to the lower minimum
git-commits-head:
Linux Kernel Mailing List	ARM: 5970/1: nomadik-gpio: fix spinlock usage
Linux Kernel Mailing List	sh-sci: update receive error handling for muxed irqs
Linux Kernel Mailing List	No need to do lock_super() for exclusion in generic_shutdown_super()
Linux Kernel Mailing List	x86, msr: Export the register-setting MSR functions via /dev/*/msr
Linux Kernel Mailing List	Input: gpio-keys - add support for disabling gpios through sysfs
linux-netdev:
Eric Dumazet	[PATCH] net: ALIGN/PTR_ALIGN cleanup in alloc_netdev_mq()/netdev_priv()
Patrick McHardy	[NET_SCHED]: sch_ingress: remove netfilter support
Rose, Gregory V	RE: __bad_udelay in network driver breaks build
Patrick McHardy	Re: no reassembly for outgoing packets on RAW socket
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc:
ropers	Re: Real men don't attack straw men
elitdostlar	Seks partneri arayan bayanlar bu adreste - 8878xs706x6438
Marcus Andree	Re: This is what Linus Torvalds calls openBSD crowd
Lars D. Noodén	Re: sshd.config and AllowUsers
Henning Brauer	Re: Sun Blade 1000?