Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG is off

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Herbert Xu <herbert@...>

Cc: Benjamin Herrenschmidt <benh@...>, Andrew Morton <akpm@...>, Linux Kernel Mailing List <linux-kernel@...>

Subject: Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG is off

Date: Saturday, December 15, 2007 - 2:12 pm

On Sat, Dec 15, 2007 at 02:34:42PM +0800, Herbert Xu wrote:
quoted text> On Sat, Dec 15, 2007 at 05:31:30PM +1100, Benjamin Herrenschmidt wrote:
> >
> > That's something I've actually never quite liked... the fact that we
> > evaluate the expression anyway. I'm pretty happy with -not- evaluating
> > the expression when CONFIG_BUG is on most of the time since whatever is
> > in there is purely here for the sake of the BUG/WARN test.
> 
> Whether we evaluate the expression is a completely different debate.
> I personally agree with you that expressions that have side-effects
> are a stupid idea for either WARN_ON or BUG_ON.

As do I. But we can't really do anything about it short of auditing
them all.

-- 
Mathematics is the supreme nostalgia of our time.
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG is ..., Herbert Xu, (Fri Dec 14, 9:27 am)

Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG..., Benjamin Herrenschmidt, (Sat Dec 15, 2:31 am)

Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG..., Herbert Xu, (Sat Dec 15, 2:34 am)

Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG..., Matt Mackall, (Sat Dec 15, 2:12 pm)

Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG..., Matt Mackall, (Fri Dec 14, 2:02 pm)

Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG..., Benjamin Herrenschmidt, (Sat Dec 15, 2:22 am)

Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG..., Herbert Xu, (Sat Dec 15, 12:16 am)

Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG..., Matt Mackall, (Sat Dec 15, 1:52 am)

Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG..., Dave Jones, (Sat Dec 15, 2:45 am)


linux-kernel:
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Mike Travis	[RFC 00/15] x86_64: Optimize percpu accesses
Dave Jones	agp / cpufreq.
linux-netdev:
Willy Tarreau	Re: [PATCH] tcp: splice as many packets as possible at once
Gerrit Renker	[PATCH 14/37] dccp: Tidy up setsockopt calls
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Natalie Protasevich	[BUG] New Kernel Bugs
git:

openbsd-misc: