[Empty message]

Introduces some temporary ifdefs and changes some cosmetic differences. Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- arch/x86/kernel/kprobes_32.c | 48 +++++++++++++++++++++++++++-------------- arch/x86/kernel/kprobes_64.c | 34 ++++++++++++++++++++++------- 2 files changed, 57 insertions(+), 25 deletions(-) diff --git a/arch/x86/kernel/kprobes_32.c b/arch/x86/kernel/kprobes_32.c index f4ba584..2a8acd6 100644 --- a/arch/x86/kernel/kprobes_32.c +++ b/arch/x86/kernel/...

Add X86_32 only static function to X86_64 file and add static X86_64 functions to X86_32 file. Produces compile warnings about defined but not used functions for now, will deal with these in final unified file. Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- arch/x86/kernel/kprobes_32.c | 85 ++++++++++++++++++++++++++++++++++++++++- arch/x86/kernel/kprobes_64.c | 61 ++++++++++++++++++++++++++++++ 2 files changed, 143 insertions(+), 3 deletions(-) diff --git a/arch/x...

Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/ax88796.c | 12 ++++-------- 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c index 7495a9e..107c11f 100644 --- a/drivers/net/ax88796.c +++ b/drivers/net/ax88796.c @@ -750,14 +750,10 @@ static int ax_init_dev(struct net_device *dev, int first_init) ax_NS8390_init(dev, 0); if (first_init) { - printk("AX88796: %dbit, irq %d, %lx, MAC: ", - ei_status.w...

Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/mac8390.c | 18 ++++++------------ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/mac8390.c b/drivers/net/mac8390.c index 9e70074..4eccebb 100644 --- a/drivers/net/mac8390.c +++ b/drivers/net/mac8390.c @@ -483,6 +483,7 @@ void cleanup_module(void) static int __init mac8390_initdev(struct net_device * dev, struct nubus_dev * ndev, enum mac8390_type type) { + DECLARE_MAC_BUF(mac); sta...

Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/niu.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/niu.c b/drivers/net/niu.c index abfc61c..8a0f8f8 100644 --- a/drivers/net/niu.c +++ b/drivers/net/niu.c @@ -7392,12 +7392,10 @@ static void __devinit niu_assign_netdev_ops(struct net_device *dev) static void __devinit niu_device_announce(struct niu *np) { struct net_device *dev = np->dev; - int i; + DECLARE_MAC_BUF(mac); ...

Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/smc911x.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index 76cc1d3..f503b73 100644 --- a/drivers/net/smc911x.c +++ b/drivers/net/smc911x.c @@ -2086,10 +2086,9 @@ static int __init smc911x_probe(struct net_device *dev, unsigned long ioaddr) "set using ifconfig\n", dev->name); } else { /* Print the Ethernet address */ - printk("%...

Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/tg3.c | 13 ++++++------- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 4942f7d..eea7da9 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -12351,9 +12351,10 @@ static int __devinit tg3_init_one(struct pci_dev *pdev, unsigned long tg3reg_base, tg3reg_len; struct net_device *dev; struct tg3 *tp; - int i, err, pm_cap; + int err, pm_cap; char str[40...

Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/usb/catc.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/usb/catc.c b/drivers/net/usb/catc.c index 76752d8..e20db50 100644 --- a/drivers/net/usb/catc.c +++ b/drivers/net/usb/catc.c @@ -757,6 +757,7 @@ static int catc_probe(struct usb_interface *intf, const struct usb_device_id *id struct catc *catc; u8 broadcast[6]; int i, pktsz; + DECLARE_MAC_BUF(mac); if (usb_set_int...

Patch 2 of 3 This patch modifies our /proc entries to display information about only the first logical volume on each controller. Primary reason is for hardware that can support many LUNs (128 or more). In this case we can step on memory and crash the system trying to display so much information. Users will have to find information about other LUNs in /sys/block rather than /proc/drivers. Also took the liberty of making some formatting changes to eliminate a bunch of white spaces while I was in tha...

Put a copy of instructions tables in both files to reduce the diff size and drastically cut checkpatch warnings. Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- arch/x86/kernel/kprobes_32.c | 140 ++++++++++++++++++++++++++++--------- arch/x86/kernel/kprobes_64.c | 158 ++++++++++++++++++++++++++++-------------- 2 files changed, 214 insertions(+), 84 deletions(-) diff --git a/arch/x86/kernel/kprobes_32.c b/arch/x86/kernel/kprobes_32.c index 615f24a..3e45b51 100644 --- a/...

Sorry Andrew, I don't know who to forward this problem to. I tried running: find /proc | xargs cat and got this: ================================= [ INFO: inconsistent lock state ] 2.6.24-rc5-mm1 #26 --------------------------------- inconsistent {in-softirq-W} -> {softirq-on-R} usage. cat/6944 [HC0[0]:SC0[0]:HE1:SE1] takes: BUG: unable to handle kernel paging request at virtual address 0f1eff0b printing ip: c01fe64d *pde = 00000000 Oops: 0000 [#1] PREEMPT SMP last sysfs file: /sys/block...

Whoops. I forgot to include my current .config file. Here it is: # # Automatically generated make config: don't edit # Linux kernel version: 2.6.24-rc5-mm1 # Fri Dec 14 16:26:01 2007 # # CONFIG_64BIT is not set CONFIG_X86_32=y # CONFIG_X86_64 is not set CONFIG_X86=y CONFIG_GENERIC_TIME=y CONFIG_GENERIC_CMOS_UPDATE=y CONFIG_CLOCKSOURCE_WATCHDOG=y CONFIG_GENERIC_CLOCKEVENTS=y CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y CONFIG_LOCKDEP_SUPPORT=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_SEMAPHORE_SLE...

Dears, I've got a double dual xeon wich sometimes is getting too slow. While i was observing one of these slowly times, I realized the time wait of processors come close to 100% and nfsd and kjournald process become to D status (uniterruptible sleep) .Does someone know why this can be happening or how can I troubleshoot it? Below is a 'draw' of my top at one of these moments. [root@cromo src]# top top - 10:59:02 up 6 days, 19:30, 17 users, load average: 14.77, 13.46, 13.00 Tasks: 189 total,...

The combination of capturing data from other users, plus seeding the pool with your own data, just might be powerful enough to help steal secrets, sometime in the next five years, from data that is Matt is correct. The rolled-up result follows. Signed off by: jreiser@BitWagon.com --- ./drivers/char/random.c.orig 2007-12-14 11:06:03.000000000 -0800 +++ ./drivers/char/random.c 2007-12-14 12:27:23.000000000 -0800 @@ -708,6 +708,8 @@ bytes=extract_entropy(r->pull, tmp, bytes, ...

I am not inclined to apply this one. This practice, applied over time, will tend to accumulate weird 'default' and 'select' statements. So I think the breakage that occurs is mitigated by two factors: 1) kernel hackers that do their own configs are expected to be able to figure this stuff. 2) kernel builders (read: distros, mainly) are expected to have put thought into the Kconfig selection and driver migration strategies. PCI IDs move across drivers from time, and we don't want to apply th...

You miss the vast majority of kconfig users: 3) system administrators etc. who for different reasons compile their own kernels but neither are nor want to be kernel developers There's a reason why e.g. LPI requires you to be able to compile your own kernel even for getting a "Junior Level Linux Professional" certificate. Or that one of the authors of "Linux Device drivers" has written a book cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out ...

Thanks to both of you for shedding some light on this matter. I'll look into HPET-related efforts; it looks like a better solution than my patch. --

> Well, that would interfere with the acpi-idle code. The original use cases were: - Accounting for idle time with stopped counters in oprofile and eliminate the need for idle=poll. That never was implemented unfortunately but would be still a worthy feature I think. - Perfmon for similar uses. - noidletick -- my original noidletick implementation used the idle notifiers similar to the s390 implementation. Obsolete now. Right now it is used for the machine check early notification, but I...

diff --git a/Makefile b/Makefile index 873c786..a8bdcc6 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 22 -EXTRAVERSION = .14 +EXTRAVERSION = .15 NAME = Holy Dancing Manatees, Batman! # *DOCUMENTATION* diff --git a/crypto/algapi.c b/crypto/algapi.c index f137a43..ec286a2 100644 --- a/crypto/algapi.c +++ b/crypto/algapi.c @@ -98,6 +98,9 @@ static void crypto_remove_spawn(struct crypto_spawn *spawn, return; inst->alg.cra_flags |=...

[...] Yep. I posted a similar patch with a couple more tweaks after a month ago after Andrew's comments, which hasn't yet moved from -mm to Linus' tree. See http://lkml.org/lkml/2007/11/16/336 sln -- ====================================================================== Mr. Shannon Nelson LAN Access Division, Intel Corp. Shannon.Nelson@intel.com I don't speak for Intel (503) 712-7659 Parents can't afford to be squeamish. --

xfer_secondary_pool() in drivers/char/random.c tells add_entropy_words() to use uninitialized tmp[] whenever bytes is not a multiple of 4. Besides being unfriendly to automated dynamic checkers, this is a potential leak of user data into the output stream. When called from extract_entropy_user, then uninit tmp[] can capture leftover data from a previous copy_from_user(). Signed off by: jreiser@BitWagon.com --- ./drivers/char/random.c.orig 2007-12-14 11:06:03.000000000 -0800 +++ ./drivers/char/r...

Hi Peter, sysctl_intvec_fragment, proc_dointvec_fragment, sysctl_intvec_fragment seem to suffer from cut-n-pastitis. Regards, Daniel --

Introduce sk_allocation(), this function allows to inject sock specific flags to each sock related allocation. Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> --- include/net/sock.h | 5 +++++ net/ipv4/tcp.c | 2 +- net/ipv4/tcp_output.c | 11 ++++++----- net/ipv6/tcp_ipv6.c | 14 +++++++++----- 4 files changed, 21 insertions(+), 11 deletions(-) Index: linux-2.6/net/ipv4/tcp_output.c =================================================================== --- li...

Wrap calling sk->sk_backlog_rcv() in a function. This will allow extending the generic sk_backlog_rcv behaviour. Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> --- include/net/sock.h | 5 +++++ net/core/sock.c | 4 ++-- net/ipv4/tcp.c | 2 +- net/ipv4/tcp_timer.c | 2 +- 4 files changed, 9 insertions(+), 4 deletions(-) Index: linux-2.6/include/net/sock.h =================================================================== --- linux-2.6.orig/include/ne...