Home » Mailing list archives » linux-kernel » 2007 » December » 14

[PATCH 04/11] drivers/net/mac89x0.c: Use print_mac

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Joe Perches <joe@...>
To: <linux-kernel@...>
Cc: Jeff Garzik <jgarzik@...>, <netdev@...>
Subject: [PATCH 04/11] drivers/net/mac89x0.c: Use print_mac
Date: Friday, December 14, 2007 - 6:34 pm

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/mac89x0.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/mac89x0.c b/drivers/net/mac89x0.c
index a19b595..45b56ca 100644
--- a/drivers/net/mac89x0.c
+++ b/drivers/net/mac89x0.c
@@ -584,11 +584,12 @@ static void set_multicast_list(struct net_device *dev)
 
 static int set_mac_address(struct net_device *dev, void *addr)
 {
+	DECLARE_MAC_BUF(mac);
 	int i;
-	printk("%s: Setting MAC address to ", dev->name);
 	for (i = 0; i < 6; i++)
-		printk(" %2.2x", dev->dev_addr[i] = ((unsigned char *)addr)[i]);
-	printk(".\n");
+		dev->dev_addr[i] = ((unsigned char *)addr)[i];
+	printk(KERN_INFO "%s: Setting MAC address to %s\n",
+	       dev->name, print_mac(mac, dev->dev_addr));
 	/* set the Ethernet address */
 	for (i=0; i < ETH_ALEN/2; i++)
 		writereg(dev, PP_IA+i*2, dev->dev_addr[i*2] | (dev->dev_addr[i*2+1] << 8));
-- 
1.5.3.7.949.g2221a6

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 01/11] drivers/net/ax88796.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
[PATCH 02/11] drivers/net/hplance.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
[PATCH 03/11] drivers/net/mac8390.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
[PATCH 04/11] drivers/net/mac89x0.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
[PATCH 05/11] drivers/net/niu.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
Re: [PATCH 05/11] drivers/net/niu.c: Use print_mac, David Miller, (Thu Dec 20, 8:07 am)
[PATCH 06/11] drivers/net/pcnet32.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
[PATCH 07/11] drivers/net/smc911x.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
[PATCH 08/11] drivers/net/sunvnet.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
Re: [PATCH 08/11] drivers/net/sunvnet.c: Use print_mac, David Miller, (Thu Dec 20, 8:06 am)
[PATCH 09/11] drivers/net/tg3.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
Re: [PATCH 09/11] drivers/net/tg3.c: Use print_mac, David Miller, (Thu Dec 20, 8:07 am)
[PATCH 10/11] drivers/net/tulip/de4x5.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
[PATCH 11/11] drivers/net/usb/catc.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)