Home » Mailing list archives » linux-kernel » 2007 » December » 14

[PATCH 09/11] drivers/net/tg3.c: Use print_mac

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Joe Perches <joe@...>
To: <linux-kernel@...>
Cc: Jeff Garzik <jgarzik@...>, Michael Chan <mchan@...>, <netdev@...>
Subject: [PATCH 09/11] drivers/net/tg3.c: Use print_mac
Date: Friday, December 14, 2007 - 6:34 pm

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/tg3.c |   13 ++++++-------
 1 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 4942f7d..eea7da9 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -12351,9 +12351,10 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
 	unsigned long tg3reg_base, tg3reg_len;
 	struct net_device *dev;
 	struct tg3 *tp;
-	int i, err, pm_cap;
+	int err, pm_cap;
 	char str[40];
 	u64 dma_mask, persist_dma_mask;
+	DECLARE_MAC_BUF(mac);
 
 	if (tg3_version_printed++ == 0)
 		printk(KERN_INFO "%s", version);
@@ -12632,7 +12633,8 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
 		goto err_out_apeunmap;
 	}
 
-	printk(KERN_INFO "%s: Tigon3 [partno(%s) rev %04x PHY(%s)] (%s) %s Ethernet ",
+	printk(KERN_INFO "%s: Tigon3 [partno(%s) rev %04x PHY(%s)] "
+	       "(%s) %s Ethernet %s\n",
 	       dev->name,
 	       tp->board_part_number,
 	       tp->pci_chip_rev_id,
@@ -12640,11 +12642,8 @@ static int __devinit tg3_init_one(struct pci_dev *pdev,
 	       tg3_bus_string(tp, str),
 	       ((tp->tg3_flags & TG3_FLAG_10_100_ONLY) ? "10/100Base-TX" :
 		((tp->tg3_flags2 & TG3_FLG2_ANY_SERDES) ? "1000Base-SX" :
-		 "10/100/1000Base-T")));
-
-	for (i = 0; i < 6; i++)
-		printk("%2.2x%c", dev->dev_addr[i],
-		       i == 5 ? '\n' : ':');
+		 "10/100/1000Base-T")),
+	       print_mac(mac, dev->dev_addr));
 
 	printk(KERN_INFO "%s: RXcsums[%d] LinkChgREG[%d] "
 	       "MIirq[%d] ASF[%d] WireSpeed[%d] TSOcap[%d]\n",
-- 
1.5.3.7.949.g2221a6

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 01/11] drivers/net/ax88796.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
[PATCH 02/11] drivers/net/hplance.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
[PATCH 03/11] drivers/net/mac8390.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
[PATCH 04/11] drivers/net/mac89x0.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
[PATCH 05/11] drivers/net/niu.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
Re: [PATCH 05/11] drivers/net/niu.c: Use print_mac, David Miller, (Thu Dec 20, 8:07 am)
[PATCH 06/11] drivers/net/pcnet32.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
[PATCH 07/11] drivers/net/smc911x.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
[PATCH 08/11] drivers/net/sunvnet.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
Re: [PATCH 08/11] drivers/net/sunvnet.c: Use print_mac, David Miller, (Thu Dec 20, 8:06 am)
[PATCH 09/11] drivers/net/tg3.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
Re: [PATCH 09/11] drivers/net/tg3.c: Use print_mac, David Miller, (Thu Dec 20, 8:07 am)
[PATCH 10/11] drivers/net/tulip/de4x5.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)
[PATCH 11/11] drivers/net/usb/catc.c: Use print_mac, Joe Perches, (Fri Dec 14, 6:34 pm)