[PATCH 16/19] modify get_desc_base

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Glauber de Oliveira Costa
Date: Thursday, December 13, 2007 - 6:58 am

This patch makes get_desc_base() receive a struct desc_struct,
and then uses its internal fields to compute the base address.
This is done at both i386 and x86_64, and then it is moved
to common header

Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>
---
 arch/x86/kernel/tls.c  |    2 +-
 arch/x86/mm/fault_32.c |    2 +-
 include/asm-x86/desc.h |    8 ++------
 3 files changed, 4 insertions(+), 8 deletions(-)

Index: linux-2.6-x86/arch/x86/kernel/tls.c
===================================================================
--- linux-2.6-x86.orig/arch/x86/kernel/tls.c
+++ linux-2.6-x86/arch/x86/kernel/tls.c
@@ -112,7 +112,7 @@ int do_get_thread_area(struct task_struc
 
 	memset(&info, 0, sizeof(struct user_desc));
 	info.entry_number = idx;
-	info.base_addr = get_desc_base((void *)desc);
+	info.base_addr = get_desc_base((struct desc_struct *)desc);
 	info.limit = GET_LIMIT(desc);
 	info.seg_32bit = GET_32BIT(desc);
 	info.contents = GET_CONTENTS(desc);
Index: linux-2.6-x86/arch/x86/mm/fault_32.c
===================================================================
--- linux-2.6-x86.orig/arch/x86/mm/fault_32.c
+++ linux-2.6-x86/arch/x86/mm/fault_32.c
@@ -115,7 +115,7 @@ static inline unsigned long get_segment_
 	}
 
 	/* Decode the code segment base from the descriptor */
-	base = get_desc_base((unsigned long *)desc);
+	base = get_desc_base((struct desc_struct *)desc);
 
 	if (seg & (1<<2)) { 
 		mutex_unlock(&current->mm->context.lock);
Index: linux-2.6-x86/include/asm-x86/desc.h
===================================================================
--- linux-2.6-x86.orig/include/asm-x86/desc.h
+++ linux-2.6-x86/include/asm-x86/desc.h
@@ -69,6 +69,11 @@ static inline void load_LDT(mm_context_t
 	preempt_enable();
 }
 
+static inline unsigned long get_desc_base(struct desc_struct *desc)
+{
+	return desc->base0 | ((desc->base1) << 16) | ((desc->base2) << 24);
+}
+
 #else
 /*
  * GET_DESC_BASE reads the descriptor base of the specified segment.
Index: linux-2.6-x86/include/asm-x86/desc_32.h
===================================================================
--- linux-2.6-x86.orig/include/asm-x86/desc_32.h
+++ linux-2.6-x86/include/asm-x86/desc_32.h
@@ -168,14 +168,6 @@ static inline void __set_tss_desc(unsign
 
 #define set_tss_desc(cpu,addr) __set_tss_desc(cpu, GDT_ENTRY_TSS, addr)
 
-static inline unsigned long get_desc_base(unsigned long *desc)
-{
-	unsigned long base;
-	base = ((desc[0] >> 16)  & 0x0000ffff) |
-		((desc[1] << 16) & 0x00ff0000) |
-		(desc[1] & 0xff000000);
-	return base;
-}
 #endif /* !__ASSEMBLY__ */
 
 #endif
Index: linux-2.6-x86/include/asm-x86/desc_64.h
===================================================================
--- linux-2.6-x86.orig/include/asm-x86/desc_64.h
+++ linux-2.6-x86/include/asm-x86/desc_64.h
@@ -156,15 +156,6 @@ static inline void load_TLS(struct threa
 		gdt[i] = t->tls_array[i];
 }
 
-static inline unsigned long get_desc_base(const void *ptr)
-{
-	const u32 *desc = ptr;
-	unsigned long base;
-	base = ((desc[0] >> 16)  & 0x0000ffff) |
-		((desc[1] << 16) & 0x00ff0000) |
-		(desc[1] & 0xff000000);
-	return base;
-}
 #endif /* !__ASSEMBLY__ */
 
 #endif
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/19] desc_struct integration, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 1/19] unify desc_struct, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 2/19] unify struct desc_ptr, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 4/19] removed unused variable, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 5/19] introduce gate_desc type., Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 6/19] change write_idt_entry signature, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 7/19] introduce ldt_desc type., Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 8/19] modify write_ldt function, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 9/19] introduce fill_ldt, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 10/19] change write_gdt_entry signature., Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 11/19] change write_ldt_entry signature, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 12/19] move constants to desc_defs.h, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 14/19] use the same data type for tls_array., Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 15/19] modify get_desc_base, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 16/19] provide tss_desc, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 17/19] unify paravirt pieces of descriptor handling, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 18/19] move _set_gate and its users to a common loc ..., Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 19/19] unify set_tss_desc, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
Re: [PATCH 1/19] unify desc_struct, Jeremy Fitzhardinge, (Thu Dec 6, 12:24 pm)
Re: [PATCH 1/19] unify desc_struct, Glauber de Oliveira ..., (Thu Dec 6, 12:37 pm)
Re: [PATCH 1/19] unify desc_struct, Glauber de Oliveira ..., (Thu Dec 6, 2:20 pm)
Re: [PATCH 1/19] unify desc_struct, Jeremy Fitzhardinge, (Thu Dec 6, 3:03 pm)
[PATCH 0/19] desc_struct integration, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 01/19] unify desc_struct, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 02/19] unify struct desc_ptr, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 03/19] change gdt acessor macro name, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 04/19] removed unused variable, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 05/19] introduce gate_desc type., Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 07/19] introduce ldt_desc type., Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 08/19] modify write_ldt function, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 09/19] introduce fill_ldt, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 10/19] provide tss_desc, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 11/19] change write_gdt_entry signature., Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 12/19] change write_ldt_entry signature, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 13/19] move constants to desc_defs.h, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 14/19] unify non-paravirt parts of desc.h, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 15/19] use the same data type for tls_array., Glauber de Oliveira ..., (Wed Dec 12, 5:54 am)
[PATCH 16/19] modify get_desc_base, Glauber de Oliveira ..., (Wed Dec 12, 5:54 am)
[PATCH 17/19] unify paravirt pieces of descriptor handling, Glauber de Oliveira ..., (Wed Dec 12, 5:54 am)
[PATCH 18/19] move _set_gate and its users to a common loc ..., Glauber de Oliveira ..., (Wed Dec 12, 5:54 am)
[PATCH 19/19] unify set_tss_desc, Glauber de Oliveira ..., (Wed Dec 12, 5:54 am)
Re: [PATCH 0/19] desc_struct integration, Ingo Molnar, (Wed Dec 12, 10:20 am)
Re: [PATCH 09/19] introduce fill_ldt, Ingo Molnar, (Wed Dec 12, 10:56 am)
Re: [PATCH 0/19] desc_struct integration, Ingo Molnar, (Wed Dec 12, 11:11 am)
Re: [PATCH 0/19] desc_struct integration, Ingo Molnar, (Wed Dec 12, 11:20 am)
Re: [PATCH 0/19] desc_struct integration, Glauber de Oliveira ..., (Wed Dec 12, 11:27 am)
Re: [PATCH 0/19] desc_struct integration, Ingo Molnar, (Wed Dec 12, 11:33 am)
Re: [PATCH 0/19] desc_struct integration, Ingo Molnar, (Wed Dec 12, 11:34 am)
Re: [PATCH 0/19] desc_struct integration, Glauber de Oliveira ..., (Wed Dec 12, 12:05 pm)
Re: [PATCH 0/19] desc_struct integration, H. Peter Anvin, (Wed Dec 12, 4:39 pm)
[PATCH 0/19 - v3] desc_struct integration, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 02/19] unify struct desc_ptr, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 03/19] change gdt acessor macro name, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 04/19] removed unused variable, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 05/19] introduce gate_desc type., Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 06/19] change write_idt_entry signature, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 07/19] introduce ldt_desc type., Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 08/19] modify write_ldt function, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 09/19] introduce fill_ldt, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 10/19] provide tss_desc, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 11/19] change write_gdt_entry signature., Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 12/19] change write_ldt_entry signature, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 13/19] move constants to desc_defs.h, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 15/19] use the same data type for tls_array., Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 16/19] modify get_desc_base, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 17/19] unify paravirt pieces of descriptor handling, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 18/19] move _set_gate and its users to a common loc ..., Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 19/19] unify set_tss_desc, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
Re: [PATCH 19/19] unify set_tss_desc, Andi Kleen, (Thu Dec 13, 5:46 am)
[PATCH 0/19 -v4] desc_struct integration, Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 01/19] unify desc_struct, Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 02/19] unify struct desc_ptr, Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 03/19] change gdt acessor macro name, Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 04/19] removed unused variable, Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 05/19] introduce gate_desc type., Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 06/19] change write_idt_entry signature, Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 07/19] introduce ldt_desc type., Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 09/19] introduce fill_ldt, Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 10/19] provide tss_desc, Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 11/19] change write_gdt_entry signature., Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 12/19] change write_ldt_entry signature, Glauber de Oliveira ..., (Thu Dec 13, 6:58 am)
[PATCH 13/19] move constants to desc_defs.h, Glauber de Oliveira ..., (Thu Dec 13, 6:58 am)
[PATCH 14/19] unify non-paravirt parts of desc.h, Glauber de Oliveira ..., (Thu Dec 13, 6:58 am)
[PATCH 15/19] use the same data type for tls_array., Glauber de Oliveira ..., (Thu Dec 13, 6:58 am)
[PATCH 16/19] modify get_desc_base, Glauber de Oliveira ..., (Thu Dec 13, 6:58 am)
[PATCH 17/19] unify paravirt pieces of descriptor handling, Glauber de Oliveira ..., (Thu Dec 13, 6:58 am)
[PATCH 18/19] move _set_gate and its users to a common loc ..., Glauber de Oliveira ..., (Thu Dec 13, 6:58 am)
[PATCH 19/19] unify set_tss_desc, Glauber de Oliveira ..., (Thu Dec 13, 6:58 am)
Re: [PATCH 19/19] unify set_tss_desc, Glauber de Oliveira ..., (Thu Dec 13, 7:50 am)
Re: [PATCH 0/19 -v4] desc_struct integration, Ingo Molnar, (Thu Dec 13, 9:47 am)
Re: [PATCH 0/19 -v4] desc_struct integration, Glauber de Oliveira ..., (Thu Dec 13, 10:06 am)