[PATCH 19/19] unify set_tss_desc

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Glauber de Oliveira Costa
Date: Wednesday, December 12, 2007 - 7:01 pm

This patch unifies the set_tss_desc between i386 and x86_64,
which can now have a common implementation. After the old
functions are removed from desc_{32,64}.h, nothing important is
left, and the files can be removed.

Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>
---
 include/asm-x86/desc.h    |   40 +++++++++++++++++++++++++++++++++-------
 include/asm-x86/desc_32.h |   27 ---------------------------
 include/asm-x86/desc_64.h |   34 ----------------------------------
 3 files changed, 33 insertions(+), 68 deletions(-)
 delete mode 100644 include/asm-x86/desc_32.h
 delete mode 100644 include/asm-x86/desc_64.h

Index: linux-2.6-x86/include/asm-x86/desc.h
===================================================================
--- linux-2.6-x86.orig/include/asm-x86/desc.h
+++ linux-2.6-x86/include/asm-x86/desc.h
@@ -165,6 +165,39 @@ static inline void pack_ldt(ldt_desc *ld
 #endif
 }
 
+static inline void pack_tss(tss_desc *tss, unsigned long addr,
+			   unsigned size, unsigned entry)
+{
+#ifdef CONFIG_X86_64
+		set_tssldt_descriptor(tss,
+			     addr, entry, size);
+#else
+		pack_descriptor(tss, (unsigned long)addr,
+				size,
+				0x80 | entry, 0);
+#endif
+}
+
+static inline void __set_tss_desc(unsigned cpu, unsigned int entry, void *addr)
+{
+	struct desc_struct *d = get_cpu_gdt_table(cpu);
+	tss_desc tss;
+
+	/*
+	 * sizeof(unsigned long) coming from an extra "long" at the end
+	 * of the iobitmap. See tss_struct definition in processor.h
+	 *
+	 * -1? seg base+limit should be pointing to the address of the
+	 * last valid byte
+	 */
+	pack_tss(&tss, (unsigned long)addr,
+		IO_BITMAP_OFFSET + IO_BITMAP_BYTES + sizeof(unsigned long) - 1,
+		DESC_TSS);
+	write_gdt_entry(d, entry, &tss, DESC_TSS);
+}
+
+#define set_tss_desc(cpu, addr) __set_tss_desc(cpu, GDT_ENTRY_TSS, addr)
+
 static inline void native_set_ldt(const void *addr, unsigned int entries)
 {
 	if (likely(entries == 0))
@@ -222,12 +255,6 @@ static inline void native_load_tls(struc
 		gdt[GDT_ENTRY_TLS_MIN + i] = t->tls_array[i];
 }
 
-#ifdef CONFIG_X86_32
-# include "desc_32.h"
-#else
-# include "desc_64.h"
-#endif
-
 #define _LDT_empty(info) (\
 	(info)->base_addr	== 0	&& \
 	(info)->limit		== 0	&& \
Index: linux-2.6-x86/include/asm-x86/desc_32.h
===================================================================
--- linux-2.6-x86.orig/include/asm-x86/desc_32.h
+++ /dev/null
@@ -1,27 +0,0 @@
-#ifndef __ARCH_DESC_H
-#define __ARCH_DESC_H
-
-#include <asm/ldt.h>
-#include <asm/segment.h>
-#include <asm/desc_defs.h>
-
-#ifndef __ASSEMBLY__
-
-#include <linux/preempt.h>
-#include <linux/percpu.h>
-
-static inline void __set_tss_desc(unsigned int cpu, unsigned int entry, const void *addr)
-{
-	tss_desc tss;
-	pack_descriptor(&tss, (unsigned long)addr,
-			offsetof(struct tss_struct, __cacheline_filler) - 1,
-			DESC_TSS, 0);
-	write_gdt_entry(get_cpu_gdt_table(cpu), entry, &tss, DESC_TSS);
-}
-
-
-#define set_tss_desc(cpu,addr) __set_tss_desc(cpu, GDT_ENTRY_TSS, addr)
-
-#endif /* !__ASSEMBLY__ */
-
-#endif
Index: linux-2.6-x86/include/asm-x86/desc_64.h
===================================================================
--- linux-2.6-x86.orig/include/asm-x86/desc_64.h
+++ linux-2.6-x86/include/asm-x86/desc_64.h
@@ -1,34 +1 @@
-/* Written 2000 by Andi Kleen */
-#ifndef __ARCH_DESC_H
-#define __ARCH_DESC_H
 
-#include <linux/threads.h>
-#include <asm/ldt.h>
-
-#ifndef __ASSEMBLY__
-
-#include <linux/string.h>
-
-#include <asm/segment.h>
-
-static inline void set_tss_desc(unsigned cpu, void *addr)
-{
-	struct desc_struct *d = get_cpu_gdt_table(cpu);
-	tss_desc tss;
-
-	/*
-	 * sizeof(unsigned long) coming from an extra "long" at the end
-	 * of the iobitmap. See tss_struct definition in processor.h
-	 *
-	 * -1? seg base+limit should be pointing to the address of the
-	 * last valid byte
-	 */
-	set_tssldt_descriptor(&tss,
-		(unsigned long)addr, DESC_TSS,
-		IO_BITMAP_OFFSET + IO_BITMAP_BYTES + sizeof(unsigned long) - 1);
-	write_gdt_entry(d, GDT_ENTRY_TSS, &tss, DESC_TSS);
-}
-
-#endif /* !__ASSEMBLY__ */
-
-#endif
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/19] desc_struct integration, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 1/19] unify desc_struct, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 2/19] unify struct desc_ptr, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 4/19] removed unused variable, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 5/19] introduce gate_desc type., Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 6/19] change write_idt_entry signature, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 7/19] introduce ldt_desc type., Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 8/19] modify write_ldt function, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 9/19] introduce fill_ldt, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 10/19] change write_gdt_entry signature., Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 11/19] change write_ldt_entry signature, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 12/19] move constants to desc_defs.h, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 14/19] use the same data type for tls_array., Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 15/19] modify get_desc_base, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 16/19] provide tss_desc, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 17/19] unify paravirt pieces of descriptor handling, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 18/19] move _set_gate and its users to a common loc ..., Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
[PATCH 19/19] unify set_tss_desc, Glauber de Oliveira ..., (Thu Dec 6, 9:16 am)
Re: [PATCH 1/19] unify desc_struct, Jeremy Fitzhardinge, (Thu Dec 6, 12:24 pm)
Re: [PATCH 1/19] unify desc_struct, Glauber de Oliveira ..., (Thu Dec 6, 12:37 pm)
Re: [PATCH 1/19] unify desc_struct, Glauber de Oliveira ..., (Thu Dec 6, 2:20 pm)
Re: [PATCH 1/19] unify desc_struct, Jeremy Fitzhardinge, (Thu Dec 6, 3:03 pm)
[PATCH 0/19] desc_struct integration, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 01/19] unify desc_struct, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 02/19] unify struct desc_ptr, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 03/19] change gdt acessor macro name, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 04/19] removed unused variable, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 05/19] introduce gate_desc type., Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 07/19] introduce ldt_desc type., Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 08/19] modify write_ldt function, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 09/19] introduce fill_ldt, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 10/19] provide tss_desc, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 11/19] change write_gdt_entry signature., Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 12/19] change write_ldt_entry signature, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 13/19] move constants to desc_defs.h, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 14/19] unify non-paravirt parts of desc.h, Glauber de Oliveira ..., (Wed Dec 12, 5:53 am)
[PATCH 15/19] use the same data type for tls_array., Glauber de Oliveira ..., (Wed Dec 12, 5:54 am)
[PATCH 16/19] modify get_desc_base, Glauber de Oliveira ..., (Wed Dec 12, 5:54 am)
[PATCH 17/19] unify paravirt pieces of descriptor handling, Glauber de Oliveira ..., (Wed Dec 12, 5:54 am)
[PATCH 18/19] move _set_gate and its users to a common loc ..., Glauber de Oliveira ..., (Wed Dec 12, 5:54 am)
[PATCH 19/19] unify set_tss_desc, Glauber de Oliveira ..., (Wed Dec 12, 5:54 am)
Re: [PATCH 0/19] desc_struct integration, Ingo Molnar, (Wed Dec 12, 10:20 am)
Re: [PATCH 09/19] introduce fill_ldt, Ingo Molnar, (Wed Dec 12, 10:56 am)
Re: [PATCH 0/19] desc_struct integration, Ingo Molnar, (Wed Dec 12, 11:11 am)
Re: [PATCH 0/19] desc_struct integration, Ingo Molnar, (Wed Dec 12, 11:20 am)
Re: [PATCH 0/19] desc_struct integration, Glauber de Oliveira ..., (Wed Dec 12, 11:27 am)
Re: [PATCH 0/19] desc_struct integration, Ingo Molnar, (Wed Dec 12, 11:33 am)
Re: [PATCH 0/19] desc_struct integration, Ingo Molnar, (Wed Dec 12, 11:34 am)
Re: [PATCH 0/19] desc_struct integration, Glauber de Oliveira ..., (Wed Dec 12, 12:05 pm)
Re: [PATCH 0/19] desc_struct integration, H. Peter Anvin, (Wed Dec 12, 4:39 pm)
[PATCH 0/19 - v3] desc_struct integration, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 02/19] unify struct desc_ptr, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 03/19] change gdt acessor macro name, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 04/19] removed unused variable, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 05/19] introduce gate_desc type., Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 06/19] change write_idt_entry signature, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 07/19] introduce ldt_desc type., Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 08/19] modify write_ldt function, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 09/19] introduce fill_ldt, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 10/19] provide tss_desc, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 11/19] change write_gdt_entry signature., Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 12/19] change write_ldt_entry signature, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 13/19] move constants to desc_defs.h, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 15/19] use the same data type for tls_array., Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 16/19] modify get_desc_base, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 17/19] unify paravirt pieces of descriptor handling, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 18/19] move _set_gate and its users to a common loc ..., Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
[PATCH 19/19] unify set_tss_desc, Glauber de Oliveira ..., (Wed Dec 12, 7:01 pm)
Re: [PATCH 19/19] unify set_tss_desc, Andi Kleen, (Thu Dec 13, 5:46 am)
[PATCH 0/19 -v4] desc_struct integration, Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 01/19] unify desc_struct, Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 02/19] unify struct desc_ptr, Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 03/19] change gdt acessor macro name, Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 04/19] removed unused variable, Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 05/19] introduce gate_desc type., Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 06/19] change write_idt_entry signature, Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 07/19] introduce ldt_desc type., Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 09/19] introduce fill_ldt, Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 10/19] provide tss_desc, Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 11/19] change write_gdt_entry signature., Glauber de Oliveira ..., (Thu Dec 13, 6:57 am)
[PATCH 12/19] change write_ldt_entry signature, Glauber de Oliveira ..., (Thu Dec 13, 6:58 am)
[PATCH 13/19] move constants to desc_defs.h, Glauber de Oliveira ..., (Thu Dec 13, 6:58 am)
[PATCH 14/19] unify non-paravirt parts of desc.h, Glauber de Oliveira ..., (Thu Dec 13, 6:58 am)
[PATCH 15/19] use the same data type for tls_array., Glauber de Oliveira ..., (Thu Dec 13, 6:58 am)
[PATCH 16/19] modify get_desc_base, Glauber de Oliveira ..., (Thu Dec 13, 6:58 am)
[PATCH 17/19] unify paravirt pieces of descriptor handling, Glauber de Oliveira ..., (Thu Dec 13, 6:58 am)
[PATCH 18/19] move _set_gate and its users to a common loc ..., Glauber de Oliveira ..., (Thu Dec 13, 6:58 am)
[PATCH 19/19] unify set_tss_desc, Glauber de Oliveira ..., (Thu Dec 13, 6:58 am)
Re: [PATCH 19/19] unify set_tss_desc, Glauber de Oliveira ..., (Thu Dec 13, 7:50 am)
Re: [PATCH 0/19 -v4] desc_struct integration, Ingo Molnar, (Thu Dec 13, 9:47 am)
Re: [PATCH 0/19 -v4] desc_struct integration, Glauber de Oliveira ..., (Thu Dec 13, 10:06 am)