Home » Mailing list archives » linux-kernel » 2007 » December » 12

Re: [PATCH] fbcon: fix sparse warning about shadowing 'p' symbol

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dave Jones <davej@...>
To: Andrew Morton <akpm@...>
Cc: Marcin __lusarz <marcin.slusarz@...>, <linux-kernel@...>, <adaplas@...>
Subject: Re: [PATCH] fbcon: fix sparse warning about shadowing 'p' symbol
Date: Tuesday, December 11, 2007 - 10:50 pm

On Tue, Dec 11, 2007 at 04:57:00PM -0800, Andrew Morton wrote:

 > > --- a/drivers/video/console/fbcon.c
 > > +++ b/drivers/video/console/fbcon.c
 > > @@ -2795,7 +2795,7 @@ static int fbcon_scrolldelta(struct vc_data *vc, int lines)
 > >  {
 > >  	struct fb_info *info = registered_fb[con2fb_map[fg_console]];
 > >  	struct fbcon_ops *ops = info->fbcon_par;
 > > -	struct display *p = &fb_display[fg_console];
 > > +	struct display *disp = &fb_display[fg_console];
 > 
 > We have a global symbol called "p"?  That would be bad.  Where is it?

in the same function.
We have quite a few shadow warnings in that file.

drivers/video/console/fbcon.c:337:25: warning: symbol '_x' shadows an earlier one
drivers/video/console/fbcon.c:337:25: originally declared here
drivers/video/console/fbcon.c:337:25: warning: symbol '_x' shadows an earlier one
drivers/video/console/fbcon.c:337:25: originally declared here
drivers/video/console/fbcon.c:337:25: warning: symbol '_y' shadows an earlier one
drivers/video/console/fbcon.c:337:25: originally declared here
drivers/video/console/fbcon.c:2813:19: warning: symbol 'p' shadows an earlier one
drivers/video/console/fbcon.c:2798:17: originally declared here
drivers/video/console/fbcon.c:3336:6: warning: symbol 'rotate' shadows an earlier one
drivers/video/console/fbcon.c:150:12: originally declared here
drivers/video/console/fbcon.c:3361:6: warning: symbol 'rotate' shadows an earlier one
drivers/video/console/fbcon.c:150:12: originally declared here
drivers/video/console/fbcon.c:3385:6: warning: symbol 'rotate' shadows an earlier one
drivers/video/console/fbcon.c:150:12: originally declared here

	Dave 


-- 
http://www.codemonkey.org.uk
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] fbcon: fix sparse warning about shadowing 'p' symbol, Marcin , (Sun Dec 9, 5:34 pm)
Re: [PATCH] fbcon: fix sparse warning about shadowing 'p' sy..., Andrew Morton, (Tue Dec 11, 8:57 pm)
Re: [PATCH] fbcon: fix sparse warning about shadowing 'p' sy..., David Miller, (Wed Dec 12, 3:23 pm)
Re: [PATCH] fbcon: fix sparse warning about shadowing 'p' sy..., Dave Jones, (Tue Dec 11, 10:50 pm)
Re: [PATCH] fbcon: fix sparse warning about shadowing 'p' sy..., Marcin , (Wed Dec 12, 3:37 pm)