ecryptfs_destroy_mount_crypt_stat() checks whether each auth_tok->global_auth_tok_key is nonzero and if so puts that key. However, in some early mount error paths nothing has initialized the pointer, and we try to key_put() garbage. Running the bad cipher tests in the testsuite exposes this, and it's happy with the following change. Signed-off-by: Eric Sandeen <sandeen@redhat.com> --- Index: linux/fs/ecryptfs/keystore.c ===========================================================...

Good day. Would some people on x86 (both 32 and 64) be kind enough to compile and run the attached program? This is about testing how long I/O port access to port 0x80 takes. It measures in CPU cycles so CPU speed is crucial in reporting. Posted a previous incarnation of this before, buried in the outb 0x80 thread which had a serialising problem. This one should as far as I can see measure the right thing though. Please yell if you disagree... For me, on a Duron 1300 (AMD756 chipset) I have...

El Wed, 12 Dec 2007 00:31:18 +0100 On my AMD 3800 X2 (2000MHz) ULi M1697 2.6.24-rc5 i get: cycles: out 1844674407370808, in 1844674407369087 It is not constant but variations are not significant afaics --

Sure, maxim@MAIN:~/tmp$ sudo ./port800 cycles: out 1767, in 1147 maxim@MAIN:~/tmp$ sudo ./port800 cycles: out 1774, in 1148 maxim@MAIN:~/tmp$ sudo ./port800 cycles: out 1769, in 1150 maxim@MAIN:~/tmp$ sudo ./port800 cycles: out 1769, in 1150 maxim@MAIN:~/tmp$ sudo ./port800 cycles: out 1777, in 1150 maxim@MAIN:~/tmp$ sudo ./port800 cycles: out 1766, in 1149 maxim@MAIN:~/tmp$ sudo ./port800 cycles: out 1768, in 1148 maxim@MAIN:~/tmp$ sudo ./port800 cycles: out 1765, in 1147 Core 2 ...

And... Linus, why do yo make mistakes in headers of announces :)? Not first time. --

This patch merges complete_request() into end_that_request_last() for cleanup. complete_request() was introduced by earlier part of this patch-set, not to break the existing users of end_that_request_last(). Since all users are converted to blk_end_request interfaces and end_that_request_last() is no longer exported, the code can be merged to end_that_request_last(). Cc: Boaz Harrosh <bharrosh@panasas.com> Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com> Signed-off-by: Jun'ichi ...

This patch converts 'uptodate' arguments of no longer exported interfaces, end_that_request_first/last, to 'error', and removes internal conversions for it in blk_end_request interfaces. Also, this patch removes no longer needed end_io_error(). Cc: Boaz Harrosh <bharrosh@panasas.com> Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com> Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com> --- block/ll_rw_blk.c | 56 +++++++------------------------------------------ inc...

This patch adds a variant of the interface, blk_end_bidi_request(), which completes a bidi request. Bidi request must be completed as a whole, both rq and rq->next_rq at once. So the interface has 2 arguments for completion size. As for ->end_io, only rq->end_io is called (rq->next_rq->end_io is not called). So if special completion handling is needed, the handler must be set to rq->end_io. And the handler must take care of freeing next_rq too, since the interface doesn't car...

This patch converts ide-cd (cdrom_newpc_intr()) to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. In PIO mode, ide-cd (cdrom_newpc_intr()) needs to defer end_that_request_last() until the device clears DRQ_STAT and raises an interrupt after end_that_request_first(). So blk_end_request() has to return without completing request even if no leftover in the request. ide-cd uses blk_end_request_callback() and a dummy callback function, which just returns value...

This patch converts "normal" parts of ide to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. The conversion of 'uptodate' to 'error' is done only for the internal function, __ide_end_request(). ide_end_request() was not changed since it's exported and used by many ide drivers. With this patch, blkdev_dequeue_request() in __ide_end_request() is moved to blk_end_request, since blk_end_request takes care of dequeueing request like below: if (!list_empty...

Acked-by: Grant Likely <grant.likely@secretlab.ca> -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@secretlab.ca (403) 399-0195 --

This patch converts ide-scsi to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com> Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com> --- drivers/scsi/ide-scsi.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) Index: 2.6.24-rc4/drivers/scsi/ide-scsi.c ===================================================================...

This patch converts viocd to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, viocd_end_request(), is changed. Cc: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com> Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com> --- drivers/cdrom/viocd.c | 15 ++++++--------- 1 files changed, 6 insertions(+), 9 deletions(-) Index: 2.6.24-rc4/drivers/cdr...

This patch converts mmc to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. Cc: Pierre Ossman <drzeus-mmc@drzeus.cx> Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com> Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com> --- drivers/mmc/card/block.c | 24 +++++------------------- drivers/mmc/card/queue.c | 4 ++-- 2 files changed, 7 insertions(+), 21 deletions(-) Index: 2.6.24-rc4/drivers/mmc/card/block.c ========================...

Kernel 2.6.22.14. Create a tree of directories containing tens or hundreds of thousands of symlinks and run find linkfarm | program-that-readlinks-the-file-names-in-its-stdin Memory usage will grow and grow until the system starts to swap, after which you are SOL. The combined effects of thrashing and the OOM killer will render your system catatonic for a long time and if it finally recovers, you probably won't be able to log in. With 1 GB of RAM, the tipping point is somewhere above 700,000 s...

This patch converts viodasd to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, viodasd_end_request(), is changed. Cc: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com> Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com> --- drivers/block/viodasd.c | 15 ++++++--------- 1 files changed, 6 insertions(+), 9 deletions(-) Index: 2.6.24-rc4/drive...

Acked-by: Pete Zaitcev <zaitcev@redhat.com> I follow the discussion, actually, and wanted to ask someone to look closer if it's appropriate to use __blk_end_request() here. My understanding was, blk_end_request() is the same thing, only takes the queue lock. But then, should I refactor ub so that it calls __blk_end_request if request function ends with an error and blk_end_request if the end-of-IO even is processed? If not, and the above is sufficient, why have blk_end_request at all? --...

This patch converts sunvdc to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, vdc_end_request(), is changed. Cc: David S. Miller <davem@davemloft.net> Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com> Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com> --- drivers/block/sunvdc.c | 11 ++++------- 1 files changed, 4 insertions(+), 7 deletions(-) Index: 2.6.24-rc4/drivers/block/sun...

This patch converts DAC960 to use blk_end_request interfaces. Related 'UpToDate' arguments are converted to 'Error'. Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com> Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com> --- drivers/block/DAC960.c | 11 ++--------- 1 files changed, 2 insertions(+), 9 deletions(-) Index: 2.6.24-rc4/drivers/block/DAC960.c =================================================================== --- 2.6.24-rc4.orig/drivers/block/DAC960.c +++ 2.6.24-rc...

Hi Jens, Boaz, The following is the updated patch-set for blk_end_request(). I have done some interface/implementation changes based on feedbacks/discussions since the previous version. (Although this patch-set was made on top of 2.6.24-rc4, I confirmed it can be applied to 2.6.24-rc5, too. Also, I confirmed it has no build error on my IA64 box.) As for patches without Cc tag, I couldn't find the maintainer related to the patch. Patch 27 through patch 30 conflict with Boaz's scsi bidi patc...

This patch converts core parts of block layer to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. 'dequeue' argument was originally introduced for end_dequeued_request(), where no attempt should be made to dequeue the request as it's already dequeued. However, it's not necessary as it can be checked with list_empty(&rq->queuelist). (Dequeued request has empty list and queued request doesn't.) And it has been done in blk_end_request interfaces. As a ...

This patch adds/exports functions to get the size of request in bytes. They are useful because blk_end_request interfaces take bytes as a completed I/O size instead of sectors. Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com> Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com> --- block/ll_rw_blk.c | 25 ++++++++++++++++++++++--- include/linux/blkdev.h | 8 ++++++++ 2 files changed, 30 insertions(+), 3 deletions(-) Index: 2.6.24-rc4/include/linux/blkdev.h =========...

This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: <-- snip --> ... WARNING: vmlinux.o(.init.text.20+0xb3061): Section mismatch: reference to .exit.text:asd_unmap_ha (between 'asd_pci_probe' and 'ips_insert_device') ... <-- snip --> Signed-off-by: Adrian Bunk <bunk@kernel.org> --- drivers/scsi/aic94xx/aic94xx_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) c9292b20fa9402084f207e7efa50fcd4150001a4 diff --git a/drivers/...

This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: <-- snip --> ... WARNING: vmlinux.o(.exit.text+0xcf8a): Section mismatch: reference to .init.data:_asc_def_iop_base (between 'advansys_isa_remove' and 'exit_this_scsi_driver') ... <-- snip --> Signed-off-by: Adrian Bunk <bunk@kernel.org> --- e81cac11f9efe882a89708c298fa6268375b0221 diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index 9dd3952..38a1ee2 100644 --- a/drivers/scsi/ad...

This patch fixes the following section mismatch with CONFIG_HOTPLUG=n: <-- snip --> ... WARNING: vmlinux.o(.text+0x94f07b): Section mismatch: reference to .init.text.20:init_ivtv_i2c (between 'ivtv_process_eeprom' and 'ivtv_init_on_first_open') ... <-- snip --> Signed-off-by: Adrian Bunk <bunk@kernel.org> --- drivers/media/video/ivtv/ivtv-i2c.c | 2 +- drivers/media/video/ivtv/ivtv-i2c.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) e09578fa0d...