login
Header Space

 
 

[PATCH 12/30] blk_end_request: changing ub (take 4)

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <jens.axboe@...>
Cc: <linux-kernel@...>, <linux-scsi@...>, <linux-ide@...>, <dm-devel@...>, <j-nomura@...>, <k-ueda@...>, <zaitcev@...>
Date: Tuesday, December 11, 2007 - 6:46 pm

This patch converts ub to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.

Cc: Pete Zaitcev <zaitcev@redhat.com>
Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
---
 drivers/block/ub.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

Index: 2.6.24-rc4/drivers/block/ub.c
===================================================================
--- 2.6.24-rc4.orig/drivers/block/ub.c
+++ 2.6.24-rc4/drivers/block/ub.c
@@ -808,16 +808,16 @@ static void ub_rw_cmd_done(struct ub_dev
 
 static void ub_end_rq(struct request *rq, unsigned int scsi_status)
 {
-	int uptodate;
+	int error;
 
 	if (scsi_status == 0) {
-		uptodate = 1;
+		error = 0;
 	} else {
-		uptodate = 0;
+		error = -EIO;
 		rq->errors = scsi_status;
 	}
-	end_that_request_first(rq, uptodate, rq->hard_nr_sectors);
-	end_that_request_last(rq, uptodate);
+	if (__blk_end_request(rq, error, blk_rq_bytes(rq)))
+		BUG();
 }
 
 static int ub_rw_cmd_retry(struct ub_dev *sc, struct ub_lun *lun,
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 12/30] blk_end_request: changing ub (take 4), Kiyoshi Ueda, (Tue Dec 11, 6:46 pm)
Re: [PATCH 12/30] blk_end_request: changing ub (take 4), Pete Zaitcev, (Tue Dec 11, 7:48 pm)
Re: [PATCH 12/30] blk_end_request: changing ub (take 4), Kiyoshi Ueda, (Wed Dec 12, 4:38 pm)
Re: [PATCH 12/30] blk_end_request: changing ub (take 4), Pete Zaitcev, (Thu Dec 13, 5:59 pm)
Re: [PATCH 12/30] blk_end_request: changing ub (take 4), Kiyoshi Ueda, (Fri Dec 14, 1:04 pm)
speck-geostationary