login
Header Space

 
 

Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Alan Cox <alan@...>
Cc: Tejun Heo <htejun@...>, Andrew Morton <akpm@...>, Rafael J. Wysocki <rjw@...>, LKML <linux-kernel@...>, Ingo Molnar <mingo@...>
Date: Sunday, December 9, 2007 - 9:57 pm

On Sun, 9 Dec 2007, Alan Cox wrote:

Alan, you're so full of shit that it's not even funny.

Have you even *read* the thread?

Tejun already reported that this apparently gets fixed _properly_ with the 
more extensive cleanups and fixes that are pending for 2.6.25.

In other words, the stuff you call so critically important (yet we've been 
able to live without it until now!) is apparently simply NOT YET READY. 
It's breaking things.

In this case, Tejun seems to be right on the money.  I also agree 100% 
with him when he says

   "Blacklist takes time to develop and temporary blacklist for just one
    release doesn't sound like a good idea."

because if we create some blacklist for that one reported device, not only 
is it likely going to be wrong (it's almost never just one firmware or one 
chip that has a particular issue), but we tend to create thee blacklists 
and later realize that we shouldn't have blacklisted things at all, we 
should just have done things differently.

For examples of that, see the NCQ blacklist that was just _us_ doing 
things wrong (over-reacting to things we shouldn't care about), and 
there's currently another totally unrelated discussion on a very similar 
thing wrt libata and the ACPI startup commands for an unused controller 
port.


.. and what the hell does that matter? If the code doesn't work, it 
doesn't work, and you might as well point to some random scribblings done 
by a three-year-old on toilet paper rather than any "specs".

Real life matters more. Regressions matter more.

We apparently do have a full fix, but it seems to be too invasive for 
2.6.24, which means that the thing that currently DOES NOT WORK and 
causes regressions should be reverted, so that 2.6.24 is at least no worse 
than 2.6.23 (and all earlier kernels) in this respect.

And then we should just hope that the more complete fix that Tejun has 
doesn't cause any issues on its own. I would suggest that if you care so 
deeply about this issue, you press Fedora into putting Tejun's tree into 
Fedora testing, and get that thing tested out extensively.

So the fact is, we have a way forward, but we should *not* take steps 
backwards just because you want to push something out that isn't quite 
ready. We should revert the change that causes the current trouble, safe 
in the knowledge (or at least "strong hope") that we have a way forward 
that makes *both* 2.6.24 and 2.6.25 be continual improvements.

We used to allow regressions. It was really painful. It's hard to debug 
things when things sometimes break. It's much better to have a nice 
constant monotonic improvement.

It's better for users, but it's much better also for developers, even if 
you may be frustrated right now because some new code effectively gets 
shut down until it works for everybody.

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Fri Dec 7, 10:40 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Mon Dec 10, 4:42 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Mon Dec 10, 4:59 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Mon Dec 10, 6:45 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Mon Dec 10, 7:04 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Stefano Brivio, (Mon Dec 10, 7:34 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Tue Dec 11, 5:01 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Stefano Brivio, (Tue Dec 11, 5:10 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Guillaume Chazarain, (Mon Dec 10, 7:53 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Tue Dec 11, 4:48 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Arjan van de Ven, (Mon Dec 10, 7:56 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Guillaume Chazarain, (Mon Dec 10, 8:01 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Arjan van de Ven, (Mon Dec 10, 9:06 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Tue Dec 11, 4:43 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Guillaume Chazarain, (Mon Dec 10, 4:57 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sun Dec 9, 7:54 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sun Dec 9, 10:24 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Fabio Comolli, (Sat Dec 8, 2:53 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 5:23 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sat Dec 8, 6:11 pm)
Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, [2..., Christoph Lameter, (Thu Dec 13, 6:03 pm)
Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, [2..., Rafael J. Wysocki, (Sun Dec 9, 10:17 am)
Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, [2..., Christoph Lameter, (Fri Dec 14, 12:07 am)
Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, [2..., Christoph Lameter, (Thu Dec 13, 6:07 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 5:52 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Linus Torvalds, (Sun Dec 9, 2:41 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Linus Torvalds, (Sun Dec 9, 9:57 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Mon Dec 10, 4:21 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Ingo Molnar, (Mon Dec 10, 4:41 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Linus Torvalds, (Mon Dec 10, 11:38 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Linus Torvalds, (Sun Dec 9, 2:36 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 5:46 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 5:42 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Roland Dreier, (Sat Dec 8, 2:57 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Theodore Tso, (Sat Dec 8, 3:40 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sat Dec 8, 6:30 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Theodore Tso, (Sat Dec 8, 10:15 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Takashi Iwai, (Thu Dec 13, 6:49 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Takashi Iwai, (Thu Dec 20, 11:42 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 5:36 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sun Dec 9, 10:20 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andreas Mohr, (Sat Dec 8, 6:12 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 6:20 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andreas Mohr, (Sat Dec 8, 6:55 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andreas Mohr, (Sun Dec 9, 3:59 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Matthew Garrett, (Sat Dec 8, 6:28 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Andrew Morton, (Sat Dec 8, 5:29 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sat Dec 8, 6:17 pm)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Richard Purdie, (Sat Dec 8, 6:44 am)
Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23, Rafael J. Wysocki, (Sat Dec 8, 6:32 pm)
speck-geostationary