On Sat, 1 December 2007 21:54:56 +0100, Ingo Molnar wrote:
quoted text
> * J??rn Engel <joern@logfs.org> wrote:
> > 
> > stopped custom tracer.
> > BUG: spinlock recursion on CPU#0, sh/953
> >  lock: c030f280, .magic: dead4ead, .owner: sh/953, .owner_cpu: 0
> > Pid: 953, comm: sh Not tainted 2.6.24-rc3-ge1cca7e8-dirty #2
> >  [<c0103a04>] show_trace_log_lvl+0x35/0x54
> >  [<c010450a>] show_trace+0x2c/0x2e
> >  [<c0104e6d>] dump_stack+0x84/0x8a
> >  [<c01ded7c>] spin_bug+0xa7/0xae
> >  [<c01def14>] _raw_spin_lock+0x45/0xfa
> >  [<c02a02b1>] _spin_lock_irqsave+0x68/0x7a
> >  [<c01087e7>] pit_read+0x14/0x99
> >  [<c0130ee9>] get_monotonic_cycles+0xf/0x2d
> 
> ah. You should mark pit_read() function as notrace. PIT clocksource is 
> rare. (add the 'notrace' word to the function prototype)

Hardly a change at all.  Apart from some offsets, this dump is
identical.

stopped custom tracer.
BUG: spinlock recursion on CPU#0, sh/954
 lock: c030f280, .magic: dead4ead, .owner: sh/954, .owner_cpu: 0
Pid: 954, comm: sh Not tainted 2.6.24-rc3-ge1cca7e8-dirty #3
 [<c0103a04>] show_trace_log_lvl+0x35/0x54
 [<c010450a>] show_trace+0x2c/0x2e
 [<c0104e6d>] dump_stack+0x84/0x8a
 [<c01ded7c>] spin_bug+0xa7/0xae
 [<c01def14>] _raw_spin_lock+0x45/0xfa
 [<c02a02b1>] _spin_lock_irqsave+0x68/0x7a
 [<c01087e2>] pit_read+0xf/0x91
 [<c0130ee1>] get_monotonic_cycles+0xf/0x2d
 [<c013c0e7>] now+0x2a/0x7c
 [<c013c333>] ____trace+0x4d/0x1e8
 [<c013dbeb>] __mcount+0x95/0xa6
 [<c010d354>] mcount+0x14/0x18
 [<c0135a3c>] lock_acquired+0xe/0x1d7
 [<c02a02b9>] _spin_lock_irqsave+0x70/0x7a
 [<c01087e2>] pit_read+0xf/0x91
 [<c0130789>] update_wall_time+0x23/0x692
 [<c012174e>] do_timer+0x24/0xb1
 [<c01331f6>] tick_periodic+0x49/0x84
 [<c0133253>] tick_handle_periodic+0x22/0x73
 [<c0106315>] timer_interrupt+0x4f/0x56
 [<c013e2bf>] handle_IRQ_event+0x24/0x4f
 [<c013f442>] handle_edge_irq+0xb8/0x125
 [<c01054ee>] do_IRQ+0x89/0xa3
 [<c01033df>] common_interrupt+0x23/0x28
 [<c010d354>] mcount+0x14/0x18
 [<c0120130>] sysctl_head_finish+0xc/0x33
 [<c0192d64>] proc_sys_write+0x96/0xa0
 [<c015d91c>] vfs_write+0xa6/0x14c
 [<c015df66>] sys_write+0x4c/0x70
 [<c0102a1f>] syscall_call+0x7/0xb
 =======================

Jörn

-- 
Don't worry about people stealing your ideas. If your ideas are any good,
you'll have to ram them down people's throats.
-- Howard Aiken quoted by Ken Iverson quoted by Jim Horning quoted by
   Raph Levien, 1979
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/