login
Header Space

 
 

Re: [feature] automatically detect hung TASK_UNINTERRUPTIBLE tasks

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: <linux-kernel@...>, Andrew Morton <akpm@...>, Arjan van de Ven <arjan@...>, Thomas Gleixner <tglx@...>
Date: Saturday, December 1, 2007 - 2:31 pm

The checked auto variable isn't doing anything in
check_hung_uninterruptible_tasks().

Signed-off-by: David Rientjes <rientjes@google.com>
---
 kernel/softlockup.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/kernel/softlockup.c b/kernel/softlockup.c
--- a/kernel/softlockup.c
+++ b/kernel/softlockup.c
@@ -170,7 +170,6 @@ static void check_hung_uninterruptible_tasks(int this_cpu)
 	int max_count = sysctl_hung_task_check_count;
 	unsigned long now = get_timestamp(this_cpu);
 	struct task_struct *g, *t;
-	int checked = 0;
 
 	/*
 	 * If the system crashed already then all bets are off,
@@ -183,10 +182,8 @@ static void check_hung_uninterruptible_tasks(int this_cpu)
 	do_each_thread(g, t) {
 		if (!--max_count)
 			break;
-		if (t->state & TASK_UNINTERRUPTIBLE) {
+		if (t->state & TASK_UNINTERRUPTIBLE)
 			check_hung_task(t, now);
-			checked++;
-		}
 	} while_each_thread(g, t);
 
 	read_unlock(&tasklist_lock);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [feature] automatically detect hung TASK_UNINTERRUPTIBLE..., Radoslaw Szkodzinski, (Mon Dec 3, 6:15 am)
Re: [feature] automatically detect hung TASK_UNINTERRUPTIBLE..., David Rientjes, (Sat Dec 1, 2:31 pm)
speck-geostationary