Home » Mailing list archives » linux-kernel » 2007 » November » 9

Re: [PATCH 2/7] Char: rocket, printk cleanup

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Alan Cox <alan@...>
To: Jiri Slaby <jirislaby@...>
Cc: Andrew Morton <akpm@...>, <linux-kernel@...>
Subject: Re: [PATCH 2/7] Char: rocket, printk cleanup
Date: Friday, November 9, 2007 - 7:41 pm

> -	printk(KERN_INFO "rp_do_receive(%d)...", ToRecv);

The missing \n was intentional looking at the old code, and meant you got
a lot of trace per line for debugging. The KERN_ additions are the
breakage here.

We might as well just lose them, we have proper debuggers now and they
are useless with \n, and pretty useless without.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/7] Char: rocket, switch long delay to sleep, Jiri Slaby, (Fri Nov 9, 7:34 pm)
[PATCH 7/7] Char: riscom8, change rc_init_drivers prototype, Jiri Slaby, (Fri Nov 9, 7:38 pm)
[PATCH 6/7] Char: stallion, fix compiler warnings, Jiri Slaby, (Fri Nov 9, 7:38 pm)
[PATCH 5/7] Char: mxser_new, ioaddresses are ulong, Jiri Slaby, (Fri Nov 9, 7:37 pm)
[PATCH 4/7] Char: char/serial, remove SERIAL_TYPE_NORMAL red..., Jiri Slaby, (Fri Nov 9, 7:36 pm)
[PATCH 3/7] Char: rocket, remove useless macros, Jiri Slaby, (Fri Nov 9, 7:36 pm)
Re: [PATCH 3/7] Char: rocket, remove useless macros, Alan Cox, (Fri Nov 9, 7:42 pm)
[PATCH 2/7] Char: rocket, printk cleanup, Jiri Slaby, (Fri Nov 9, 7:35 pm)
Re: [PATCH 2/7] Char: rocket, printk cleanup, Alan Cox, (Fri Nov 9, 7:41 pm)