Re: [patch 01/28] cpu alloc: The allocator

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <peterz@...>
Cc: <clameter@...>, <akpm@...>, <linux-kernel@...>
Date: Thursday, November 8, 2007 - 7:26 pm

From: Peter Zijlstra <peterz@infradead.org>
Date: Thu, 08 Nov 2007 21:19:08 +0100


I disagree, macros in upper case make sense here.  Macros should SHOUT
at you because CPP is MAGIC and has side effects that normal real
functions do not have, and therefore you need to be REMINDED.

And, honestly, aren't there more important issues about his patches to
review than macro capitalization?
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [patch 01/28] cpu alloc: The allocator, Peter Zijlstra, (Thu Nov 8, 4:19 pm)
Re: [patch 01/28] cpu alloc: The allocator, David Miller, (Thu Nov 8, 7:26 pm)
Re: [patch 01/28] cpu alloc: The allocator, Christoph Lameter, (Thu Nov 8, 4:24 pm)
Re: [patch 01/28] cpu alloc: The allocator, David Miller, (Thu Nov 8, 7:26 pm)