Home » Mailing list archives » linux-kernel » 2007 » November » 8

Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Tetsuo Handa <penguin-kernel@...>
To: Andrew Morton <akpm@...>
Cc: <ebiederm@...>, <linux-kernel@...>, Tetsuo Handa <penguin-kernel@...>
Subject: Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
Date: Thursday, November 8, 2007 - 4:19 am

Hello.

Thanks for reformatting my patch
and sorry for surprising you with directory name
(I meant to type linux-2.6.24-rc2, not linux-2.6.22-rc2).

According to linux-2.6.23,
it seems that I should return -ENOTDIR
for invalid args->nlen value.

I got a question here regarding interpretation of CTL_MAXNAME .
Is args->nlen == CTL_MAXNAME valid?
It is treated as invalid while the definition says

  /* how many path components do we allow in a
     call to sysctl?   In other words, what is
     the largest acceptable value for the nlen
     member of a struct __sysctl_args to have? */

If "name[CTL_MAXNAME];" is what the author intended,
I think args->nlen == CTL_MAXNAME is valid.

Regards.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] sysctl: Check length at deprecated_sysctl_warning., Tetsuo Handa, (Wed Nov 7, 10:57 pm)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Andrew Morton, (Wed Nov 7, 11:22 pm)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Tetsuo Handa, (Thu Nov 8, 4:19 am)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Eric W. Biederman, (Mon Nov 12, 5:44 am)
[PATCH] sysctl: Check length at deprecated_sysctl_warning., Tetsuo Handa, (Mon Nov 12, 11:07 pm)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Andrew Morton, (Mon Nov 12, 11:13 pm)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Tetsuo Handa, (Mon Nov 12, 11:50 pm)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Eric W. Biederman, (Tue Nov 13, 9:24 am)
Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning., Tetsuo Handa, (Mon Nov 12, 7:42 am)