Re: compat_sys_times() bogus until jiffies >= 0.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <akpm@...>
Cc: <paulus@...>, <lkml@...>, <linux-kernel@...>, <drepper@...>, <mtk-manpages@...>
Date: Thursday, November 8, 2007 - 3:14 am

From: Andrew Morton <akpm@linux-foundation.org>
Date: Wed, 7 Nov 2007 23:09:16 -0800


You and I would say "wtf", but the manual states what it does:

	On error, (clock_t) -1 is returned, and errno is  set  appro-
	priately.

And I think this (obviously bogus) convention is something we
are really stuck with.

Another awful aspect of this is that glibc is going to overwrite
'errno' for this return value range.  That will likely cause more
application misbehavior than some of the other side effects we've been
discussing.

In short we have two problems:

1) glibc thinks -4096 < x < 0 is an error, and will write this
   value into errno and return -1 to the application

2) the manual states that -1 means error

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
compat_sys_times() bogus until jiffies &gt;= 0., David Brown, (Wed Nov 7, 6:47 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andrew Morton, (Wed Nov 7, 7:28 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Brown, (Thu Nov 8, 2:00 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andrew Morton, (Wed Nov 7, 8:18 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andreas Schwab, (Wed Nov 7, 8:54 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andrew Morton, (Wed Nov 7, 9:17 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Paul Mackerras, (Wed Nov 7, 9:53 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andrew Morton, (Wed Nov 7, 11:07 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Denys Vlasenko, (Thu Nov 8, 3:27 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Wed Nov 7, 11:13 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Paul Mackerras, (Thu Nov 8, 1:15 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Thu Nov 8, 2:24 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Paul Mackerras, (Thu Nov 8, 12:59 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andrew Morton, (Thu Nov 8, 1:20 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Thu Nov 8, 2:25 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andrew Morton, (Thu Nov 8, 3:09 am)
Re: compat_sys_times() bogus until jiffies >= 0., David Miller, (Thu Nov 8, 3:14 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Paul Mackerras, (Thu Nov 8, 4:53 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Paul Mackerras, (Thu Nov 8, 1:36 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andrew Morton, (Thu Nov 8, 2:12 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Thu Nov 8, 2:22 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Wed Nov 7, 10:09 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andreas Schwab, (Thu Nov 8, 6:20 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Chris Friesen, (Thu Nov 8, 10:42 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Ulrich Drepper, (Fri Nov 9, 2:20 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Michael Kerrisk, (Thu Dec 20, 7:36 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Thu Dec 20, 7:51 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andi Kleen, (Fri Dec 21, 8:42 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Fri Dec 21, 9:41 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andi Kleen, (Fri Dec 21, 9:49 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Fri Dec 21, 9:45 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andi Kleen, (Fri Dec 21, 9:53 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Sat Dec 22, 12:36 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andi Kleen, (Sat Dec 22, 8:47 am)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Denys Vlasenko, (Thu Nov 8, 3:25 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., David Miller, (Wed Nov 7, 8:50 pm)
Re: compat_sys_times() bogus until jiffies &gt;= 0., Andrew Morton, (Wed Nov 7, 9:13 pm)