Re: [PATCH 0/2] MN10300: Add the MN10300 architecture to Linux kernel [try #3]

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Adrian Bunk
Date: Wednesday, November 7, 2007 - 9:13 pm

On Wed, Nov 07, 2007 at 05:43:23PM +0000, David Howells wrote:


The patch to include/asm-generic/Kbuild.asm doesn't seem to be required.


+#elif defined(__mn10300__)

Please use a CONFIG_ variable in such cases.


The parts outside arch/mn10300/ and include/asm-mn10300/ (except for the 
trivial "&& {,!}MN10300" Kconfig changes) should go separately through 
the maintainers or get ACKs from the maintainers, even more since they 
also contain cleanups like

-               .regions = {ERASEINFO(0x01000,64),
+               .regions        = {
+                       ERASEINFO(0x01000,64),
                }


--- a/include/linux/kprobes.h
+++ b/include/linux/kprobes.h
...
+extern void __kprobes arch_remove_kprobe(struct kprobe *p);

This looks as if it will break compilation on avr32 and sparc64.



What is the status of support in upstream GNU binutils and GNU gcc?


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 0/2] MN10300: Add the MN10300 architecture to L ..., Adrian Bunk, (Wed Nov 7, 9:13 pm)