[PATCH] chipsfb: uses/depends on PCI

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Kamalesh Babulal <kamalesh@...>, <adaplas@...>
Cc: <akpm@...>, <mm-commits@...>, <linux-kernel@...>, Paul Mackerras <paulus@...>, Andy Whitcroft <apw@...>
Date: Wednesday, November 7, 2007 - 5:15 pm

From: Randy Dunlap <randy.dunlap@oracle.com>

chipsfb uses PCI interfaces and should depend on PCI.

  CC      drivers/video/chipsfb.o
drivers/video/chipsfb.c: In function 'chipsfb_pci_init':
drivers/video/chipsfb.c:378: error: implicit declaration of function 'pci_request_region'
drivers/video/chipsfb.c:435: error: implicit declaration of function 'pci_release_region'
make[2]: *** [drivers/video/chipsfb.o] Error 1
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2

!CONFIG_PCI causes the build to fail.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/video/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2624-rc1-mmbo.orig/drivers/video/Kconfig
+++ linux-2624-rc1-mmbo/drivers/video/Kconfig
@@ -503,7 +503,7 @@ config FB_VALKYRIE
 
 config FB_CT65550
 	bool "Chips 65550 display support"
-	depends on (FB = y) && PPC32
+	depends on (FB = y) && PPC32 && PCI
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: mm snapshot broken-out-2007-11-06-02-32 powerpc - axon_m..., Benjamin Herrenschmidt, (Wed Nov 7, 4:28 pm)
[PATCH] chipsfb: uses/depends on PCI, Randy Dunlap, (Wed Nov 7, 5:15 pm)
Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded, Badari Pulavarty, (Tue Nov 6, 3:32 pm)
Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded, Serge E. Hallyn, (Mon Nov 12, 4:17 pm)
Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded, Badari Pulavarty, (Tue Nov 6, 2:36 pm)
[BUG] mm snapshot broken-out-2007-11-06-02-32 - kernel oops, Kamalesh Babulal, (Tue Nov 6, 1:27 pm)