Re: [patch 04/23] dentries: Extract common code to remove dentry from lru

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Christoph Lameter <clameter@...>

To: Jörn <joern@...>

Cc: Johannes Weiner <hannes-kernel@...>, <akpm@...>, <linux-kernel@...>, <linux-mm@...>, Mel Gorman <mel@...>

Subject: Re: [patch 04/23] dentries: Extract common code to remove dentry from lru

Date: Wednesday, November 7, 2007 - 3:00 pm

On Wed, 7 Nov 2007, J=F6rn Engel wrote:

quoted text> > Acked-by: Joern Engel <joern@logfs.org>
> > Signed-off-by: Christoph Lameter <clameter@sgi.com>
> >=20
> > Index: linux-2.6/fs/dcache.c
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
quoted text> > --- linux-2.6.orig/fs/dcache.c=092007-11-07 10:26:20.000000000 -0800
> > +++ linux-2.6/fs/dcache.c=092007-11-07 10:26:27.000000000 -0800
> > @@ -610,7 +610,7 @@ static void shrink_dcache_for_umount_sub
> >  =09=09=09spin_lock(&dcache_lock);
> >  =09=09=09list_for_each_entry(loop, &dentry->d_subdirs,
> >  =09=09=09=09=09    d_u.d_child) {
> > -=09=09=09=09dentry_lru_remove(dentry);
> > +=09=09=09=09dentry_lru_remove(loop);
> >  =09=09=09=09__d_drop(loop);
> >  =09=09=09=09cond_resched_lock(&dcache_lock);
> >  =09=09=09}
>=20
> Erm - wouldn't this break git-bisect?

Well Andrew will merge it into the earlier patch.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[patch 04/23] dentries: Extract common code to remove dentry..., Christoph Lameter, (Tue Nov 6, 9:11 pm)

Re: [patch 04/23] dentries: Extract common code to remove de..., Johannes Weiner, (Wed Nov 7, 4:50 am)

Re: [patch 04/23] dentries: Extract common code to remove de..., Christoph Lameter, (Wed Nov 7, 2:28 pm)

Re: [patch 04/23] dentries: Extract common code to remove de..., Jörn, (Wed Nov 7, 5:43 am)

Re: [patch 04/23] dentries: Extract common code to remove de..., Christoph Lameter, (Wed Nov 7, 2:55 pm)

Re: [patch 04/23] dentries: Extract common code to remove de..., Jörn, (Wed Nov 7, 2:54 pm)

Re: [patch 04/23] dentries: Extract common code to remove de..., Christoph Lameter, (Wed Nov 7, 3:00 pm)

Navigation

Popular discussions


linux-kernel:
Jens Axboe	Re: [BUG] New Kernel Bugs
Faik Uygur	Re: Linux 2.6.21-rc1
Ingo Molnar	[patch 02/13] syslets: add syslet.h include file, user API/ABI definitions
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
git:

linux-netdev:
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	Re: Data corruption issue with splice() on 2.6.27.10
Steven Rostedt	Re: -rt scheduling: wakeup bug?
openbsd-misc:

Colocation donated by:

Online users

Syndicate