Home » Mailing list archives » linux-kernel » 2007 » November » 7

[PATCH] fix incorrect test in trident_ac97_set(); sound/oss/trident.c

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roel Kluin <12o3l@...>
To: lkml <linux-kernel@...>
Subject: [PATCH] fix incorrect test in trident_ac97_set(); sound/oss/trident.c
Date: Wednesday, November 7, 2007 - 2:34 pm

If count reaches zero, the loop ends, but the postfix decrement subtracts it.
so, testing for 'count == 0' will not work.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/sound/oss/trident.c b/sound/oss/trident.c
index 96adc47..94b5fb4 100644
--- a/sound/oss/trident.c
+++ b/sound/oss/trident.c
@@ -2939,7 +2939,7 @@ trident_ac97_set(struct ac97_codec *codec, u8 reg, u16 val)
 
 	data |= (mask | (reg & AC97_REG_ADDR));
 
-	if (count == 0) {
+	if (count == -1) {
 		printk(KERN_ERR "trident: AC97 CODEC write timed out.\n");
 		spin_unlock_irqrestore(&card->lock, flags);
 		return;
@@ -2999,7 +2999,7 @@ trident_ac97_get(struct ac97_codec *codec, u8 reg)
 	} while (count--);
 	spin_unlock_irqrestore(&card->lock, flags);
 
-	if (count == 0) {
+	if (count == -1) {
 		printk(KERN_ERR "trident: AC97 CODEC read timed out.\n");
 		data = 0;
 	}

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] fix incorrect test in trident_ac97_set(); sound/oss/..., Roel Kluin, (Wed Nov 7, 2:34 pm)
Re: [PATCH] fix incorrect test in trident_ac97_set(); sound/..., Ray Lee, (Wed Nov 7, 2:43 pm)
Re: [PATCH] fix incorrect test in trident_ac97_set(); sound/..., Roel Kluin, (Wed Nov 7, 2:50 pm)
Re: [PATCH] fix incorrect test in trident_ac97_set(); sound/..., Ray Lee, (Wed Nov 7, 3:04 pm)
Re: [PATCH] fix incorrect test in trident_ac97_set(); sound/..., Muli Ben-Yehuda, (Thu Nov 8, 2:06 am)