Re: [PATCH 1/1] aacraid: don't assign cpu_to_le32(int) to u8

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Christoph Hellwig

Subject: Re: [PATCH 1/1] aacraid: don't assign cpu_to_le32(int) to u8

Date: Wednesday, November 7, 2007 - 10:33 am

On Wed, Nov 07, 2007 at 10:58:12AM -0500, Salyzyn, Mark wrote:
quoted text> Good point, thanks. The intent of the management applications
> utilization of this AIF report is to observe the LSB of the value of
> integer value in BlinkLED. The actions of the cpu_to_le32 actually
> breaks this and reports the wrong content in swapped architectures.
> 
> This attached follow-up patch is against current scsi-misc-2.6 *after*
> the application of the 'don't assign cpu_to_le32(constant) to u8' patch
> submitted by Stephen Rothwell which has already been taken by the -mm
> tree. Inspection of other areas of the aacraid driver came up blank for
> similar style bugs.

Did anyone run the driver through sparse to see if we have more issues like
this?

-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] aacraid: don't assign cpu_to_le32(constant) to u8, Stephen Rothwell, (Tue Oct 30, 9:02 pm)

RE: [PATCH] aacraid: don't assign cpu_to_le32(constant) to u8, Salyzyn, Mark, (Wed Oct 31, 6:53 am)

[PATCHv2] aacraid: don't assign cpu_to_le32(constant) to u8, Stephen Rothwell, (Wed Oct 31, 11:32 pm)

RE: [PATCHv2] aacraid: don't assign cpu_to_le32(constant) ..., Salyzyn, Mark, (Thu Nov 1, 6:11 am)

Re: [PATCHv2] aacraid: don't assign cpu_to_le32(constant) ..., Andreas Schwab, (Thu Nov 1, 6:31 am)

[PATCH 1/1] aacraid: don't assign cpu_to_le32(int) to u8, Salyzyn, Mark, (Wed Nov 7, 8:58 am)

Re: [PATCH 1/1] aacraid: don't assign cpu_to_le32(int) to u8, Christoph Hellwig, (Wed Nov 7, 10:33 am)

RE: [PATCH 1/1] aacraid: don't assign cpu_to_le32(int) to u8, Salyzyn, Mark, (Wed Nov 7, 11:51 am)

Re: [PATCH 1/1] aacraid: don't assign cpu_to_le32(int) to u8, Christoph Hellwig, (Thu Nov 8, 10:27 am)

RE: [PATCH 1/1] aacraid: don't assign cpu_to_le32(int) to u8, Salyzyn, Mark, (Thu Nov 8, 11:09 am)


linux-kernel:
Ken Chen	[patch] sched: fix inconsistency when redistribute per-cpu tg->cfs_rq shares.
Ingo Molnar	Re: [PATCH v3] x86: merge the simple bitops and move them to bitops.h
Jan Engelhardt	Re: [PATCH] Allow Kconfig to set default mmap_min_addr protection
Dmitry Torokhov	Re: [2.6 patch] input/serio/hp_sdc.c section fix
Rafael J. Wysocki	[Bug #16380] Loop devices act strangely in 2.6.35
git:
Steven Grimm	Using git as a general backup mechanism (was Re: Using GIT to store /etc)
Jeff King	Re: [PATCH] git-reset: allow --soft in a bare repo
Johannes Sixt	Re: [PATCH 01/14] msvc: Fix compilation errors in compat/win32/sys/poll.c
Johannes Schindelin	Re: [PATCH] Uninstall rule for top level Makefile
Shawn O. Pearce	Re: [PATCH v2] Speed up bash completion loading
git-commits-head:
Linux Kernel Mailing List	cgroups: clean up cgroup_pidlist_find() a bit
Linux Kernel Mailing List	sony-laptop: Add support for extended hotkeys
Linux Kernel Mailing List	IB/core: Add support for masked atomic operations
Linux Kernel Mailing List	V4L/DVB (8939): cx18: fix sparse warnings
Linux Kernel Mailing List	ipv6 mcast: Check address family of gf_group in getsockopt(MS_FILTER).
linux-netdev:
Inaky Perez-Gonzalez	[PATCH 40/40] wimax/i2400m: add CREDITS and MAINTAINERS entries
Karsten Keil	[mISDN PATCH v2 05/19] Reduce stack size in dsp_cmx_send()
linux	Re: 2.6.23-rc8 network problem. Mem leak? ip1000a?
David Miller	Re: tun: Use netif_receive_skb instead of netif_rx
David Miller	Re: [net-next PATCH v2] llc enhancements
freebsd-current:
Matthew Fleming	Re: [RFC] Outline of USB process integration in the kernel taskqueue system
illoai@gmail.com	Re: OT: 2d password
Hartmut Brandt	Re: problem with nss_ldap
Andrew Reilly	Re: FreeBSD's problems as seen by the BSDForen.de community
Max Laier	Re: Upcoming ABI Breakage in RELENG_7