login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
November
»
7
Re: [PATCH] fat: silence warning for 64KB PAGE_SIZE builds
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From: OGAWA Hirofumi
Subject:
Re: [PATCH] fat: silence warning for 64KB PAGE_SIZE builds
Date: Wednesday, November 7, 2007 - 8:02 am
Olof Johansson <olof@lixom.net> writes:
quoted text
> Annoying gcc warning: > > fs/fat/inode.c: In function 'fat_fill_super': > fs/fat/inode.c:1222: warning: comparison is always false due to limited range of data type > > Change it to compare with 4K instead of PAGE_CACHE_SIZE, as suggested > by OGAWA-san. > > > Signed-off-by: Olof Johansson <olof@lixom.net> > > --- > > On Wed, Nov 07, 2007 at 11:39:01PM +0900, OGAWA Hirofumi wrote: >> Olof Johansson <olof@lixom.net> writes: >> >> > logical_sector_size can never be more than 16 bits worth, but switching >> > it to an int silences gcc. It's a sanity check that can never fail with >> > 64KB PAGE_SIZE but it seems like it'd still be useful for other page >> > sizes, so it's worth keeping: > [...] >> >> Please use 4096 instead of allowing it, at least for now. > > Sure. New patch. > > > Thanks, > > -Olof > > diff --git a/fs/fat/inode.c b/fs/fat/inode.c > index 920a576..61e2874 100644 > --- a/fs/fat/inode.c > +++ b/fs/fat/inode.c > @@ -1219,7 +1219,7 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, > le16_to_cpu(get_unaligned((__le16 *)&b->sector_size)); > if (!is_power_of_2(logical_sector_size) > || (logical_sector_size < 512) > - || (PAGE_CACHE_SIZE < logical_sector_size)) { > + || (logical_sector_size > 4096)) { > if (!silent) > printk(KERN_ERR "FAT: bogus logical sector size %u\n", > logical_sector_size);
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> Thanks a lot. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] fat: silence warning for 64KB PAGE_SIZE builds
, Olof Johansson
, (Tue Nov 6, 10:15 pm)
Re: [PATCH] fat: silence warning for 64KB PAGE_SIZE builds
, OGAWA Hirofumi
, (Wed Nov 7, 7:39 am)
Re: [PATCH] fat: silence warning for 64KB PAGE_SIZE builds
, Olof Johansson
, (Wed Nov 7, 8:01 am)
Re: [PATCH] fat: silence warning for 64KB PAGE_SIZE builds
, OGAWA Hirofumi
, (Wed Nov 7, 8:02 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Ingo Molnar
Re: [PATCH 0/3] v2 Make hierarchical RCU less IPI-happy and add more tracing
Jeremy Fitzhardinge
Re: Linux 2.6.28.10 and Linux 2.6.29.6 XEN Guest Support Broken x86_64 in BUILD
Nick Piggin
Re: [patch] CFS (Completely Fair Scheduler), v2
Gary Hade
Re: [PATCH 0/5][RFC] Physical PCI slot objects
Dave Johnson
Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?
linux-netdev
:
Arnd Bergmann
Re: 64-bit net_device_stats
Stephens, Allan
RE: [PATCH]: tipc: Fix oops on send prior to entering networked mode
frank.blaschka
[patch 3/5] [PATCH] qeth: support z/VM VSWITCH Port Isolation
Wu Fengguang
Re: [PATCH] dm9601: handle corrupt mac address
David Miller
Re: [PATCH net-2.6.24] Fix refcounting problem with netif_rx_reschedule()
git
:
Junio C Hamano
Re: [PATCH] [RFC] add Message-ID field to log on git-am operation
Junio C Hamano
Re: Handling large files with GIT
Karl
Re: [ANNOUNCE] pg - A patch porcelain for GIT
Josh Triplett
Re: [RFC][PATCH 00/10] Sparse: Git's "make check" target
Pierre Habouzit
Re: [PATCH] git-daemon: more powerful base-path/user-path settings, using formats.
git-commits-head
:
Linux Kernel Mailing List
MIPS: RBTX4939: Fix IOC pin-enable register updating
Linux Kernel Mailing List
regulator: update email address for Liam Girdwood
Linux Kernel Mailing List
[SCSI] ipr: add message to error table
Linux Kernel Mailing List
powerpc/32: Wire up the trampoline code for kdump
Linux Kernel Mailing List
USB: omap_udc: sync with OMAP tree
openbsd-misc
:
Josh Grosse
Re: error : pkg add phpMyAdmin
Brian Candler
Re: OBSD's perspective on SELinux
Jacob Meuser
Re: /dev/audio: Device busy
David Vasek
Re: Inexpensive, low power, "wall wart" computer
William Boshuck
Re: Richard Stallman...
Colocation donated by:
Syndicate