login
Header Space

 
 

Re: UML defconfig building failed again

Previous thread: [PATCH] init: Introduce rootdir bootparm to select which dir to sys_chroot by Al Boldi on Tuesday, November 6, 2007 - 6:40 am. (7 messages)

Next thread: [PATCH] smbfs: fix calculation of kernel_recvmsg size parameter in smb_receive by Jeff Layton on Tuesday, November 6, 2007 - 8:12 am. (1 message)
To: LKML <linux-kernel@...>
Cc: <jdike@...>, <user-mode-linux-devel@...>
Date: Tuesday, November 6, 2007 - 7:46 am

Hi, Jeff!

I used today's linus-tree and defconfig to compile uml, but it failed. Error messages are
things like:

In file included from include/asm/processor-generic.h:13,
                 from include/asm/processor.h:77,
                 from include/asm/thread_info.h:11,
                 from include/linux/thread_info.h:21,
                 from include/linux/preempt.h:9,
                 from include/linux/spinlock.h:49,
                 from include/linux/seqlock.h:29,
                 from include/linux/time.h:8,
                 from include/linux/timex.h:57,
                 from include/linux/sched.h:53,
                 from arch/um/include/sysdep/kernel-offsets.h:2,
                 from arch/um/kernel/asm-offsets.c:1:
include/asm/ptrace.h:50: warning: ‘struct user_fxsr_struct’ declared inside parameter list
include/asm/ptrace.h:50: warning: its scope is only this definition or declaration, which is probably not what you want
include/asm/ptrace.h:52: warning: ‘struct user_fxsr_struct’ declared inside parameter list
In file included from include/linux/timer.h:5,
                 from include/linux/sched.h:87,
                 from arch/um/include/sysdep/kernel-offsets.h:2,
                 from arch/um/kernel/asm-offsets.c:1:
include/linux/ktime.h: In function ‘ktime_set’:
include/linux/ktime.h:84: warning: comparison is always false due to limited range of data type

{snip}

It seems like CONFIG_X86_32 was not set. Any ideas?

Thanks.


-
To: WANG Cong <xiyou.wangcong@...>
Cc: LKML <linux-kernel@...>, <jdike@...>, <user-mode-linux-devel@...>
Date: Tuesday, November 6, 2007 - 10:11 am

Sigh...  Kbuild breakage this time...  See if %s/\&lt;[AC]FLAGS\&gt;/KBUILD_&amp;/g
in arch/um/Makefile-i386 helps.
-
To: Al Viro <viro@...>
Cc: WANG Cong <xiyou.wangcong@...>, LKML <linux-kernel@...>, <jdike@...>, <user-mode-linux-devel@...>
Date: Tuesday, November 6, 2007 - 12:07 pm

Ups - my bad.
I have somehow overlooked those two assignments in the middle.

	Sam
-
To: Al Viro <viro@...>, Sam Ravnborg <sam@...>, Linus Torvalds <torvalds@...>
Cc: WANG Cong <xiyou.wangcong@...>, LKML <linux-kernel@...>, <jdike@...>, <user-mode-linux-devel@...>
Date: Tuesday, November 6, 2007 - 12:02 pm

Yup, this fixes it:


     [AC]FLAGS -&gt; KBUILD_[AC]FLAGS conversion in Makefile-i386.

Signed-off-by: Jeff Dike &lt;jdike@linux.intel.com&gt;
---
 arch/um/Makefile-i386 |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/um/Makefile-i386 b/arch/um/Makefile-i386
index b01dfb0..6729011 100644
--- a/arch/um/Makefile-i386
+++ b/arch/um/Makefile-i386
@@ -22,8 +22,8 @@ export LDFLAGS HOSTCFLAGS HOSTLDFLAGS UML_OBJCOPYFLAGS
 endif
 endif
 
-CFLAGS			+= -DCONFIG_X86_32
-AFLAGS			+= -DCONFIG_X86_32
+KBUILD_CFLAGS		+= -DCONFIG_X86_32
+KBUILD_AFLAGS		+= -DCONFIG_X86_32
 CONFIG_X86_32		:= y
 export CONFIG_X86_32

-
Previous thread: [PATCH] init: Introduce rootdir bootparm to select which dir to sys_chroot by Al Boldi on Tuesday, November 6, 2007 - 6:40 am. (7 messages)

Next thread: [PATCH] smbfs: fix calculation of kernel_recvmsg size parameter in smb_receive by Jeff Layton on Tuesday, November 6, 2007 - 8:12 am. (1 message)
speck-geostationary