Home » Mailing list archives » linux-kernel » 2007 » November » 6

Re: [PATCH 1/5] Small ACPICA extension to be able to store the name of operation regions in osl.c later

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andrew Morton <akpm@...>
To: <trenn@...>
Cc: linux-acpi <linux-acpi@...>, linux-kernel <linux-kernel@...>, Len Brown <lenb@...>, Jean Delvare <khali@...>
Subject: Re: [PATCH 1/5] Small ACPICA extension to be able to store the name of operation regions in osl.c later
Date: Tuesday, November 6, 2007 - 2:58 am

this patch introduces a compile error:

drivers/acpi/osl.c:1203: error: conflicting types for 'acpi_os_validate_address'
include/acpi/acpiosxf.h:243: error: previous declaration of 'acpi_os_validate_address' was here

which the next patch fixes.  This breaks git-bisection and will cause great
gnashing of teeth to those who hit it.

Also, please fix this:

drivers/acpi/osl.c: In function 'acpi_os_validate_address':
drivers/acpi/osl.c:1365: warning: format '%llx' expects type 'long long unsigned int', but argument 4 has type 'long unsigned int'
drivers/acpi/osl.c:1365: warning: format '%s' expects type 'char *', but argument 5 has type 'long unsigned int'

it's all covered in Documentation/SubmitChecklist but it seems that
file was write-only.

<goes back to fixing build errors>
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/5] Small ACPICA extension to be able to store the n..., Thomas Renninger, (Wed Oct 24, 10:32 am)
Re: [PATCH 1/5] Small ACPICA extension to be able to store t..., Andrew Morton, (Tue Nov 6, 2:58 am)