linux-kernel mailing list

FromSubjectsort iconDate
Mauro Carvalho Chehab
[GIT PATCHES] V4L/DVB fixes
Linus, Please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git master For the following: - Some Kconfig fixes; - Updates missing entries at CARDLIST.em28xx; - Several driver fixes at bttv, cafe_ccic, s5h1409, mt2131, saa7134, planb, saa7146, ves1820, tda10021, stv0297, pvrusb2, em28xx, tvp5150. Cheers, Mauro. --- Documentation/video4linux/CARDLIST.em28xx | 3 + drivers/media/Kconfig | 1 + drivers/media...
Nov 4, 7:18 pm 2007
Mathieu Desnoyers
[to-be-posted-soon] Multiple handlers per marker
It's ready for testing. Please grab http://ltt.polymtl.ca/lttng/patch-2.6.24-rc1-git13-lttng-0.10-pre18.tar.bz2 patch name : markers-support-multiple-probes.patch It still need to go through patchcheck.pl and some polishing, but it seems to work fine for me with multiple probes (the sample marker, sample probe and multiple instances of my lttng probes can connect/disconnect without problem). Currently, the "connect/disconnect" and "arm/disarm" operations are separate. However, they could be...
Nov 4, 7:24 pm 2007
Linus Torvalds
Re: [GIT PULL] x86 setup: correct booting on 486DX4
Hmm. I'm not sure I agree with the commit message. This is documented behaviour on i386 and i486: instruction decoding is decoupled from execution, so things that change processor mode have to do a jump to make sure that %cr0 changes take effect. I'm not entirely sure that it needs to be a long-jump, btw. I think any regular branch is sufficient. You obviously *do* need to make the long jump later (to reload %cs in protected mode), but I'm not sure it's needed in that place. I forget th...
Nov 4, 7:17 pm 2007
H. Peter Anvin
Re: [GIT PULL] x86 setup: correct booting on 486DX4
It's not an instruction-decoding issue at all (that's a 16- vs 32-bit issue, which can only be changed by a ljmp). Apparently the 486DX4 mis-executes the load to segment register, which is an EU function in that context. (And yes, it's sort-of-documented behaviour in the sense that the documentation says "do things this way", but the Intel docs are unfortunately full of "do things this way" which don't make sense and That's exactly the issue here. The code without this patch deferred the ...
Nov 4, 7:26 pm 2007
Linus Torvalds
Re: [GIT PULL] x86 setup: correct booting on 486DX4
I still disagree. I took out "Programming the 80386" just to check, and the documentation very clearly states that when changing the CR0 bits (I quote): "The program must execute a jump instruction immediately after changing the value of the PE bit in order to flush the execution pipeline of any instructions that may have been fetched in the wrong mode. [...]" In other words, not only is this documented since day 1, it makes total sense, and they even said exactöy *why* that...
Nov 4, 7:59 pm 2007
Jeremy Fitzhardinge
Re: [GIT PULL] x86 setup: correct booting on 486DX4
Yes, it says it needs to be a far jmp or call (and if you enabled paging in the cr0 load, you need to identity-map the branch target). Having successfully broken the rules for a long time so far, maybe we can get away with still cutting corners... but it doesn't seem particularly worthwhile since we've been caught once. J -
Nov 4, 7:27 pm 2007
Linus Torvalds
Re: [GIT PULL] x86 setup: correct booting on 486DX4
Hmm. The original Linux code did movw $1, %ax lmsw %ax jmp flush_instr flush_instr: and I think that was straigh out of the documentation. So yeah, I think that's the right fix - not a longjmp (which in itself is dangerous: it potentially behaves *differently* on different CPU's, since some CPU's may do the long jump with pre-protected-mode semantics, while others will do it with protected mode already in effect!) Linus -
Nov 4, 7:25 pm 2007
H. Peter Anvin
Re: [GIT PULL] x86 setup: correct booting on 486DX4
Just looked it up; it was a bit hard to find (it is Intel vol 3 page 9-27, at least in the version I have), but you're right -- the documentation only demands a short jump here, not a long jmp (which actually makes sense given what I remembered that a long jump should be deferrable here.) So yes, that is definitely the right fix and avoids the ugly mixing of code. I'll update the patch. -hpa -
Nov 4, 7:36 pm 2007
H. Peter Anvin
[GIT PULL] x86 setup: correct booting on 486DX4
Hi Linus; please pull: git://git.kernel.org/pub/scm/linux/kernel/git/hpa/linux-2.6-x86setup.git for-linus H. Peter Anvin (1): x86 setup: correct booting on 486DX4 arch/x86/boot/pmjump.S | 32 +++++++++++++++++++++----------- 1 files changed, 21 insertions(+), 11 deletions(-) [Full diff and log follows] commit ac3b37b78c5f0f0be0b476a35370650f7bad482f Author: H. Peter Anvin <hpa@zytor.com> Date: Sun Nov 4 14:33:41 2007 -0800 x86 setup: correct booting on 486DX4 ...
Nov 4, 6:57 pm 2007
Michael Buesch Nov 4, 7:36 pm 2007
Nigel Cunningham
PID namespaces break initrd+hibernate combination?
Hi all. Please excuse me if this has already been answered. I'm not currently subscribed to LKML. I've just been preparing a new tux-on-ice release against Linus' current tree, and encountered a failure to freeze pid 1 when seeking to resume, using an initrd: [ 74.192734] Freezing of tasks failed after 19.99 seconds (1 tasks refusing to freeze): [ 74.193502] task PC stack pid father [ 74.193504] swapper S ffff810002023030 4968 1 0 [ 74.193512] ...
Nov 4, 6:36 pm 2007
Rafael J. Wysocki
Re: PID namespaces break initrd+hibernate combination?
Not known to me and I haven't tried the PID namespaces yet. Greetings, Rafael -
Nov 4, 7:45 pm 2007
OGAWA Hirofumi
[PATCH 2/2] fat: optimize fat_count_free_clusters()
On large partition, scanning the free clusters is very slow if users doesn't use "usefree" option. For optimizing it, this patch uses sb_breadahead() to read of FAT sectors. On some user's 15GB partition, this patch improved it very much (1min => 600ms). The following is the result of 2GB partition on my machine. without patch: root@devron (/)# time df -h > /dev/null real 0m1.202s user 0m0.000s sys 0m0.440s with patch: root@devron (/)# time df -h > /dev/null ...
Nov 4, 6:09 pm 2007
OGAWA Hirofumi
[PATCH 1/2] FAT: Fix printk format strings.
From: Vegard Nossum <vegard.nossum@gmail.com> This makes sure printk format strings contain no more than a single line. Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com> [the message was tweaked.] Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> --- fs/fat/inode.c | 6 ++---- fs/fat/misc.c | 5 ++--- 2 files changed, 4 insertions(+), 7 deletions(-) diff -puN fs/fat/inode.c~fat_fix-printk-format-str fs/fat/inode.c --- linux-2.6/fs/fat/inode.c~fat_f...
Nov 4, 6:08 pm 2007
Felipe Dias Nov 4, 6:05 pm 2007
Jiri Slaby
Re: textsearch in module = BUG: scheduling while atomic
Seems like it is not inteded for using in atomic at all (you probably passed an unknown algo here to the prepare function). You seem to have to use a workqueue if it is possible or prepare the serach before the interrupt occurs. Post your regards, -- Jiri Slaby (jirislaby@gmail.com) Faculty of Informatics, Masaryk University -
Nov 4, 6:16 pm 2007
Jiri Slaby
Re: textsearch in module = BUG: scheduling while atomic
Or pass 0 instead of TS_AUTOLOAD. -
Nov 4, 6:19 pm 2007
Felipe Dias
Re: textsearch in module = BUG: scheduling while atomic
I change the algo, from "bm" to "kmp" and probably resolve. I will make more tests and if error occour i post latter... Thanks so much. Felipe Dias -
Nov 4, 6:57 pm 2007
Mikael Pettersson
Re: [PATCH] fix i486 boot failure due to stale %ds
Maybe not. I had a look in Intel's SDM Vol3, and the section "switching to protected mode" specifies that a move to %cr0 that sets PE should immediately be followed by a far jmp or call. They write that "random failures can occur if other instructions exist between [the move to %cr0] and [the far jmp/call]". The current version of pmjump.S does exactly that: it executes a bunch of moves to segment registers in that window. (Section 9.9.1 in the Sept. 2005 revision I have in front of me.) Sim...
Nov 4, 5:58 pm 2007
Jeremy Fitzhardinge
Re: [PATCH] fix i486 boot failure due to stale %ds
Yes, that's what the spec says. I queried this a few months ago, but hpa used his convincing voice and said that in practice it isn't necessary; there are no known cpus which need this, and any that do would cause other things to break. But I guess now we have the counter-example... J -
Nov 4, 7:07 pm 2007
H. Peter Anvin
Re: [PATCH] fix i486 boot failure due to stale %ds
Mikael, can you try this patch (rev 3) on your 486? -hpa
Nov 4, 7:51 pm 2007
H. Peter Anvin
Re: [PATCH] fix i486 boot failure due to stale %ds
Joy. Apparently the Intel documentation is actually self-inconsistent. Section 9.9.1, page 9-17 does indeed have the "far jump or call" injunction, whereas the sample code in section 9.10.1, page 9-27, line 180 does a near jump! -hpa -
Nov 4, 7:50 pm 2007
H. Peter Anvin
Re: [PATCH] fix i486 boot failure due to stale %ds
Yup. I owe you a beverage :) -hpa -
Nov 4, 7:12 pm 2007
Andi Kleen
Re: [PATCH] fix i486 boot failure due to stale %ds
iirc various Intel VT hypervisor implementations also have trouble with not following this restriction. At least in the early Xen days it was a frequent reason for boot failure. -Andi -
Nov 4, 7:05 pm 2007
H. Peter Anvin
Re: [PATCH] fix i486 boot failure due to stale %ds
The problem is that Intel has a tendency to exaggerate in their documentation; in particular, they tend not to remove restrictions that are long-since obsolete. However, it sounds like you have actually found a CPU for which this restriction is motivated. -hpa -
Nov 4, 6:20 pm 2007
Neil Brown
Re: 2.6.23.1: mdadm/raid5 hung/d-state
At a guess (I haven't looked closely) I'd say it is the bug that was meant to be fixed by commit 4ae3f847e49e3787eca91bced31f8fd328d50496 except that patch applied badly and needed to be fixed with the following patch (not in git yet). These have been sent to stable@ and should be in the queue for 2.6.23.2 NeilBrown Fix misapplied patch in raid5.c commit 4ae3f847e49e3787eca91bced31f8fd328d50496 did not get applied correctly, presumably due to substantial similarities between handle_s...
Nov 4, 5:49 pm 2007
Justin Piszcz
Re: 2.6.23.1: mdadm/raid5 hung/d-state
Ah, thanks Neil, will be updating as soon as it is released, thanks. Justin. -
Nov 4, 5:51 pm 2007
Evgeniy Dushistov
[PATCH] 82596: free nonexistent resource fix
During booting of last vanilla kernel I got: Trying to free nonexistent resource... This because of if "ENABLE_APRICOT" is on we do: request_region(ioaddr,...) if (checksum test failed) goto out1; dev->base_addr = ioaddr;//<-here mistake out1: release_region(dev->base_addr,...) Here patch which fixes this bug for me. Signed-off-by: Evgeniy Dushistov <dushistov@mail.ru> --- diff --git a/drivers/net/82596.c b/drivers/net/82596.c index bb30d5b..2797da7 100644 --- a/dr...
Nov 4, 4:22 pm 2007
Norbert Preining
SATA eating my disk, port reset, destroying unrelated data
Dear all! (please Cc me for answers) Since about 5 days I am having serious problems with my SATA drive: kernel 2.6.22 (from Debian/sid) hardware nv Sometimes at boot time, often/always at disk io intense stuff: ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x400000 action 0x2 ata1.00: (BMDMA stat 0x25) ata1.00: cmd 35/00:00:2a:6f:c0/00:04:0c:00:00/e0 tag 0 cdb 0x0 data 524288 out res 51/84:10:1a:72:c0/84:01:0c:00:00/e0 Emask 0x10 (ATA bus error) ata1: soft resetting port ata1: SA...
Nov 4, 4:58 pm 2007
Don Porter Nov 4, 3:52 pm 2007
Randy Dunlap
[PATCH] Makefile: add 'includecheck' help text
From: Randy Dunlap <randy.dunlap@oracle.com> Add 'includecheck' to the Static analyzers help list. Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- Makefile | 1 + 1 file changed, 1 insertion(+) --- linux-2.6.24-rc1-git13.orig/Makefile +++ linux-2.6.24-rc1-git13/Makefile @@ -1169,6 +1169,7 @@ help: @echo 'Static analysers' @echo ' checkstack - Generate a list of stack hogs' @echo ' namespacecheck - Name space analysis on compiled kernel' + @echo '...
Nov 4, 4:01 pm 2007
Sam Ravnborg Nov 4, 6:27 pm 2007
Marco Costalba
Re: duplicated include files
make includecheck does not work for me. Linux tree is from latest git. bash-3.2$ pwd /git/linux-2.6 bash-3.2$ make includecheck find * \( -name SCCS -o -name BitKeeper -o -name .svn -o -name CVS -o -name .pc -o -name .hg -o -name .git \) -prune -o \ -name '*.[hcS]' -type f -print | sort \ | xargs perl -w scripts/checkincludes.pl Can't open perl script "scripts/checkincludes.pl": No such file or directory make[1]: *** [includecheck] Error 123 make: *** [sub-make]...
Nov 4, 3:41 pm 2007
Marco Costalba
Re: duplicated include files
BTW what's that 'BitKeeper' fossil here? -
Nov 4, 3:43 pm 2007
Randy Dunlap
Re: duplicated include files
It allows people to continue using any of {CVS, SVN, BitKeeper} for their kernel tree. The BK kernel tree is still being updated AFAIK. (It was last time I looked, about 3 weeks ago.) --- ~Randy -
Nov 4, 3:51 pm 2007
Robert P. J. Day
Re: duplicated include files
actually, one wonders if there's any value in keeping any references to other version control systems such as subversion, SCCS, CVS, mercurial, etc. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca ======================================================================== -
Nov 4, 3:49 pm 2007
Bernd Petrovitsch
Re: duplicated include files
On Sun, 2007-11-04 at 14:49 -0500, Robert P. J. Day wrote: Lots of people have their working trees in CVS, Subversion, .... So it probably annoys them and doesn't really buy anything IMHO. Bernd -- Firmix Software GmbH http://www.firmix.at/ mobil: +43 664 4416156 fax: +43 1 7890849-55 Embedded Linux Development and Services -
Nov 4, 7:43 pm 2007
Jeremy Fitzhardinge
Re: duplicated include files
What do you mean by "other"? git doesn't have a monopoly, and the kernel should support people using a reasonable set of version control systems. Supporting VSS would be strange, but nothing wrong with the set you listed, if people find those systems useful. It's not like it amounts to a huge amount of effort to do so. J -
Nov 4, 7:20 pm 2007
Mikael Pettersson
Re: [PATCH] fix i486 boot failure due to stale %ds
Sure. It's a 100Mhz Intel 486 DX4: processor : 0 vendor_id : GenuineIntel cpu family : 4 model : 8 model name : 486 DX/4 stepping : 0 cache size : 0 KB fdiv_bug : no hlt_bug : no f00f_bug : no coma_bug : no fpu : yes fpu_exception : yes cpuid level : 1 wp : yes flags : fpu vme bogomips : 49.66 First patch didn't build. Second patch builds and boots Ok. So this means the 486 DX4 has a buggy mov to %cr0? /Mikael -
Nov 4, 3:38 pm 2007
H. Peter Anvin Nov 4, 3:41 pm 2007
Samuel Tardieu
[PATCH] watchdog: Stop looking for device as soon as one is ...
If no address is given for the W83697HF/HG watchdog IO port, stop looping through possible locations when a watchdog device has been found. Signed-off-by: Samuel Tardieu <sam@rfc1149.net> --- drivers/watchdog/w83697hf_wdt.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/watchdog/w83697hf_wdt.c b/drivers/watchdog/w83697hf_wdt.c index c622a0e..6ea125e 100644 --- a/drivers/watchdog/w83697hf_wdt.c +++ b/drivers/watchdog/w83697hf_wdt.c @@ -382,8 +382,10 @@...
Nov 4, 3:20 pm 2007
Marco Costalba
List of possible duplicated include files in include/
Here the number of false positives is overhelming, but perhaps there are also _real_ duplicated include somewhere in the bunch: include/acpi/acpi_bus.h: #include <linux/device.h> include/asm-alpha/core_cia.h: #include <asm/io_trivial.h> include/asm-arm/atomic.h: #include <asm/system.h> include/asm-arm/arch-clps711x/hardware.h: #include <asm/hardware/ep7212.h> include/asm-arm/arch-clps711x/hardware.h: #include <asm/hardware/clps7111.h> include/asm-arm/arc...
Nov 4, 2:44 pm 2007
Robert P. J. Day
Re: List of possible duplicated include files in include/
... snip header file output ... i deliberately left out header files from my script output. i can tweak the script and add this to the web page as well. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca ======================================================================== -
Nov 4, 2:48 pm 2007
Marco Costalba
Re: List of possible duplicated include files in include/
Here the real job is to fliter out false positives more then print out the list I would say ;-) Marco -
Nov 4, 2:52 pm 2007
Robert P. J. Day
Re: List of possible duplicated include files in include/
i don't think there are a lot of false positives there and, in any event, it's a case of diminishing returns -- if you can get most of what you want with two minutes of quick-and-dirty scripting, there's not much point in spending another 10 or 15 minutes trying to tidy things up only a little. just my $0.02 canadian, which is finally worth more than $0.02 american. :-) rday -- ======================================================================== Robert P. J. Day Linux Consulting, ...
Nov 4, 3:01 pm 2007
Oleg Nesterov
[PATCH] cfq: fix IOPRIO_CLASS_IDLE accounting
(untested, needs an ack from maintainer) Spotted by Nick <gentuu@gmail.com>, hopefully can explain the second trace in http://bugzilla.kernel.org/show_bug.cgi?id=9180. If ->async_idle_cfqq != NULL cfq_put_async_queues() puts it IOPRIO_BE_NR times in a loop. Fix this. Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> --- cfq/block/cfq-iosched.c~ 2007-08-09 19:59:26.000000000 +0400 +++ cfq/block/cfq-iosched.c 2007-11-04 22:23:42.000000000 +0300 @@ -2065,9 +2065,10 @@ static void cf...
Nov 4, 3:32 pm 2007
Sam Ravnborg
[GIT PULL] kbuild: do not pick up CFLAGS from the environment
Hi Linus. Please apply following fix. Pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/sam/fix-kbuild.git Sam From 69ee0b3522428a07ff1765446d631ecc7da6ae0f Mon Sep 17 00:00:00 2001 From: Sam Ravnborg <sam@ravnborg.org> Date: Sun, 4 Nov 2007 19:00:46 +0100 Subject: [PATCH] kbuild: do not pick up CFLAGS from the environment MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Too many people have CFLAGS set to support building ...
Nov 4, 2:24 pm 2007
Robert P. J. Day
duplicated include files
given the recent patches to remove duplicated #include preprocessor directives in source files, let it be known that there are a number of them: http://www.crashcourse.ca/wiki/index.php/Duplicate_include_files help yourself. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca ==========================================================...
Nov 4, 1:31 pm 2007
Randy Dunlap
Re: duplicated include files
Could you make the tool (script?) available also, please? --- ~Randy -
Nov 4, 2:07 pm 2007
Robert P. J. Day
Re: duplicated include files
trust me, it's not a script i'm particularly proud of: =========================== #!/bin/sh DIR=${1-*} # by default, all directories for cf in $(find ${DIR} -name *.c) ; do echo ${cf} grep "#include" $cf | sort | uniq -c | grep -v 1 done | grep -B1 "#include" | grep -v -- "--" =========================== on the bright side, it took about 90 seconds to write, but i won't be winning any awards for style. i'll add it to the web page. rday -- ======...
Nov 4, 2:37 pm 2007
previous daytodaynext day
November 3, 2007November 4, 2007November 5, 2007