Re: List of possible duplicated include files in include/

Previous thread: [PATCH] cfq: fix IOPRIO_CLASS_IDLE accounting by Oleg Nesterov on Sunday, November 4, 2007 - 12:32 pm. (2 messages)

Next thread: [PATCH] watchdog: Stop looking for device as soon as one is found by Samuel Tardieu on Sunday, November 4, 2007 - 12:20 pm. (1 message)
From: Marco Costalba
Date: Sunday, November 4, 2007 - 11:44 am

Here the number of false positives is overhelming, but perhaps there
are also _real_ duplicated include somewhere in the bunch:

include/acpi/acpi_bus.h:
#include <linux/device.h>

include/asm-alpha/core_cia.h:
#include <asm/io_trivial.h>

include/asm-arm/atomic.h:
#include <asm/system.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/ep7212.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/clps7111.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/ep7212.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/cs89712.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/clps7111.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/ep7212.h>

include/asm-ia64/pgtable.h:
#include <asm/processor.h>

include/asm-m32r/m32r.h:
#include <asm/m32700ut/m32700ut_pld.h>

include/asm-mips/bitops.h:
#include <asm-generic/bitops/fls64.h>

include/asm-mips/tx4938/tx4938.h:
#include <asm/byteorder.h>

include/asm-powerpc/io.h:
#include <asm/io-defs.h>

include/asm-x86/elf.h:
#include <asm/processor.h>

include/asm-x86/msr.h:
#include <linux/errno.h>

include/asm-x86/smp_64.h:
#include <asm/thread_info.h>

include/linux/aio.h:
#include <linux/uio.h>

include/linux/aio.h:
#include <linux/aio_abi.h>

include/linux/atalk.h:
#include <asm/byteorder.h>

include/linux/cgroup.h:
#include <linux/cgroup_subsys.h>

include/linux/icmpv6.h:
#include <linux/skbuff.h>

include/linux/igmp.h:
#include <linux/skbuff.h>

include/linux/udp.h:
#include <linux/types.h>

include/net/ieee80211.h:
#include <linux/wireless.h>
-

From: Robert P. J. Day
Date: Sunday, November 4, 2007 - 11:48 am

... snip header file output ...

i deliberately left out header files from my script output.  i can
tweak the script and add this to the web page as well.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================
-

From: Marco Costalba
Date: Sunday, November 4, 2007 - 11:52 am

Here the real job is to fliter out false positives more then print out
the list I would say ;-)

Marco
-

From: Robert P. J. Day
Date: Sunday, November 4, 2007 - 12:01 pm

i don't think there are a lot of false positives there and, in any
event, it's a case of diminishing returns -- if you can get most of
what you want with two minutes of quick-and-dirty scripting, there's
not much point in spending another 10 or 15 minutes trying to tidy
things up only a little.

  just my $0.02 canadian, which is finally worth more than $0.02
american.  :-)

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================
-

Previous thread: [PATCH] cfq: fix IOPRIO_CLASS_IDLE accounting by Oleg Nesterov on Sunday, November 4, 2007 - 12:32 pm. (2 messages)

Next thread: [PATCH] watchdog: Stop looking for device as soon as one is found by Samuel Tardieu on Sunday, November 4, 2007 - 12:20 pm. (1 message)