Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Arnd Bergmann
Date: Thursday, November 29, 2007 - 3:21 am

On Thursday 29 November 2007, Andi Kleen wrote:

Part of your sentence seems to be missing, but I guess I understand your
point. How many files did you annotate this way? I can see it as being
useful to have the namespace explicit in each symbol, but doing it once
per module sounds like the 80% solution for 20% of the work, and the
two don't even conflict. In the current kernel, I count 12644 exported
symbols in 1646 files, in 540 directories.

One problem I can see with annotating every symbol is that it conflicts
with other patches that add more exported functions to a file without
adding the namespace, or that simply break because of context changes.

	Arnd <><
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH RFC] [8/9] Put UDP exports into a namespace, Andi Kleen, (Wed Nov 21, 7:43 pm)
[PATCH RFC] [9/9] Add a inet namespace, Andi Kleen, (Wed Nov 21, 7:43 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code a ..., Christoph Hellwig, (Thu Nov 22, 4:06 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code a ..., Arnaldo Carvalho de Melo, (Thu Nov 22, 5:01 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code a ..., Christoph Hellwig, (Thu Nov 22, 5:03 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code a ..., Stephen Hemminger, (Mon Nov 26, 11:25 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code a ..., Christoph Hellwig, (Tue Nov 27, 9:33 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code a ..., Stephen Hemminger, (Tue Nov 27, 4:00 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code a ..., Arnd Bergmann, (Thu Nov 29, 3:21 am)
Re: [PATCH RFC] [4/9] modpost: Fix format string warnings, Sam Ravnborg, (Mon Dec 10, 11:50 am)