Re: RTC wakealarm write-only, still has 644 permissions

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: David Brownell <david-b@...>
Cc: <rtc-linux@...>, kernel list <linux-kernel@...>, Alessandro Zummo <alessandro.zummo@...>
Date: Wednesday, November 28, 2007 - 7:26 pm

Hi!

Sorry for long delay. I got rtc wakeup to work... once per boot. On
2.6.24-rc3.



Oops. Ok, this is thinkpad x60, if that helps.


I see... so situation is not nice :-(.


Alessandro?


Good. that actually works.


Thanks. Will put it into Doc*/rtc.txt.


It seems to be working now, not sure what changed.

rtc-sysfs.c: why this?

        if (alarm > now) {
                /* Avoid accidentally clobbering active alarms; we
can't
                 * entirely prevent that here, without even the
minimal
                 * locking from the /dev/rtcN api.
                 */
                retval = rtc_read_alarm(rtc, &alm);
                if (retval < 0)
                        return retval;
                if (alm.enabled)
                        return -EBUSY;

                alm.enabled = 1;

People should not be "accidentally" writing to sysfs files...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
RTC wakealarm write-only, still has 644 permissions, Pavel Machek, (Thu Sep 20, 6:32 am)
Re: RTC wakealarm write-only, still has 644 permissions, Pavel Machek, (Thu Sep 20, 6:50 am)
Re: RTC wakealarm write-only, still has 644 permissions, David Brownell, (Sat Sep 22, 1:38 am)
Re: RTC wakealarm write-only, still has 644 permissions, Pavel Machek, (Wed Nov 28, 7:26 pm)
Re: RTC wakealarm write-only, still has 644 permissions, David Brownell, (Thu Nov 29, 2:10 pm)
Re: RTC wakealarm write-only, still has 644 permissions, Pavel Machek, (Fri Nov 30, 4:35 pm)
Re: RTC wakealarm write-only, still has 644 permissions, David Brownell, (Fri Nov 30, 5:10 pm)
Re: RTC wakealarm write-only, still has 644 permissions, David Brownell, (Sun Dec 2, 12:03 pm)
Re: RTC wakealarm write-only, still has 644 permissions, Pavel Machek, (Fri Nov 30, 5:27 pm)
Re: RTC wakealarm write-only, still has 644 permissions, Alessandro Zummo, (Thu Nov 29, 2:14 pm)
Re: RTC wakealarm write-only, still has 644 permissions, David Brownell, (Tue Oct 2, 10:15 pm)