linux-kernel mailing list

FromSubjectsort iconDate
Jeremy Fitzhardinge
[PATCH 1/3] x86: partial unification of asm-x86/bitops.h
This unifies the set/clear/test bit functions of asm/bitops.h. I have not attempted to merge the bit-finding functions, since they rely on the machine word size and can't be easily restructured to work generically without a lot of #ifdefs. In particular, the 64-bit code can assume the presence of conditional move instructions, whereas 32-bit needs to be more careful. The inline assembly for the bit operations has been changed to remove explicit sizing hints on the instructions, so the assembler ...
Nov 27, 7:01 pm 2007
Hiroshi Shimamoto
[PATCH] x86: clean up process_32/64.c
White space and coding style clean up. Make process_32/64.c similar. Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> --- arch/x86/kernel/process_32.c | 20 ++-- arch/x86/kernel/process_64.c | 307 +++++++++++++++++++++--------------------- 2 files changed, 163 insertions(+), 164 deletions(-) diff --git a/arch/x86/kernel/process_32.c b/arch/x86/kernel/process_32.c index a20de7f..bd707db 100644 --- a/arch/x86/kernel/process_32.c +++ b/arch/x86/kernel/process_32.c @@ -133,...
Nov 27, 7:49 pm 2007
Jeremy Fitzhardinge
[PATCH 2/3] x86: clean up bitops-related warnings
Add casts to appropriate places to silence spurious bitops warnings. Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com> Cc: Andi Kleen <ak@suse.de> --- arch/x86/kernel/setup_64.c | 31 ++++++++++++++++--------------- arch/x86/kernel/smpboot_64.c | 4 ++-- arch/x86/mm/numa_64.c | 2 +- include/asm-x86/cpufeature.h | 2 +- include/asm-x86/numa_64.h | 2 +- include/linux/thread_info.h | 10 +++++----- 6 files changed, 26 insertions(+), 25 deletions...
Nov 27, 7:01 pm 2007
Andi Kleen
Re: [PATCH 2/3] x86: clean up bitops-related warnings
Looks a bit ugly. Perhaps it would be better to define standard wrappers clear_bit_unaligned/any/bettername() etc. ? -Andi -
Nov 27, 7:17 pm 2007
Jeremy Fitzhardinge
Re: [PATCH 2/3] x86: clean up bitops-related warnings
Well, most of the casts are already in wrapper functions. The setup_64.c ones are ugly, but the following patch cleans them up. J -
Nov 27, 7:32 pm 2007
Jeremy Fitzhardinge
[PATCH 3/3] x86: add set/clear_cpu_cap operations
The patch to suppress bitops-related warnings added a pile of ugly casts. Many of these were related to the management of x86 CPU capabilities. Clean these up by adding specific set/clear_cpu_cap macros, and use them consistently. Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com> Cc: Andi Kleen <ak@suse.de> --- arch/x86/kernel/alternative.c | 13 ++++++------ arch/x86/kernel/apic_32.c | 8 +++---- arch/x86/kernel/apic_64.c ...
Nov 27, 7:01 pm 2007
mark gross
[mgross@linux.intel.com: intel-iommu-PMEN-think-oh patch.]
I forgot to cc the list. --mgross ----- Forwarded message from mark gross <mgross@linux.intel.com> ----- Date: Tue, 27 Nov 2007 15:46:09 -0800 From: mark gross <mgross@linux.intel.com> To: Andrew Morton <akpm@linux-foundation.org> Reply-To: mgross@linux.intel.com Subject: intel-iommu-PMEN-think-oh patch. I screwed up with my earlier patch to enable the portected memroy. The macro IOMMU_WAIT, exits when the condition goes true. Without this patch the code will hang at bo...
Nov 27, 7:48 pm 2007
Greg KH
[RFC] New kobject/kset/ktype documentation and example code
Right now I have about 80+ patches reworking the kset/ktype mess in the -mm tree, cleaning things up and hopefully making it all easier for people to both use, and understand. So, while it is all relativly fresh in my mind, I thought it would be good to also document the whole mess, and provide some solid example code for others to use in the future. Jonathan, I used your old lwn.net article about kobjects as the basis for this document, I hope you don't mind (if you do, I'll be glad to start ov...
Nov 27, 7:02 pm 2007
Frans Pop
Re: [RFC] New kobject/kset/ktype documentation and example c...
^^^ Wow, that's impressive: both kobjects de-mystified and time travel made possible! ;-) -
Nov 27, 7:21 pm 2007
Kyle McMartin Nov 27, 7:10 pm 2007
Greg KH
Re: [RFC] New kobject/kset/ktype documentation and example c...
/me goes off to recharge the flux generator... Heh, thanks, I'll go fix that. greg k-h -
Nov 27, 7:29 pm 2007
Greg KH
[RFC] Sample kset/ktype/kobject implementation
/* * Sample kset and ktype implementation * * Copyright (C) 2004-2007 Greg Kroah-Hartman <greg@kroah.com> * Copyright (C) 2007 Novell Inc. * * Released under the GPL version 2 only. * */ #include <linux/kobject.h> #include <linux/string.h> #include <linux/sysfs.h> #include <linux/module.h> #include <linux/init.h> /* * This module shows how to create a kset in sysfs called * /sys/kernel/kset-example * Then tree kobjects are created and assigne...
Nov 27, 7:04 pm 2007
Greg KH
[RFC] sample kobject implementation
/* * Sample kobject implementation * * Copyright (C) 2004-2007 Greg Kroah-Hartman <greg@kroah.com> * Copyright (C) 2007 Novell Inc. * * Released under the GPL version 2 only. * */ #include <linux/kobject.h> #include <linux/string.h> #include <linux/sysfs.h> #include <linux/module.h> #include <linux/init.h> /* * This module shows how to create a simple subdirectory in sysfs called * /sys/kernel/kobject-example In that directory, 3 files are c...
Nov 27, 7:03 pm 2007
Jeremy Fitzhardinge
[PATCH] x86/paravirt: revert exports to restore old behaviour
Subdividing the paravirt_ops structure caused a regression in certain non-GPL modules which try to use mmu_ops and cpu_ops. This restores the old behaviour, and makes it consistent with the non-CONFIG_PARAVIRT case. Christoph Hellwig objects to this patch on the grounds that modules shouldn't be using these operations anyway. I don't think this is a particularly good reason to reject the patch, for several reasons: 1. These operations are still available to modules when not using CONFIG...
Nov 27, 6:57 pm 2007
Tilman Schmidt
git guidance
So I've watched Linus' Google Tech Talk about git and let him convince me that I've been stupid to use CVS, that Subversion is even worse, and the only sensible approach is to use git. Went ahead and tried to convert my driver development to git. It didn't work too well. The first result was one of maximal embarrassment: I produced a patch that didn't even compile when applied to the official tree. This shouldn't happen with git, right? Well, it did. So now I'm back to keeping a virgin kernel sourc...
Nov 27, 6:33 pm 2007
Jan Engelhardt Nov 27, 7:20 pm 2007
Kristoffer Ericson
Re: git guidance
Greetings, Google is your friend. If you're looking for irc channels you can always try #git at irc.freenode.net Git howto/tutorial/... doesn't belong in the kernel mailinglist. Best wishes Kristoffer Ericson On Tue, 27 Nov 2007 23:33:21 +0100 -
Nov 27, 6:55 pm 2007
Willy Tarreau
Re: git guidance
Well, I don't agree with you. His question is about how to use GIT to develop his driver. 1) linux-kernel is a development ML. 2) he needs help from people how already encountered such beginner's issues and who might git very good advices. It should not turn into an endless thread led by people who want to redefine GIT's roadmap, but experience sharing helps a lot with GIT. Tilman, there was a howto by Jeff Garzik I believe. It helped me a lot when I didn't understand a damn comman...
Nov 27, 7:52 pm 2007
J. Bruce Fields
Re: git guidance
It's git@vger.kernel.org. If you post there more specifics about what you tried and what the results were, they might be able to figure out what happened. Also, specifics about which documentation you read would help improve the docs. I believe that the in-tree beginner's documentation (the "tutorial" and the "user manual"--also the first hits for "git tutorial" and "git user manual" on google) explain how to do what you need, but perhaps it's not obvious where. --b. -
Nov 27, 6:54 pm 2007
Greg KH
Re: [RFC] Re: nozomi version 2.1d for review
I have it queued up in my tree to go to Linus for 2.6.25. Is that ok? Frank, want me to take the last version you just sent out and update my version? thanks, greg k-h -
Nov 27, 6:12 pm 2007
travis
[PATCH 1/1] mm: Prevent dereferencing non-allocated per_cpu ...
Change loops controlled by 'for (i = 0; i < NR_CPUS; i++)' to use 'for_each_possible_cpu(i)' when there's a _remote possibility_ of dereferencing a non-allocated per_cpu variable involved. All files except mm/vmstat.c are x86 arch. Based on 2.6.24-rc3-mm1 . Thanks to pageexec@freemail.hu for pointing this out. Signed-off-by: Mike Travis <travis@sgi.com> --- arch/x86/kernel/smp_32.c | 4 ++-- arch/x86/kernel/smpboot_32.c | 4 ++-- arch/x86/xen/smp.c | 4 ++--...
Nov 27, 5:50 pm 2007
pageexec
Re: [PATCH 1/1] mm: Prevent dereferencing non-allocated per_...
actually, it's not that remote, it happens every time NR_CPUS > num_possible_cpus(). i ran into this myself on a dual core box with NR_CPUS=4. due to my rewrite of the i386 per-cpu segment handling, i actually got a NULL deref where the vanilla kernel would be accessing the area of [__per_cpu_start, __per_cpu_end] for each non-possible CPU (which doesn't crash per se but is still not correct somehow i think). -
Nov 27, 6:01 pm 2007
Andi Kleen
Re: [PATCH 1/1] mm: Prevent dereferencing non-allocated per_...
Looks good to me. 2.6.24 candidate. -Andi -
Nov 27, 6:16 pm 2007
Andrew Morton
Re: [PATCH 1/1] mm: Prevent dereferencing non-allocated per_...
On Tue, 27 Nov 2007 23:16:28 +0100 hm. Has anyone any evidence that we're actually touching not-possible-cpu's memory here? Also, the sum_vm_events() change looks buggy - it assumes that cpu_possible_map has no gaps in it. But that change is unneeded because sum_vm_events() is only ever passed cpu_online_map and I'm hoping that we don't usually online not-possible CPUs. --- a/mm/vmstat.c~mm-prevent-dereferencing-non-allocated-per_cpu-variables-fix +++ a/mm/vmstat.c @@ -27,12 +27,12 @@ stati...
Nov 27, 7:12 pm 2007
Andrew Morton Nov 27, 7:21 pm 2007
Christoph Lameter
Re: [PATCH 1/1] mm: Prevent dereferencing non-allocated per_...
Generally the prefetch things have turned out to be not that useful. How about dropping the prefetch? I kept it because it was there. -
Nov 27, 7:22 pm 2007
Andrew Morton
Re: [PATCH 1/1] mm: Prevent dereferencing non-allocated per_...
On Tue, 27 Nov 2007 15:22:56 -0800 (PST) I don't recall anyone ever demonstrating that prefetch is useful in-kernel. I think I've heard of situations where benefits have been seen in userspace - if a loop does a lot of calculation on each datum which it fetches then there's a good opportunity to pipeline the fetch with the on-core crunching. But kernel doesn't do that sort of thing.. -
Nov 27, 7:42 pm 2007
Andi Kleen
Re: [PATCH 1/1] mm: Prevent dereferencing non-allocated per_...
It was demonstrated useful for some specific cases, like context switch early fetch on IA64. But I agree the prefetch on each list_for_each() is probably a bad idea and should be removed. Will also help code size. The best strategy is probably to figure out which oprofile counters to use and then do some profiling and only insert prefetches where the profiler actually finds significant cache misses. -Andi -
Nov 27, 7:48 pm 2007
Christoph Lameter
Re: [PATCH 1/1] mm: Prevent dereferencing non-allocated per_...
I saw it in acpi when the __cpu_offset() pointers become zero. I have never seen it in vmstat.c. We do not need the vmstat.c fix. -
Nov 27, 7:15 pm 2007
Divy Le Ray
[PATCH 2/3] cxgb - fix NAPI
From: Divy Le Ray <divy@chelsio.com> netif_rx_complete() should be called only when work_done < budget. Signed-off-by: Divy Le ray <divy@chelsio.com> --- drivers/net/chelsio/sge.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/chelsio/sge.c b/drivers/net/chelsio/sge.c old mode 100755 new mode 100644 index e8b1036..4b6258f --- a/drivers/net/chelsio/sge.c +++ b/drivers/net/chelsio/sge.c @@ -1625,11 +1625,9 @@ int t1_poll(struct na...
Nov 27, 5:30 pm 2007
Divy Le Ray
[PATCH 3/3] cxgb - fix stats
From: Divy Le Ray <divy@chelsio.com> Fix MAC stats accounting. Fix get_stats. Signed-off-by: Divy Le Ray <divy@chelsio.com> --- drivers/net/chelsio/cxgb2.c | 67 +++++++++++++++++++------ drivers/net/chelsio/pm3393.c | 112 +++++++++++++++++------------------------- drivers/net/chelsio/sge.c | 4 -- drivers/net/chelsio/sge.h | 2 - 4 files changed, 96 insertions(+), 89 deletions(-) diff --git a/drivers/net/chelsio/cxgb2.c b/drivers/net/chelsio/cxgb2.c index 2...
Nov 27, 5:30 pm 2007
Divy Le Ray
[PATCH 1/3] cxgb - fix T2 GSO
From: Divy Le Ray <divy@chelsio.com> The patch ensures that a GSO skb has enough headroom to push an encapsulating cpl_tx_pkt_lso header. Signed-off-by: Divy Le Ray <divy@chelsio.com> --- drivers/net/chelsio/cxgb2.c | 3 ++- drivers/net/chelsio/sge.c | 34 +++++++++++++++------------------- drivers/net/chelsio/sge.h | 1 + 3 files changed, 18 insertions(+), 20 deletions(-) diff --git a/drivers/net/chelsio/cxgb2.c b/drivers/net/chelsio/cxgb2.c old mode 100644 new m...
Nov 27, 5:30 pm 2007
Divy Le Ray
[PATCH 0/3] cxgb - driver fixes.
Jeff, I'm submitting a patch series for inclusion in 2.6.24 for the cxgb driver. The patches are built against Linus'git tree. Here is a brief description: - Ensure that GSO skbs have enough headroom before encapsulating them, - Fix a crash in NAPI mode, - Fix statistics accounting and report. Cheers, Divy -
Nov 27, 5:28 pm 2007
Thomas Tuttle
Oops with 2.6.24 git when loading iwl3945
Hey. I'm using a git snapshot that gentoo distributed mere hours ago (so I'm fairly confident it's current), and I'm getting an Oops when I try to load the iwl3945 driver. I've attached it as plain text. Hope this helps, Thomas Tuttle
Nov 27, 4:43 pm 2007
Saswat Praharaj
Question on splice
Hello All, I am a linux application programmer and kernel newbie. I would like to use splice() / tee() to do some packet forwarding. I think these two systems calls are there in 2.6.18 kernel. My company is deciding to use either 2.6.21 or 2.6.22 kernel in our product. My question is : Is splice() stable in 2.6.21 / 2.6.22 ? I found this link where it says http://lwn.net/Articles/251707/ (search splice) Jens Axboe (2): splice: fix direct splice error handling Fix race with shared ...
Nov 27, 4:38 pm 2007
Bartlomiej Zolnierki...
[git patches] IDE fixes
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: arch/cris/arch-v10/drivers/Kconfig | 39 ----------------------------- arch/cris/arch-v32/drivers/Kconfig | 12 --------- drivers/ide/Kconfig | 47 ++++++++++++++++++++++++++++++++++- drivers/ide/Makefile | 2 +- drivers/ide/cris/ide-cris.c | 7 +++-- drivers/ide/ide-dma.c | 1 + drivers/ide/ide-iops.c ...
Nov 27, 4:39 pm 2007
Jeff Dike
[PATCH] UML - Fix !NO_HZ busy-loop
[ This one needs to get into 2.6.24 ] With NO_HZ disabled, the UML idle loop effectively becomes a busy loop, as it will sleep for no time. The cause was forgetting to restart the tick after waking up from sleep. It was disabled before sleeping, and the remaining time used as the interval to sleep. So, the tick needs to be restarted when nanosleep finishes. This is done by introducing after_sleep_interval, which is empty in the NO_HZ case, but which sets the tick starting in the !NO_HZ case....
Nov 27, 4:03 pm 2007
Andrew Morton
Re: [PATCH] UML - Fix !NO_HZ busy-loop
On Tue, 27 Nov 2007 15:03:47 -0500 -
Nov 27, 7:01 pm 2007
Riki Oktarianto
[PATCH] applesmc - sensors set for MacBook2
On my mid-2007 MacBook2, reading Ts0P sensor always failed with this message: applesmc: wait status failed: 5 != 50. So I assume that there's no such Ts0p sensor in this model (please confirm, anyone). If there's the case, then we need a new set of sensors defined for MacBook2. -- Signed-off-by: Riki Oktarianto <rkoktarianto@gmail.com> --- linux-2.6.24-rc3.orig/drivers/hwmon/applesmc.c +++ linux-2.6.24-rc3/drivers/hwmon/applesmc.c @@ -84,12 +84,15 @@ static const char* temperature_sen...
Nov 27, 3:58 pm 2007
Jeff Dike
tcsetattr(fd, TCSAFLUSH) on an O_ASYNC pts device always fails
tcsetattr(fd, TCSAFLUSH) will always return -EINTR on a pts device when O_ASYNC has been set. This is demonstrated by the test program below - just compile and follow the instructions. You'll get an infinite stream of SIGIOs and -EINTRs. The underlying reason is that the pty driver keeps its TTY_THROTTLED flag set all the time: static void check_unthrottle(struct tty_struct * tty) { if (tty->count && test_and_clear_bit(TTY_THROTTLED, &tty->flags) && tty-...
Nov 27, 2:53 pm 2007
Jens Axboe
WARNING: at arch/x86/kernel/smp_32.c:561 native_smp_call_fun...
Hi, With current -git I get three of these on boot. I'm attaching full boot messages. Linux version 2.6.24-rc3 (axboe@carl) (gcc version 4.2.1 (SUSE Linux)) #20 SMP Tue Nov 27 19:43:25 CET 2007 BIOS-provided physical RAM map: BIOS-e820: 0000000000000000 - 000000000009f000 (usable) BIOS-e820: 000000000009f000 - 00000000000a0000 (reserved) BIOS-e820: 00000000000dc000 - 0000000000100000 (reserved) BIOS-e820: 0000000000100000 - 000000007f6d0000 (usable) BIOS-e820: 000000007f6d0000 - 000000007f...
Nov 27, 2:50 pm 2007
Love, Robert W
[ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project
Hello Linux Community, I'd like to introduce a new Open Source project named Open-FCoE. FCoE is the acronym for Fibre Channel over Ethernet, which is the encapsulation of Fibre Channel frames within Ethernet packets. FCoE will allow systems with an Ethernet adapter and a Fibre Channel Forwarder to login to a Fibre Channel fabric (the FCF is a "gateway" that bridges the LAN and the SAN). That fabric login was previously reserved exclusively for Fibre Channel HBAs. This technology reduces complex...
Nov 27, 2:49 pm 2007
Samuel Thibault
[PATCH] Alpha and x86_64 don't use socketcall
Alpha and x86_64 architectures don't use socketcall and don't provide __NR_socketcall. Signed-off-by: Samuel Thibault <samuel.thibault@citrix.com> diff -r 51b2b0d0921c include/asm-alpha/unistd.h --- a/include/asm-alpha/unistd.h Wed Nov 21 09:41:11 2007 +0000 +++ b/include/asm-alpha/unistd.h Tue Nov 27 16:40:02 2007 +0000 @@ -573,7 +573,6 @@ type name (type1 arg1,type2 arg2,type3 a #define __ARCH_WANT_OLD_READDIR #define __ARCH_WANT_STAT64 #define __ARCH_WANT_SYS_GETHOSTNAME -#define _...
Nov 27, 1:08 pm 2007
Cyrill Gorcunov
Re: possible BUG: unable to handle kernel NULL pointer deref...
[Udo van den Heuvel - Tue, Nov 27, 2007 at 04:23:05PM +0100] | Cyrill Gorcunov wrote: | > On 11/24/07, Udo van den Heuvel <udovdh@xs4all.nl> wrote: | >> Rafael J. Wysocki wrote: | >>> On Saturday, 24 of November 2007, Udo van den Heuvel wrote: | >>>> Hello, | >>>> | >>>> What happened in the attached messages? | >>>> It was on a VIA Epia EN12000, while compiling. | >>>> Yes, the machine has been stable before and af...
Nov 27, 12:49 pm 2007
Udo van den Heuvel
Re: possible BUG: unable to handle kernel NULL pointer deref...
I made a do while loop doing make bzImage modules and a make clean. See the attached .config. This is for my VIA Epia EN12000 board.
Nov 27, 1:41 pm 2007
Martin Schwidefsky
[patch 3/4] dcssblk: prevent early access without own make_r...
From: Christian Borntraeger <borntraeger@de.ibm.com> When loading a dcss segment with the dcssblk driver, sometimes the following kind of message appears: bio too big device dcssblk0 (8 > 0) Buffer I/O error on device dcssblk0, logical block 172016 .. The fix is to move the disk registration after setting the make_request function, to avoid calls into generic_make_request for dcssblock without having the make_request function set up properly. Cc: Gerald Schaefer <gerald.schaefe...
Nov 27, 12:22 pm 2007
Martin Schwidefsky
[patch 4/4] Fix compile error on 31bit without preemption
From: Christian Borntraeger <borntraeger@de.ibm.com> Commit b8e7a54cd06b0b0174029ef3a7f5a1415a2c28f2 introduced a compile error if CONFIG_PREEMPT is not set: arch/s390/kernel/built-in.o: In function `cleanup_io_leave_insn': /space/kvm/arch/s390/kernel/entry.S:(.text+0xbfce): undefined reference to `preempt_schedule_irq' This patch hides preempt_schedule_irq if CONFIG_PREEMPT is not set. Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Martin Schwidefsky...
Nov 27, 12:22 pm 2007
Martin Schwidefsky
[patch 2/4] cio: add missing reprobe loop end statement
From: Peter Oberparleiter <peter.oberparleiter@de.ibm.com> Add loop end statement to prevent looping over empty subchannel sets. Signed-off-by: Peter Oberparleiter <peter.oberparleiter@de.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com> --- drivers/s390/cio/css.c | 1 + 1 file changed, 1 insertion(+) Index: quilt-2.6/drivers/s390/cio/css.c =================================================================== --- quilt-2.6.orig/drivers/s390/cio/css.c +...
Nov 27, 12:22 pm 2007
Martin Schwidefsky
[patch 1/4] cio: Issue SenseID per path.
From: Cornelia Huck <cornelia.huck@de.ibm.com> We may receive a unit check for every path when we issue a SenseID. Unfortunately, the channel subsystem will try on a different path every time if we use a lpm of 0xff, which will exhaust our retry counter. Therefore, revert SenseID to its previous per-path behaviour and just leave out the suspend multipath reconnect. Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com&g...
Nov 27, 12:22 pm 2007
Martin Schwidefsky
[patch 0/4] Latest patches for s390
The following patches have been added to the 2.6.24 queue: Christian Borntraeger (2): [S390] dcssblk: prevent early access without own make_request function [S390] Fix compile error on 31bit without preemption Cornelia Huck (1): [S390] cio: Issue SenseID per path. Peter Oberparleiter (1): [S390] cio: add missing reprobe loop end statement -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -
Nov 27, 12:22 pm 2007
previous daytodaynext day
November 26, 2007November 27, 2007November 28, 2007