On Nov 27, 2007, at 12:40:24, Rafael J. Wysocki wrote:
Why exactly does suspend/hibernation depend on "TASK_INTERRUPTIBLE"
instead of a zero preempt_count()? Really what we should do is just
iterate over all of the actual physical devices and tell each one
"Block new IO requests preemptably, finish pending DMA, put the
hardware in low-power mode, and prepare for suspend/hibernate". As
long as each driver knows how to do those simple things we can have
an entirely consistent kernel image for both suspend and for
hibernation.
When all tasks are preemptable we can very trivially rely on the
drivers to enforce the "Stop new IO submission" with a dirt-simple
semaphore or waitqueue. The sleep itself will be
TASK_UNINTERRUPTIBLE, but it will be done from a preemptible context.
That way the system suspend time is the sum of the suspend times of
the devices on the system, and the suspend time of any given device
is the sum of its maximum non-preemptible critical section and the
time to flush all of its remaining pending DMA/etc. This is almost
completely independent of the load-level of the machine, and it does
not depend on things like NFS filesystems. The one gotcha is that it
does not flush dirty filesystem pages to disk first, although that
could be fixed with a few VFS and blockdev hooks which hierarchically
flush and "freeze" block devices and filesystems before actually
disabling devices much the way that device-mapper can pause a device
to take a snapshot and end up with a clean journal on the filesystem
afterwards.
Cheers,
Kyle Moffett
-
