Re: leak in do_ubd_request

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <jdike@...>
Cc: <user-mode-linux-devel@...>, <linux-kernel@...>
Date: Tuesday, November 27, 2007 - 2:26 pm

> There seems to be no corruption though.  Looking at the code, I can't

Didn't look close enough.

Index: linux/arch/um/drivers/ubd_kern.c
===================================================================
--- linux.orig/arch/um/drivers/ubd_kern.c	2007-11-27 19:23:37.000000000 +0100
+++ linux/arch/um/drivers/ubd_kern.c	2007-11-27 19:24:24.000000000 +0100
@@ -1132,6 +1132,7 @@ static void do_ubd_request(struct reques
 					       "errno = %d\n", -n);
 				else if(list_empty(&dev->restart))
 					list_add(&dev->restart, &restart);
+				kfree(io_req);
 				return;
 			}
 
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
leak in do_ubd_request, Miklos Szeredi, (Tue Nov 27, 12:23 pm)
Re: leak in do_ubd_request, Miklos Szeredi, (Tue Nov 27, 2:26 pm)
Re: [uml-devel] leak in do_ubd_request, Jeff Dike, (Tue Nov 27, 4:11 pm)
Re: [uml-devel] leak in do_ubd_request, Miklos Szeredi, (Tue Nov 27, 4:29 pm)
Re: [uml-devel] leak in do_ubd_request, Jeff Dike, (Tue Nov 27, 6:20 pm)
Re: [uml-devel] leak in do_ubd_request, Andrew Morton, (Wed Nov 28, 1:38 am)
Re: [uml-devel] leak in do_ubd_request, Miklos Szeredi, (Wed Nov 28, 5:37 am)
Re: [uml-devel] leak in do_ubd_request, Jeff Dike, (Wed Nov 28, 11:03 am)