Home » Mailing list archives » linux-kernel » 2007 » November » 27

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Herbert Xu <herbert@...>
To: Andi Kleen <andi@...>
Cc: <rusty@...>, <rdreier@...>, <ak@...>, <netdev@...>, <linux-kernel@...>, <sam@...>
Subject: Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.
Date: Tuesday, November 27, 2007 - 10:36 am

On Tue, Nov 27, 2007 at 03:12:42PM +0100, Andi Kleen wrote:

Wait, that's exactly Rusty's point (I think :)

These symbols are exported because they're needed by protocols.
If they weren't available to everyone then it would be difficult
to start writing new protocols.


Can you be more precise?


Again, if it's used by decnet then it sounds like it should be
exported because new protocol families may need them.

So based on the network code at least I'm kind of starting to
agree with Rusty now: if a symbol is needed by more than one
in-tree module chances are we want it to be exported for all.

Although I admit I haven't examined your examples elsewhere.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH RFC] [1/9] Core module symbol namespaces code and int..., Andi Kleen, (Wed Nov 21, 10:43 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Arnd Bergmann, (Thu Nov 29, 5:55 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Thu Nov 29, 6:00 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Arnd Bergmann, (Thu Nov 29, 6:21 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Roland Dreier, (Sun Nov 25, 4:27 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Sun Nov 25, 9:28 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Stephen Hemminger, (Mon Nov 26, 2:25 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Arjan van de Ven, (Thu Nov 29, 12:53 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Thu Nov 29, 10:18 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Dave Jones, (Tue Nov 27, 3:00 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Adrian Bunk, (Tue Nov 27, 5:09 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., , (Tue Nov 27, 7:00 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Dave Jones, (Tue Nov 27, 5:25 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rick Jones, (Tue Nov 27, 5:15 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Adrian Bunk, (Tue Nov 27, 5:38 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rick Jones, (Tue Nov 27, 10:01 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Roland Dreier, (Mon Nov 26, 6:18 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Roland Dreier, (Mon Nov 26, 2:15 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Tue Nov 27, 12:49 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Jon Masters, (Tue Nov 27, 6:31 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Tue Nov 27, 6:37 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Stephen Hemminger, (Tue Nov 27, 7:00 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Tue Nov 27, 7:06 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Adrian Bunk, (Wed Nov 28, 12:48 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Wed Nov 28, 1:31 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Jonathan Corbet, (Tue Nov 27, 11:43 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Christoph Hellwig, (Tue Nov 27, 12:33 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Tue Nov 27, 11:58 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Tom Tucker, (Tue Nov 27, 1:35 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Tue Nov 27, 9:27 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Tom Tucker, (Wed Nov 28, 12:12 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Adrian Bunk, (Tue Nov 27, 1:15 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Tom Tucker, (Tue Nov 27, 1:45 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Adrian Bunk, (Tue Nov 27, 2:59 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Tue Nov 27, 5:02 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Adrian Bunk, (Tue Nov 27, 1:24 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Arnaldo Carvalho de Melo, (Thu Nov 22, 8:01 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Thu Nov 22, 2:17 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Christoph Hellwig, (Thu Nov 22, 7:06 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Thu Nov 22, 7:54 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Christoph Hellwig, (Thu Nov 22, 8:03 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Wed Nov 21, 11:56 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Thu Nov 22, 7:46 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Thu Nov 22, 8:29 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Roland Dreier, (Sun Nov 25, 4:29 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Sun Nov 25, 9:25 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Roland Dreier, (Mon Nov 26, 1:58 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Tue Nov 27, 12:26 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Tue Nov 27, 6:50 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Tue Nov 27, 9:34 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Herbert Xu, (Tue Nov 27, 9:58 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Tue Nov 27, 10:12 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., , (Tue Nov 27, 4:02 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Herbert Xu, (Tue Nov 27, 10:36 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Christoph Hellwig, (Thu Nov 22, 7:05 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Thu Nov 22, 8:25 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Thu Nov 22, 9:36 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Thu Nov 22, 11:35 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Fri Nov 23, 3:53 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Sat Nov 24, 12:53 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Sat Nov 24, 8:39 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Sun Nov 25, 9:23 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Dave Young, (Thu Nov 22, 4:41 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Thu Nov 22, 2:19 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Dave Young, (Thu Nov 22, 10:06 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Dave Jones, (Wed Nov 21, 11:52 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Arjan van de Ven, (Wed Nov 21, 11:03 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Andi Kleen, (Wed Nov 21, 11:37 pm)
[PATCH RFC] [7/9] Convert TCP exports into namespaces, Andi Kleen, (Wed Nov 21, 10:43 pm)
[PATCH RFC] [8/9] Put UDP exports into a namespace, Andi Kleen, (Wed Nov 21, 10:43 pm)
[PATCH RFC] [9/9] Add a inet namespace, Andi Kleen, (Wed Nov 21, 10:43 pm)
[PATCH RFC] [6/9] Implement namespace checking in modpost, Andi Kleen, (Wed Nov 21, 10:43 pm)
[PATCH RFC] [4/9] modpost: Fix format string warnings, Andi Kleen, (Wed Nov 21, 10:43 pm)
Re: [PATCH RFC] [4/9] modpost: Fix format string warnings, Sam Ravnborg, (Mon Dec 10, 2:50 pm)
[PATCH RFC] [5/9] modpost: Fix a buffer overflow in modpost, Andi Kleen, (Wed Nov 21, 10:43 pm)
Re: [PATCH RFC] [5/9] modpost: Fix a buffer overflow in modp..., Sam Ravnborg, (Mon Dec 10, 3:32 pm)
Re: [PATCH RFC] [5/9] modpost: Fix a buffer overflow in modp..., Andi Kleen, (Mon Dec 10, 3:57 pm)
Re: [PATCH RFC] [5/9] modpost: Fix a buffer overflow in modp..., Sam Ravnborg, (Mon Dec 10, 4:07 pm)
[PATCH RFC] [3/9] modpost: Declare the modpost error functio..., Andi Kleen, (Wed Nov 21, 10:43 pm)
Re: [PATCH RFC] [3/9] modpost: Declare the modpost error fun..., Sam Ravnborg, (Mon Dec 10, 2:50 pm)
Re: [PATCH RFC] [3/9] modpost: Declare the modpost error fun..., Rusty Russell, (Tue Dec 11, 9:37 pm)
Re: [PATCH RFC] [3/9] modpost: Declare the modpost error fun..., Andi Kleen, (Mon Dec 10, 2:58 pm)
[PATCH RFC] [2/9] Fix duplicate symbol check to also check f..., Andi Kleen, (Wed Nov 21, 10:43 pm)