Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Roland Dreier <rdreier@...>
Cc: Andi Kleen <ak@...>, <netdev@...>, <linux-kernel@...>, <sam@...>
Date: Tuesday, November 27, 2007 - 12:49 am

On Monday 26 November 2007 17:15:44 Roland Dreier wrote:

No, I was the one who moved exports near their declarations.  That's 
organised.  I just don't see how this new "organization" will help: oh good, 
I won't accidentally use the udp functions any more?!?


Perhaps you've got lots of patches were people are using internal APIs they 
shouldn't?


Well, introduce an EXPORT_SYMBOL_INTERNAL().  It's a lot less code.  But you'd 
still need to show that people are having trouble knowing what APIs to use.


There is no "exported API" to bring under control.  There are symbols we 
expose for the kernel's own use which can be used by external modules at 
their own risk.  


No.  That's the wrong question.  What's the real upside?

Let's not put code in the core because "it doesn't seem to hurt".

I'm sure you think there's a real problem, but I'm still waiting for someone 
to *show* it to me.  Then we can look at solutions.

Rusty.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Stephen Hemminger, (Mon Nov 26, 2:25 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Arjan van de Ven, (Thu Nov 29, 12:53 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Rusty Russell, (Tue Nov 27, 12:49 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Stephen Hemminger, (Tue Nov 27, 7:00 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Christoph Hellwig, (Tue Nov 27, 12:33 pm)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Arnaldo Carvalho de Melo, (Thu Nov 22, 8:01 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Christoph Hellwig, (Thu Nov 22, 7:06 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Christoph Hellwig, (Thu Nov 22, 8:03 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Christoph Hellwig, (Thu Nov 22, 7:05 am)
Re: [PATCH RFC] [1/9] Core module symbol namespaces code and..., Arjan van de Ven, (Wed Nov 21, 11:03 pm)
[PATCH RFC] [7/9] Convert TCP exports into namespaces, Andi Kleen, (Wed Nov 21, 10:43 pm)
[PATCH RFC] [8/9] Put UDP exports into a namespace, Andi Kleen, (Wed Nov 21, 10:43 pm)
[PATCH RFC] [9/9] Add a inet namespace, Andi Kleen, (Wed Nov 21, 10:43 pm)
[PATCH RFC] [4/9] modpost: Fix format string warnings, Andi Kleen, (Wed Nov 21, 10:43 pm)