[Patch 1/5] sched: code cleanup

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: <dmitry.adamushko@...>, <a.p.zijlstra@...>, <dhaval@...>, <linux-kernel@...>, <efault@...>, <skumar@...>, Balbir Singh <balbir@...>, Dipankar <dipankar@...>
Date: Tuesday, November 27, 2007 - 1:08 am

Minor cleanups:

- Fix coding style
- remove obsolete comment


Signed-off-by: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>

---
 kernel/sched.c |   21 +++------------------
 1 files changed, 3 insertions(+), 18 deletions(-)

Index: current/kernel/sched.c
===================================================================
--- current.orig/kernel/sched.c
+++ current/kernel/sched.c
@@ -191,12 +191,12 @@ struct task_group init_task_group = {
 };
 
 #ifdef CONFIG_FAIR_USER_SCHED
-# define INIT_TASK_GRP_LOAD	2*NICE_0_LOAD
+# define INIT_TASK_GROUP_LOAD	2*NICE_0_LOAD
 #else
-# define INIT_TASK_GRP_LOAD	NICE_0_LOAD
+# define INIT_TASK_GROUP_LOAD	NICE_0_LOAD
 #endif
 
-static int init_task_group_load = INIT_TASK_GRP_LOAD;
+static int init_task_group_load = INIT_TASK_GROUP_LOAD;
 
 /* return group to which a task belongs */
 static inline struct task_group *task_group(struct task_struct *p)
@@ -864,21 +864,6 @@ iter_move_one_task(struct rq *this_rq, i
 
 #define sched_class_highest (&rt_sched_class)
 
-/*
- * Update delta_exec, delta_fair fields for rq.
- *
- * delta_fair clock advances at a rate inversely proportional to
- * total load (rq->load.weight) on the runqueue, while
- * delta_exec advances at the same rate as wall-clock (provided
- * cpu is not idle).
- *
- * delta_exec / delta_fair is a measure of the (smoothened) load on this
- * runqueue over any given interval. This (smoothened) load is used
- * during load balance.
- *
- * This function is called /before/ updating rq->load
- * and when switching tasks.
- */
 static inline void inc_load(struct rq *rq, const struct task_struct *p)
 {
 	update_load_add(&rq->load, p->se.load.weight);


-- 
Regards,
vatsa
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/2] sched: Group scheduler related patches, Srivatsa Vaddagiri, (Mon Nov 19, 8:27 am)
[PATCH 2/2] sched: Improve fairness of cpu allocation for ta..., Srivatsa Vaddagiri, (Mon Nov 19, 8:30 am)
Re: [PATCH 2/2] sched: Improve fairness of cpu allocation fo..., Srivatsa Vaddagiri, (Mon Nov 19, 11:03 am)
Re: [PATCH 2/2] sched: Improve fairness of cpu allocation fo..., Srivatsa Vaddagiri, (Mon Nov 19, 12:06 pm)
[PATCH 0/4] sched: group scheduler related patches (V3), Srivatsa Vaddagiri, (Mon Nov 26, 1:00 am)
[Patch 4/4] sched: Improve fairness of cpu bandwidth allocat..., Srivatsa Vaddagiri, (Mon Nov 26, 1:09 am)
[Patch 0/5] sched: group scheduler related patches (V4), Srivatsa Vaddagiri, (Tue Nov 27, 1:06 am)
Re: [Patch 0/5] sched: group scheduler related patches (V4), Srivatsa Vaddagiri, (Tue Nov 27, 7:42 am)
Re: [Patch 0/5] sched: group scheduler related patches (V4), Srivatsa Vaddagiri, (Tue Nov 27, 10:32 am)
[Patch 5/5] sched: Improve fairness of cpu bandwidth allocat..., Srivatsa Vaddagiri, (Tue Nov 27, 1:27 am)
[Patch 4/5] sched: introduce a mutex and corresponding API t..., Srivatsa Vaddagiri, (Tue Nov 27, 1:21 am)
[Patch 3/5 v2] sched: change how cpu load is calculated, Srivatsa Vaddagiri, (Tue Nov 27, 1:12 am)
[Patch 3/5 v1] sched: change how cpu load is calculated, Srivatsa Vaddagiri, (Tue Nov 27, 1:11 am)
[Patch 2/5] sched: minor fixes for group scheduler, Srivatsa Vaddagiri, (Tue Nov 27, 1:09 am)
[Patch 1/5] sched: code cleanup, Srivatsa Vaddagiri, (Tue Nov 27, 1:08 am)
[Patch 3/4 v2] sched: change how cpu load is calculated, Srivatsa Vaddagiri, (Mon Nov 26, 1:06 am)
[Patch 3/4 v1] sched: change how cpu load is calculated, Srivatsa Vaddagiri, (Mon Nov 26, 1:05 am)
[PATCH 2/4] sched: minor fixes for group scheduler, Srivatsa Vaddagiri, (Mon Nov 26, 1:03 am)
[PATCH 1/4] sched: code cleanup, Srivatsa Vaddagiri, (Mon Nov 26, 1:02 am)
[PATCH 1/2] sched: Minor cleanups, Srivatsa Vaddagiri, (Mon Nov 19, 8:28 am)
Re: [PATCH 1/2] sched: Minor cleanups, Ingo Molnar, (Mon Nov 19, 9:08 am)
Re: [PATCH 1/2] sched: Minor cleanups, Srivatsa Vaddagiri, (Mon Nov 19, 11:01 am)