[PATCH] lguest: prevent VISWS or VOYAGER randconfigs

Previous thread: [patch 07/14] percpu: Make the asm-generic/percpu.h more generic by Christoph Lameter on Monday, November 26, 2007 - 8:14 pm. (1 message)

Next thread: Re: Small System Paging Problem - OOM-killer goes nuts by Ian Kumlien on Monday, November 26, 2007 - 9:47 pm. (1 message)
To: lkml <linux-kernel@...>
Cc: <rusty@...>, akpm <akpm@...>
Date: Monday, November 26, 2007 - 8:57 pm

From: Randy Dunlap <randy.dunlap@oracle.com>

Keep lguest from being enabled on VISWS or VOYAGER configs, just as is
already done for VMI and XEN. Otherwise randconfigs with VISWS and
LGUEST have this problem:

In file included from arch/x86/kernel/setup_32.c:61:
include/asm-x86/mach-visws/setup_arch.h:8:1: warning: "ARCH_SETUP" redefined
In file included from include/asm/msr.h:80,
from include/asm/processor_32.h:17,
from include/asm/processor.h:2,
from include/asm/thread_info_32.h:16,
from include/asm/thread_info.h:2,
from include/linux/thread_info.h:21,
from include/linux/preempt.h:9,
from include/linux/spinlock.h:49,
from include/linux/seqlock.h:29,
from include/linux/time.h:8,
from include/linux/timex.h:57,
from include/linux/sched.h:53,
from arch/x86/kernel/setup_32.c:24:
include/asm/paravirt.h:458:1: warning: this is the location of the previous definition

(and of course, this happens because kconfig does not follow dependencies
when [evil] select is used...)

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
arch/x86/lguest/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- linux-2.6.24-rc3-git1.orig/arch/x86/lguest/Kconfig
+++ linux-2.6.24-rc3-git1/arch/x86/lguest/Kconfig
@@ -2,6 +2,7 @@ config LGUEST_GUEST
bool "Lguest guest support"
select PARAVIRT
depends on !X86_PAE
+ depends on !(X86_VISWS || X86_VOYAGER)
select VIRTIO
select VIRTIO_RING
select VIRTIO_CONSOLE
-

Previous thread: [patch 07/14] percpu: Make the asm-generic/percpu.h more generic by Christoph Lameter on Monday, November 26, 2007 - 8:14 pm. (1 message)

Next thread: Re: Small System Paging Problem - OOM-killer goes nuts by Ian Kumlien on Monday, November 26, 2007 - 9:47 pm. (1 message)