Home » Mailing list archives » linux-kernel » 2007 » November » 26

Re: [PATCH 05/27] rename open_namei() to open_pathname()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Christoph Hellwig
Subject: Re: [PATCH 05/27] rename open_namei() to open_pathname()
Date: Monday, November 26, 2007 - 7:33 am

On Thu, Nov 01, 2007 at 04:08:32PM -0700, Dave Hansen wrote:

The name is quite non-descriptive.  What about just leaving it as
filp_open and merging this into the previous patches to avoid
the spurious renaming?

And btw, exported functions that get half-rewritten should always
grow a kerneldoc comment.  Then again this particular one really
shouldn't be exported, but that's for another series.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/27] Read-only bind mounts (-mm resend), Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 01/27] do namei_flags calculation inside open_namei(), Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 02/27] make open_namei() return a filp, Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 03/27] kill do_filp_open(), Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 04/27] kill filp_open(), Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 05/27] rename open_namei() to open_pathname(), Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 06/27] r-o-bind-mounts-stub-functions, Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 07/27] r-o-bind-mounts-do_rmdir-elevate-write-count, Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 08/27] r-o-bind-mounts-elevate-mnt-writers-for-call ..., Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 09/27] r-o-bind-mounts-elevate-mnt-writers-for-vfs_ ..., Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 10/27] r-o-bind-mounts-elevate-mount-count-for-exte ..., Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 11/27] r-o-bind-mounts-elevate-write-count-during-e ..., Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 12/27] r-o-bind-mounts-elevate-write-count-for-do_s ..., Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 13/27] r-o-bind-mounts-elevate-write-count-for-do_u ..., Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 14/27] r-o-bind-mounts-elevate-write-count-for-file ..., Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 15/27] r-o-bind-mounts-elevate-write-count-for-link ..., Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 16/27] r-o-bind-mounts-elevate-write-count-for-some ..., Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 17/27] r-o-bind-mounts-elevate-write-count-opend-files, Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 18/27] r-o-bind-mounts-elevate-write-count-over-cal ..., Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 19/27] r-o-bind-mounts-elevate-writer-count-for-cho ..., Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 20/27] r-o-bind-mounts-elevate-writer-count-for-do_ ..., Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 21/27] r-o-bind-mounts-make-access-use-mnt-check, Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 22/27] r-o-bind-mounts-nfs-check-mnt-instead-of-sup ..., Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 23/27] r-o-bind-mounts-sys_mknodat-elevate-write-co ..., Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 24/27] r-o-bind-mounts-track-number-of-mount-writers, Dave Hansen, (Thu Nov 1, 4:08 pm)
[PATCH 25/27] r-o-bind-mounts-track-number-of-mount-writer ..., Dave Hansen, (Thu Nov 1, 4:09 pm)
[PATCH 26/27] r-o-bind-mounts-honor-r-w-changes-at-do_remo ..., Dave Hansen, (Thu Nov 1, 4:09 pm)
[PATCH 27/27] keep track of mnt_writer state of struct file, Dave Hansen, (Thu Nov 1, 4:09 pm)
Re: [PATCH 16/27] r-o-bind-mounts-elevate-write-count-for- ..., Andrew Morton, (Mon Nov 5, 4:23 pm)
Re: [PATCH 25/27] r-o-bind-mounts-track-number-of-mount-wr ..., Andrew Morton, (Mon Nov 5, 4:35 pm)
Re: [PATCH 16/27] r-o-bind-mounts-elevate-write-count-for- ..., Jan Kara, (Tue Nov 6, 2:01 am)
Re: [PATCH 16/27] r-o-bind-mounts-elevate-write-count-for- ..., Andrew Morton, (Tue Nov 6, 2:12 am)
Re: [PATCH 05/27] rename open_namei() to open_pathname(), Christoph Hellwig, (Mon Nov 26, 7:33 am)
Re: [PATCH 04/27] kill filp_open(), Andrew Morton, (Wed Jan 16, 1:52 am)
Re: [PATCH 04/27] kill filp_open(), Dave Hansen, (Wed Jan 16, 10:04 am)
Re: [PATCH 04/27] kill filp_open(), Christoph Hellwig, (Wed Jan 16, 10:10 am)
Re: [PATCH 04/27] kill filp_open(), Bryn M. Reeves, (Wed Jan 16, 10:12 am)
Re: [PATCH 04/27] kill filp_open(), Dave Hansen, (Wed Jan 16, 10:41 am)
Re: [PATCH 04/27] kill filp_open(), Christoph Hellwig, (Wed Jan 16, 10:47 am)