Re: [PATCH 10/27] ptrace: generic resume

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Roland McGrath <roland@...>

Cc: Andrew Morton <akpm@...>, Linus Torvalds <torvalds@...>, <linux-kernel@...>, Thomas Gleixner <tglx@...>, Ingo Molnar <mingo@...>, H. Peter Anvin <hpa@...>

Subject: Re: [PATCH 10/27] ptrace: generic resume

Date: Sunday, November 25, 2007 - 6:23 pm

On Sun, Nov 25, 2007 at 02:01:09PM -0800, Roland McGrath wrote:
quoted text> This makes ptrace_request handle all the ptrace requests that wake
> up the traced task.  These do low-level ptrace implementation magic
> that is not arch-specific and should be kept out of arch code.  The
> implementations on each arch usually do the same thing.  The new
> generic code makes use of the arch_has_single_step macro and generic
> entry points to handle PTRACE_SINGLESTEP.

Nice, I've been trying to get people to move this to common code for
a while :)


quoted text> +#ifdef PTRACE_SINGLESTEP
> +#define is_singlestep(request)		((request) == PTRACE_SINGLESTEP)
> +#else
> +#define is_singlestep(request)		0
> +#endif
> +
> +#ifdef PTRACE_SYSEMU
> +#define is_sysemu_singlestep(request)	((request) == PTRACE_SYSEMU_SINGLESTEP)
> +#else
> +#define is_sysemu_singlestep(request)	0
> +#endif

Could we by any chance just force every architecture using generic code
to implement PTRACE_SINGLESTEP and PTRACE_SYSEMU?  This will lead to
both far less messy code and a more consistant user interface.

-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 01/27] ptrace: arch_has_single_step, Roland McGrath, (Sun Nov 25, 5:55 pm)

Re: [PATCH 01/27] ptrace: arch_has_single_step, Andrew Morton, (Tue Nov 27, 4:53 am)

Re: [PATCH 01/27] ptrace: arch_has_single_step, Roland McGrath, (Tue Nov 27, 7:05 pm)

Re: [PATCH 01/27] ptrace: arch_has_single_step, Ingo Molnar, (Tue Nov 27, 7:58 pm)

Re: [PATCH 01/27] ptrace: arch_has_single_step, Roland McGrath, (Tue Nov 27, 8:08 pm)

Re: [PATCH 01/27] ptrace: arch_has_single_step, Ingo Molnar, (Tue Nov 27, 6:38 am)

Re: [PATCH 01/27] ptrace: arch_has_single_step, Christoph Hellwig, (Sun Nov 25, 6:22 pm)

Re: [PATCH 01/27] ptrace: arch_has_single_step, Roland McGrath, (Sun Nov 25, 6:59 pm)

[PATCH 27/27] x86: PTRACE_SINGLEBLOCK, Roland McGrath, (Sun Nov 25, 6:08 pm)

[PATCH 26/27] x86: debugctlmsr kprobes, Roland McGrath, (Sun Nov 25, 6:08 pm)

[PATCH 25/27] x86: debugctlmsr arch_has_block_step, Roland McGrath, (Sun Nov 25, 6:08 pm)

[PATCH 24/27] x86: debugctlmsr context switch, Roland McGrath, (Sun Nov 25, 6:08 pm)

[PATCH 23/27] x86: debugctlmsr kconfig, Roland McGrath, (Sun Nov 25, 6:08 pm)

Re: [PATCH 23/27] x86: debugctlmsr kconfig, Dave Jones, (Sun Nov 25, 9:57 pm)

Re: [PATCH 23/27] x86: debugctlmsr kconfig, Roland McGrath, (Mon Nov 26, 4:06 am)

Re: [PATCH 23/27] x86: debugctlmsr kconfig, Denys Vlasenko, (Sun Nov 25, 9:09 pm)

Re: [PATCH 23/27] x86: debugctlmsr kconfig, Roland McGrath, (Mon Nov 26, 3:51 am)

Re: [PATCH 23/27] x86: debugctlmsr kconfig, Denys Vlasenko, (Mon Nov 26, 6:52 pm)

[PATCH 22/27] x86: debugctlmsr constants, Roland McGrath, (Sun Nov 25, 6:06 pm)

[PATCH 19/27] x86-32 ptrace debugreg cleanup, Roland McGrath, (Sun Nov 25, 6:05 pm)

[PATCH 21/27] ptrace: generic PTRACE_SINGLEBLOCK, Roland McGrath, (Sun Nov 25, 6:06 pm)

[PATCH 20/27] ptrace: arch_has_block_step, Roland McGrath, (Sun Nov 25, 6:05 pm)

Re: [PATCH 20/27] ptrace: arch_has_block_step, David Wilder, (Wed Nov 28, 7:39 pm)

Re: [PATCH 20/27] ptrace: arch_has_block_step, Roland McGrath, (Wed Nov 28, 7:58 pm)

[PATCH 17/27] x86-64 ptrace debugreg cleanup, Roland McGrath, (Sun Nov 25, 6:04 pm)

[PATCH 18/27] x86-64 ia32 ptrace debugreg cleanup, Roland McGrath, (Sun Nov 25, 6:05 pm)

[PATCH 16/27] x86-64 ptrace: use task_pt_regs, Roland McGrath, (Sun Nov 25, 6:04 pm)

[PATCH 13/27] powerpc: arch_has_single_step, Roland McGrath, (Sun Nov 25, 6:03 pm)

[PATCH 15/27] x86-32 ptrace: use task_pt_regs, Roland McGrath, (Sun Nov 25, 6:04 pm)

[PATCH 14/27] powerpc: ptrace generic resume, Roland McGrath, (Sun Nov 25, 6:04 pm)

Re: [PATCH 14/27] powerpc: ptrace generic resume, Srinivasa Ds, (Mon Dec 3, 4:12 am)

[PATCH 09/27] x86 single_step: TIF_FORCED_TF, Roland McGrath, (Sun Nov 25, 6:00 pm)

[PATCH 11/27] x86-64: ptrace generic resume, Roland McGrath, (Sun Nov 25, 6:01 pm)

[PATCH 10/27] ptrace: generic resume, Roland McGrath, (Sun Nov 25, 6:01 pm)

Re: [PATCH 10/27] ptrace: generic resume, Christoph Hellwig, (Sun Nov 25, 6:23 pm)

Re: [PATCH 10/27] ptrace: generic resume, Roland McGrath, (Sun Nov 25, 6:37 pm)

[PATCH 12/27] x86-32: ptrace generic resume, Roland McGrath, (Sun Nov 25, 6:01 pm)

[PATCH 05/27] x86: single_step moved, Roland McGrath, (Sun Nov 25, 5:59 pm)

[PATCH 08/27] x86: single_step: share code, Roland McGrath, (Sun Nov 25, 6:00 pm)

[PATCH 06/27] x86: single_step segment macros, Roland McGrath, (Sun Nov 25, 5:59 pm)

[PATCH 07/27] x86: single_step 0xf0, Roland McGrath, (Sun Nov 25, 6:00 pm)

[PATCH 03/27] x86: remove TRAP_FLAG, Roland McGrath, (Sun Nov 25, 5:58 pm)

[PATCH 04/27] x86: arch_has_single_step, Roland McGrath, (Sun Nov 25, 5:59 pm)

[PATCH 02/27] x86: segment selector macros, Roland McGrath, (Sun Nov 25, 5:58 pm)


linux-kernel:
Andrew Morton	-mm merge plans for 2.6.23
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
david	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
openbsd-misc:

linux-netdev:
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 03/37] dccp: List management for new feature negotiation
Arjan van de Ven	Re: [GIT]: Networking
Auke Kok	[PATCH] e1000e: test MSI interrupts
git:

Re: [PATCH 10/27] ptrace: generic resume

Online users